Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: live627 on November 5th, 2012, 01:07 AM

Title: Viewing an unread media item does not mark it as read
Post by: live627 on November 5th, 2012, 01:07 AM
Shouldn't they behave like marked messages?

On a side note, clicking the button to mark all items as read works.
Title: Re: Viewing an unread media item does not mark it as read
Post by: live627 on January 16th, 2013, 09:28 AM
How is this supposed too work? The unread media item is silently marked read when it is viewed?

(Also bump...)
Title: Re: Viewing an unread media item does not mark it as read
Post by: Nao on January 16th, 2013, 01:29 PM
You have to visit the item page. Maybe. I think Shitiz wrote the logic for this but I remember working on making it work too. Hmm.
Title: Re: Viewing an unread media item does not mark it as read
Post by: live627 on January 18th, 2013, 06:25 AM
It then needs fixing to be so.
Title: Re: Viewing an unread media item does not mark it as read
Post by: Nao on January 18th, 2013, 05:29 PM
So... Went to the Unseen page, clicked on an image thumbnail, it launched the preview (not the full image, mind you), reloaded page, had everything except for that item.

So yeah, it's working I'm afraid...!
Title: Re: Viewing an unread media item does not mark it as read
Post by: live627 on January 19th, 2013, 07:11 AM
Did you try it on plugins? I mean, documents, and not images.
Title: Re: Viewing an unread media item does not mark it as read
Post by: godboko71 on January 19th, 2013, 07:32 AM
via ipad if I visit images they get marked seen, however If I visit a document page they are not marked seen
Title: Re: Viewing an unread media item does not mark it as read
Post by: Nao on January 19th, 2013, 03:56 PM
Okay, now I see it... I didn't open the page for non-images because I thought it'd work. It works in AeMe for SMF... :-/

I've looked into the source code, and can't find the reason for it.
Basically, $item_data['is_new'] is set to 0 when on an item page, so it doesn't attempt to mark it as seen, but set to 1 on the unseen page.
Need more time to find the culprit... -_-
Title: Re: Viewing an unread media item does not mark it as read
Post by: Nao on January 24th, 2013, 11:06 PM
Fixed!

I'd love to know how this bug came into being. None of the other log_media queries had it...
Title: Re: Viewing an unread media item does not mark it as read
Post by: Arantor on January 24th, 2013, 11:07 PM
Just as a side note, I'd add that no-one who reads the Aeva thread seems to be aware that you're not posting in it. Perhaps next time it comes up I should give them a reminder...
Title: Re: Viewing an unread media item does not mark it as read
Post by: Nao on January 24th, 2013, 11:11 PM
Not surprised. Last time I checked it, a year ago at least, people acted like it was part of SMF and thus the team knew everything about it.
Mehh.

Still. I pretty much abandoned aeme even in Wedge and that's a shame. I so wanted it to be the first stone in my building: having any type of content available as floating topics.

Sob.
Title: Re: Viewing an unread media item does not mark it as read
Post by: Arantor on January 24th, 2013, 11:14 PM
It is a valid way to go but it is also a source of much complexity :/
Title: Re: Viewing an unread media item does not mark it as read
Post by: Nao on January 24th, 2013, 11:19 PM
The lack of floating topics in Wedge may very well end up being my biggest regret.
Heck even Drupal is based entirely on that...
Title: Re: Viewing an unread media item does not mark it as read
Post by: Arantor on January 24th, 2013, 11:24 PM
And it's one of the reasons Drupal is an architectural mess.

However, it's not that big a deal for us to implement, really. We already have some structure around boards being different types. If we extend that to include albums, a topic in an album board by definition is a topic about a media item. We just need to ensure there is proper logic around allowing/disallowing items to be moved between them inappropriately.

There are a lot more issues that we need to deal with, though it's something that I can do some work on tonight rather than banging my head off the ban UI, I guess.