Public area => Bug reports => The Pub => Archived fixes => Topic started by: live627 on November 5th, 2012, 12:26 AM
Title: Delete member does not delete PM rules
Post by: live627 on November 5th, 2012, 12:26 AM
A search on Subs-Members for pm_rules doesn't turn anything up.
Title: Re: Delete member does not delete PM rules
Post by: Arantor on November 5th, 2012, 12:30 AM
Aren't PM rules stored in the members table?
EDIT: I'm thinking of labels, not rules, ignore me.
Posted: November 5th, 2012, 12:27 AM
Fixed locally, will commit in next round of commits, thanks.
Title: Re: Delete member does not delete PM rules
Post by: Nao on November 5th, 2012, 12:38 AM
In the same vein, maybe it should be pointed out that the bug that prevented testers from downloading Wedge for a couple of days was due to the fact that the media profile permissions weren't set for them.
Which leads me to two remarks about permission copying:
- we should make it clearer in the permissions page what the difference between 'inherit' and 'base' is (I actually had to go through the source code to be sure I was going to 'copy' them from the Regular Members table!) - when copying permissions from another membergroup, also copy their media profile permissions!! i.e. go through all media permission profiles, get the original membergroup's permissions, and copy them for the new membergroup.
I know it's a PITA, but it's safer that way. Do you think you can do it, Pete? I'm way too uncomfortable with permission code. But OTOH, here it's mostly media permissions, which you may not be as well versed into. My knowledge about them is not perfect either -- that feature was broken by Dragooon, and I had to learn how to use it first. And it was years ago...
Title: Re: Delete member does not delete PM rules
Post by: Arantor on November 5th, 2012, 12:43 AM
Is this in the wrong topic?
Title: Re: Delete member does not delete PM rules
Post by: Arantor on November 5th, 2012, 01:28 AM
Fixed original issue in r1768. Not marking solved since I think the above two posts should be in another topic but will leave for now.