Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Farjo on November 4th, 2012, 09:06 PM

Title: Modify board: "All groups who can see a board can enter it as well"
Post by: Farjo on November 4th, 2012, 09:06 PM
I'm really chuffed by the look of this feature because I've got my board set up in a well cack-handed way, and this'll make thinks much simpler.

However, I cannot get it to work. I've un-ticked this option to reveal the extra panel, but unless Regular Members are given permission in this second panel they cannot see the board i.e. they can only see General Discussion.

Am I missing a trick?
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 4th, 2012, 09:09 PM
I don't understand how you've set it up.

The first panel is for seeing the board, the second for entering the board.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Farjo on November 4th, 2012, 09:22 PM
Please see attached. I created a new board and would like it to be visible to everyone who is logged in, but only members of the 'ncaccess' group should be able to enter it.

I registered a new member and (using IE) I can only see the General Discussion board, unless I change the Regular Members option on the right.
Title: Re: Modify board: \
Post by: Arantor on November 5th, 2012, 12:38 AM
Ah, I see. I also know what the problem is.

In this case, the board index is using the wrong permission (it's using the 'can enter' not 'can see'), because I seem to recall I didn't fix up it handling the last post's visibility - the last post should always be in a board you can see.

Or should it? If it's a board you can see but can't enter, should you be able to see the last post?
Title: Re: Modify board: \
Post by: spoogs on November 5th, 2012, 04:15 AM
Quote from Arantor on November 5th, 2012, 12:38 AM
Or should it? If it's a board you can see but can't enter, should you be able to see the last post?
I would say you should not be able to see the last post if you cannot enter the board.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 5th, 2012, 04:22 AM
That was my gut feeling, and the underlying logic needs to change to make that work. But that's no biggie, I'll fix that after my current project.
Title: Re: Modify board: \
Post by: Anthony` on November 5th, 2012, 04:23 AM
Quote from spoogs on November 5th, 2012, 04:15 AM
Quote from Arantor on November 5th, 2012, 12:38 AM
Or should it? If it's a board you can see but can't enter, should you be able to see the last post?
I would say you should not be able to see the last post if you cannot enter the board.
I agree with this. If member's can't see the contents of the board, it would probably be a bad idea if they were to see a detail such as the last post's title when they got the chance assuming the board is supposed to be private.
Posted: November 5th, 2012, 04:22 AM

PS: Arantor, when someone else posts before submitting a reply is there supposed to be a notice in place like how SMF does it?
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 5th, 2012, 04:28 AM
There is such an option. It works just fine for me.

But I know I reset it in my profile. I have the awful feeling it's broken when I rewrote the member options code to have a more sane UI.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 5th, 2012, 05:28 AM
In other news, I fixed it in r1770. Complete with having a warning instead of otherwise fudging the last post.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Farjo on November 5th, 2012, 06:52 AM
Ooh, thanks Arantor looks perfect :)
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: spoogs on November 5th, 2012, 02:17 PM
Could that message be admin customizable by board?

The reason I ask is that in some cases there would be some criteria to enter to the board such as a subscription, or group specific.

"A subscription is required to enter this board and view the discussions"
"To enter this board you must join the Whichever Group"
Etc....
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 5th, 2012, 03:38 PM
It could, I guess, but right now, no. It doesn't help that there's nowhere to store it - and it would have to be customisable per language.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Farjo on November 7th, 2012, 07:30 AM
Have just upgraded and it's looking perfect, will give it a proper bash later.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 13th, 2012, 01:31 AM
I want to mark it closed, but I'm still not sure about how the whole thing with per-board visibility rules wording would play out.

The nearest thing I can think of is similar to how it is in the Q&A UI where you can add different language questions... as far as storage goes, it's not a huge deal to take the per board information (provided you don't have way too many languages and way too long messages), serialize it into a TEXT in the boards table, though I can think it might be a performance hit when loading the board index.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 27th, 2012, 04:36 AM
I did do a bit of digging around on this one and honestly, I'm finding a lot of cases where people just put it into the description.

That said, it's rare to have multiple languages mixed in one board, so I suppose it need only be done with a single box per board, as you can't have multiple board titles per board for different languages (not that it would make much sense even if you did - the topics aren't going to be translated)
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Farjo on November 27th, 2012, 09:27 PM
"That said, it's rare to have multiple languages mixed in one board"
Yes of course you're right - obvious now you've said it.

Anyway have given it a bigger bash and nothing fell out :)
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 27th, 2012, 09:54 PM
That's the perk of going away and thinking about it, it allows you the luxury of figuring out the 'obvious' points which aren't obvious until you realise them, then they are completely obvious.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on November 28th, 2012, 05:48 AM
r1784 has this facility now. It's not overly elegant but the best I can do for now.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Farjo on November 28th, 2012, 09:56 AM
Sounds good.
Title: Re: Modify board: "All groups who can see a board can enter it as well"
Post by: Arantor on December 9th, 2012, 11:50 PM
I'm not sure what else I'm going to do with this feature, so I guess that's solved for now. No doubt we'll get better feedback once it's in an alpha.