Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Arantor on October 4th, 2012, 06:10 PM

Title: Modify group does not show correct UI for board access
Post by: Arantor on October 4th, 2012, 06:10 PM

Some time ago I modified the way board access is handled, so that it is possible to exclude people from boards, as well as separating board visibility from board access.

I also updated the UI in manage boards to cover this, but the reverse option - setting what boards a given group can see - has not yet been updated, mostly because I haven't figured out a nice way to display it given the way board hierarchy can be handled and thus you need the ability to provide indentation and stuff...

Title: Re: Modify group does not show correct UI for board access
Post by: Nao on October 26th, 2012, 07:11 PM

Any plans to fix that? :eheh:

Title: Re: Modify group does not show correct UI for board access
Post by: Arantor on October 26th, 2012, 07:18 PM

At some point but I haven't figured out how to make the UI not ugly.

Title: Re: Modify group does not show correct UI for board access
Post by: Nao on October 27th, 2012, 10:06 AM

Oh, my... I just realized this means I have to update all boards manually for that new group... >_<

Why should the UI be any different, BTW?!

Title: Re: Modify group does not show correct UI for board access
Post by: Arantor on October 27th, 2012, 01:51 PM

Because when you're doing it from boards, you're doing groups, which is a single dimensional list (though even as it stands it might not always fit properly side by side!)

But when you're doing it from groups, you have to cope with a list that has nested items of arbitrary depth - and still fit in 3 columns per row - and then do the whole thing twice.

Then, remember that I rewrote group access, the boards UI uses the newer stuff, the groups/board access uses the older stuff.

Title: Re: Modify group does not show correct UI for board access
Post by: Arantor on November 5th, 2012, 04:53 AM

This should work, if not be pretty, as of r1769. I gave up trying to have them side by side.

Title: Re: Modify group does not show correct UI for board access
Post by: Arantor on November 13th, 2012, 01:32 AM

Anyone have any trouble with this?

I think it could be made more usable by putting in category headers and making them have selectors too (which would select all the boards in that category) but it seems to work...

Posted: November 13th, 2012, 01:29 AM

Also, thought of the day: this should mean the old member_groups field could be removed. Except it can't because there's some old stuff related to privacy that this field still drives, though I have no idea if any of it works or what it does if it does work.

Title: Re: Modify group does not show correct UI for board access
Post by: Arantor on November 27th, 2012, 04:37 AM

So I added the category selectors, plus the everything selector, which is cool. Remaining question still stands regarding member_groups.

Title: Re: Modify group does not show correct UI for board access
Post by: spoogs on November 27th, 2012, 04:46 AM

Continue to blame the rum... what is the question re member_griups?

Title: Re: Modify group does not show correct UI for board access
Post by: Arantor on November 27th, 2012, 11:17 PM

member_groups is the old method of storing which groups can see a board. In theory it's supposed to be gone, but there's some old legacy code that we've added that uses it to infer something related to topic privacy, and I want to know if 1) it works or not and 2) whether it should be removed so we can remove that from the DB.

Title: Re: Modify group does not show correct UI for board access
Post by: spoogs on November 28th, 2012, 02:09 AM

Ah code stuff... :huh: :hmm: :huh:
I havent gotten to creating users and topics yet.

Title: Re: Modify group does not show correct UI for board access
Post by: Arantor on November 28th, 2012, 02:13 AM

You probably won't even see anything; it's entirely possible the code doesn't do anything any more...

Title: Re: Modify group does not show correct UI for board access
Post by: spoogs on November 28th, 2012, 05:15 AM

Ah so maybe remove it and see if anything breaks :niark: