Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: billy2 on July 5th, 2012, 09:16 AM

Title: Moving text within a post
Post by: billy2 on July 5th, 2012, 09:16 AM

Select a line of text and try to move it to different point within the post. This action brings up the 'add attachment' box rather than drop the text at the new insertion point.
Cheers

Title: Re: Moving text within a post
Post by: Nao on July 5th, 2012, 09:59 AM

Uh, I've actually never done this in my life... Didn't even think it was possible :P
I'd usually use cut & paste for that, and I'd recommend that you'd do it as it's faster, ah ah...

Anyway... Is it worth 'fixing'? Is it even possible to check that a drag is coming from a textarea...? (Heck, from a specific class even...)

Title: Re: Moving text within a post
Post by: billy2 on July 5th, 2012, 10:05 AM

Worth fixing? Not for me Nao.

But for those that type reams of replies ??

 :eheh:

Title: Re: Moving text within a post
Post by: Nao on July 5th, 2012, 11:34 AM

I do that, but I don't move text blocks around...

Title: Re: Moving text within a post
Post by: Norodo on July 5th, 2012, 12:44 PM

Works for me in IE8.

Title: Re: Moving text within a post
Post by: billy2 on July 5th, 2012, 02:30 PM

Quote from Norodo on July 5th, 2012, 12:44 PM

Works for me in IE8.

Sorry?
What is IE ?

 :D

Title: Re: Moving text within a post
Post by: Arantor on July 5th, 2012, 02:57 PM

That's very likely related to the attachments plugin and probably wouldn't occur in base Wedge.

Title: Re: Moving text within a post
Post by: Nao on July 5th, 2012, 03:00 PM

Yup, but OTOH I have plans to make it core... :^^;:

Title: Re: Moving text within a post
Post by: Arantor on July 5th, 2012, 03:14 PM

In which case we'll need to figure out why it's grabbing events it shouldn't be ;)

Title: Re: Moving text within a post
Post by: Nao on July 5th, 2012, 06:53 PM

Drag & drop is a strange beast really...
I noticed that it DOES have a meaning overall, though, it's just that it needs some adapting.

Title: Re: Moving text within a post
Post by: Arantor on October 7th, 2012, 07:57 PM

Still doing it, btw.

Title: Re: Moving text within a post
Post by: Nao on October 19th, 2012, 03:30 PM

Events aren't funny...
I guess the plugin will stay a plugin for now... <sigh>

Title: Re: Moving text within a post
Post by: live627 on November 15th, 2012, 02:54 AM

I think I've fixed it... please review this small patch https://github.com/live627/MultiAttach/commit/59bea5ff6ccc53836e922e92a318b887fae4f4cb

Title: Re: Moving text within a post
Post by: Dragooon on January 2nd, 2013, 04:06 PM

Wouldn't this check be better? (Same thing is used in the drop event)

Code: [Select]

// Make sure we are dragging a file over
if (!e.originalEvent.dataTransfer && !(dt.files || (!$.browser.webkit && e.originalEvent.dataTransfer.types.contains && e.originalEvent.dataTransfer.types.contains('Files'))))
return false;

EDIT: I just realised this thing is months old and I have no clue why this was opened :P