Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Arantor on April 25th, 2012, 11:13 PM

Title: custom.js detection throws errors
Post by: Arantor on April 25th, 2012, 11:13 PM
Quote
file_get_contents(C:\wamp\www\wedge/Themes/default/scripts/custom.js) [<a href='function.file-get-contents'>function.file-get-contents</a>]: failed to open stream: No such file or directory
Since there's nothing in the default SVN for this, it's going to throw errors. Not sure how you want to handle this, really.
Title: Re: custom.js detection throws errors
Post by: Norodo on April 25th, 2012, 11:16 PM
This reminds me, I also seem to get an error about rev.txt, but creating an empty rev.txt fixes this. I'm not sure if this is intended behavior, but it's better to tell early and often than not at all, or? :)
Title: Re: custom.js detection throws errors
Post by: Arantor on April 25th, 2012, 11:18 PM
That was documented a bit back, and since the number of people who have source access is small, we don't tend to worry about explaining it - it's mostly for this site only so that updating the SVN rev in the footer is quick and easy. Me? I just created rev.txt and put 'SVN' in it to avoid any problems, heh.

custom.js is a bit different, though, because it's something that will generally be handled, not a one-off like rev.txt is.
Title: Re: custom.js detection throws errors
Post by: Norodo on April 25th, 2012, 11:23 PM
Oooh. So that's what it is for. Now I get it.
Title: Re: custom.js detection throws errors
Post by: Arantor on April 25th, 2012, 11:27 PM
Yup, here it will simply contain '1561' so it can be easily put into the footer and updated quickly. But it won't be in the mainline code by the time we get to pushing out proper Wedge builds.

I might go away and write a plugin to handle it here, actually.
Title: Re: custom.js detection throws errors
Post by: Nao on April 26th, 2012, 08:16 AM
That's odd. Add_js_file or something has a file_exists before it tries to include a file...?
At least I tried yesterday here and it worked.