Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: live627 on April 22nd, 2012, 09:37 AM

Title: Buffer hook never called
Post by: live627 on April 22nd, 2012, 09:37 AM

Need to add ob_start($call) to obExit in Subs-Template, right under where it loads the files. Then it'll work as expected :)

Title: Re: Buffer hook never called
Post by: Nao on April 22nd, 2012, 03:56 PM

Okay, since Pete remained silent on this, I added the code myself but I'll warn you, I have no knowledge on this part of the code... ;)

Title: Re: Buffer hook never called
Post by: live627 on April 22nd, 2012, 07:10 PM

Ok then I'll double-check it once you commit it. Also, I fixed it so it works on my local copy, and I can post the diff if you'd like.

Title: Re: Buffer hook never called
Post by: Nao on April 22nd, 2012, 07:25 PM

I think itll be good dont worry :P

Title: Re: Buffer hook never called
Post by: live627 on April 24th, 2012, 12:51 AM

Confirmed as fixed in r1557

Title: Re: Buffer hook never called
Post by: Nao on April 24th, 2012, 08:20 AM

Good :) See, I'm not that stupid :lol:

Title: Re: Buffer hook never called
Post by: live627 on April 25th, 2012, 08:10 AM

Oh, I don't doubt your skills. Just that I noticed you were a bit uneasy poking around in code that you never touched. :)

Title: Re: Buffer hook never called
Post by: Arantor on April 25th, 2012, 05:22 PM

That unease is common to both myself and Nao, as it happens, I'm wary of poking at Aeva code for that reason.

I had a feeling it was broken for a while (because WedgeDesk uses/used it and it didn't work) but I never got round to digging into why.

Good to know it's fixed though.

Title: Re: Buffer hook never called
Post by: Nao on April 26th, 2012, 04:47 PM

Yeah, basically, if you happened to quit Wedge, I'd be completely screwed because then I'd have to take over your plugin code which I have little knowledge of, restore the calendar code myself, and end up removing Bad Behavior because I'd be totally lost when it comes to updating its rules... And on and on and on... :^^;:

Title: Re: Buffer hook never called
Post by: Arantor on April 26th, 2012, 07:03 PM

I would have been more open about things if I were going to quit. I just needed to take some time out and find what it was that I loved about working on Wedge, and I have found that again, just slowly.

Certainly that's a sign that more documentation is needed, too.

Title: Re: Buffer hook never called
Post by: godboko71 on April 27th, 2012, 05:12 AM

Glad you found what you liked about coding Wedge Arantor. I had a bad year last year different from your situation however I understand how big change can color your view of everything. Finally working on my projects after almost two years of a holding pattern. Anyway good luck Arantor.

Title: Re: Buffer hook never called
Post by: Nao on April 27th, 2012, 04:33 PM

Quote from Arantor on April 26th, 2012, 07:03 PM

I would have been more open about things if I were going to quit.

Well I'd sorta poked you both on FB and Noisen, to no avail... :^^;:

Title: Re: Buffer hook never called
Post by: Arantor on April 27th, 2012, 04:41 PM

Then you need a bigger stick with a sharper point on it, I didn't notice it :hmm:

Title: Re: Buffer hook never called
Post by: Arantor on April 27th, 2012, 06:13 PM

Since this is fixed, moving it to fixed bugs.