Post by: live627 on March 28th, 2012, 09:48 AM
Post by: billy2 on March 28th, 2012, 09:51 AM
might be an idea to blur out the file path.
Post by: live627 on March 28th, 2012, 09:56 AM
Post by: Arantor on March 28th, 2012, 11:53 AM
For those wondering, that means there's an entry in the log-online table that isn't represented in the session table, which I guess could happen if an entry happens to somehow fall foul of the GC. I wasn't sure that should be possible, but it's also code that's mostly not modified from SMF's (I would have only modified it to cope with wider columns with IPv6 support)
Post by: Nao on March 28th, 2012, 01:02 PM
Problem happened when someone was viewing a gallery item because it postponed an action that needed to be determined earlier.
Anyway.
Post by: Nao on March 28th, 2012, 07:59 PM
Post this in a message:
[media id=65]
It works.
Now post this (add any parameters, any will do):
[media id=65 type=full]
It adds a closing [ /me] automatically. Not even a [ /media], no... a [ /me].
[ /media] is still wrong because it's a self-closing tag anyway, but 'me'...? Something tells me that it's a bug in the way the me tag is implemented.
Gotta go. Anyone got any idea where I could look to spot this bug...? It can be reproduced simply with the Preview button, or with a Quick Edit.
PS: added spaces before closer slashes because Wedge wouldn't allow me to post otherwise... Gotta love this mismatched tag detector though, even if it 'failed' here, normally it would be in its right to complain ;)
Post by: Pandos on March 28th, 2012, 08:16 PM
Bug is a bit different for me :)
When typing:
[media id=65 type=full] it will end up in:
[/s][media id=65 type=full][/color] [/color]
Post by: Arantor on March 28th, 2012, 08:51 PM
Tomorrow I'm out, but Friday I'm going to sit down and start unpicking the current issues with the preparser. The first thing I need to do with both the preparser and the parser are to write test units for them, to validate what correct functionality should be (and then I can automate whether it's behaving as it should)
Post by: Nao on March 28th, 2012, 09:14 PM
The code you posted above...?
Post by: Arantor on March 28th, 2012, 09:22 PM
Post by: Nao on March 28th, 2012, 09:29 PM
Post by: Arantor on March 28th, 2012, 09:37 PM
As I said, Friday, I have nothing on, so I'm going to sit down, write some test cases and start making sense of how both the preparser and main parser work. This has more repercussions than being able to nail down some of the ongoing bugs, but identifying where, potentially, some of the enhancements to performance can be made.
Post by: Pandos on March 28th, 2012, 09:37 PM
[/s][media id=65 type=full][/color][/font][/color] In WYSISYG Mode it looks like this:
[media id=65 type=full][/color]Post by: Pandos on March 28th, 2012, 09:44 PM
Just tested it in IE 9 in WYSIWYG Mode.
After pressing the preview button the following error occurs:
The following error or errors occurred while posting this message:
- The message body was left empty.
With Firefox in QuickReply AND WYSIWYG mode it will have the mentioned /me Tag from you
Post by: Nao on March 28th, 2012, 09:45 PM
Post by: Nao on March 28th, 2012, 09:51 PM
Post by: Nao on March 28th, 2012, 09:55 PM
Hey, added the media code, and although preview showed me the 'me' closer, it wasn't in the final posted code!
Posted: March 28th, 2012, 09:54 PM
 |
Okay, it only shows when doing a quick edit or a preview. Not when posting it directly. And since I fixed preview JS, the post box is no longer updated with the 'fixed' code that we see in preview. Which also means that previewing will fix stuff that posting won't.....??!!
PS: the me closer is added at the very end of the post.
Post by: Nao on March 28th, 2012, 10:54 PM
The bug was mine! In wedit::fixNesting, where I was testing against a list of non-self-closed tags. media is defined as a closed tag, but 'me' isn't, and so it was foolishly looking for [me and found one. I'm upset at me that I forgot to add a \b after the tag list!!
Posted: March 28th, 2012, 10:42 PM
Pandos, can you tell me if it works for you now?
Post by: live627 on May 31st, 2012, 09:06 PM