Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: live627 on March 27th, 2012, 10:10 AM

Title: Missing global in add_plugin_js_file
Post by: live627 on March 27th, 2012, 10:10 AM

In order for add_plugin_js_file() to honor the site gzip and filename obfuscation settings, it needs to pull $settings into scope.

Rev 1452

Title: Re: Missing global in add_plugin_js_file
Post by: Arantor on March 27th, 2012, 12:26 PM

I assume that's still true in 1510 or thereabouts?

Title: Re: Missing global in add_plugin_js_file
Post by: Dragooon on March 27th, 2012, 12:55 PM

Quote from Arantor on March 27th, 2012, 12:26 PM

I assume that's still true in 1510 or thereabouts?

Yup

Title: Re: Missing global in add_plugin_js_file
Post by: Arantor on March 29th, 2012, 01:04 AM

Fixed in r1518.

Title: Re: Missing global in add_plugin_js_file
Post by: Nao on March 29th, 2012, 11:41 AM

Oh, sorry, I forgot to fix this one in one of my commits... Although any plugin-related code is better handled by Pete ;)