Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: MultiformeIngegno on March 23rd, 2012, 01:28 PM

Title: [Fixed] Bug with color & font selectboxes
Post by: MultiformeIngegno on March 23rd, 2012, 01:28 PM

Reply/start a new topic, in the post box write for example "This is a dummy text". Now select "This" and choose the red color. Then select "dummy" and choose red again. Nothing happens.. It works if you choose a different color (same for size).

Seems like the select box doesn't get "reset" when you choose a value.

Title: Re: Bug with color & font selectboxes
Post by: Arantor on March 23rd, 2012, 01:37 PM

This is actually an SMF bug, but to a point, it's correct behaviour too.

WYSIWYG or normal mode?

Title: Re: Bug with color & font selectboxes
Post by: Nao on March 23rd, 2012, 01:40 PM

Ain't got time to check (dozens of bugs at the same time :P), but how is it correct behavior exactly...?
Also, I suspect this would only happen in Wysiwyg?

Title: Re: Bug with color & font selectboxes
Post by: MultiformeIngegno on March 23rd, 2012, 01:45 PM

Not WYSIWYG mode. BBC mode. Well IMO it's not a correct behavior.. If I want something red I want something red. If I push the red option and nothing happens, it just doesn't work. :P

Posted: March 23rd, 2012, 01:42 PM

Quote from Nao on March 23rd, 2012, 01:40 PM

Ain't got time to check (dozens of bugs at the same time :P), but how is it correct behavior exactly...?

I think it should be that when you select a text and then choose a color/font size, the select box should be reset to "Change color/Font Size", so it will work again if I choose the same color/font size for anoher portion of text.

Title: Re: Bug with color & font selectboxes
Post by: Arantor on March 23rd, 2012, 01:48 PM

Quote

but how is it correct behavior exactly...?

In WYSIWYG mode it should change and stay there to indicate the current style. In non WYSIWYG mode it should do as MultiformeIngegno suggests.

Title: Re: Bug with color & font selectboxes
Post by: Nao on March 23rd, 2012, 02:17 PM

Quote from Arantor on March 23rd, 2012, 01:48 PM

Quote

but how is it correct behavior exactly...?

In WYSIWYG mode it should change and stay there to indicate the current style. In non WYSIWYG mode it should do as MultiformeIngegno suggests.

I think that in non-Wys, I should reset the select box to default all the time, since it never updates when moving through the post.

Title: Re: Bug with color & font selectboxes
Post by: Arantor on March 23rd, 2012, 02:20 PM

In non WYS that would be correct behaviour, I guess.

Title: Re: Bug with color & font selectboxes
Post by: Nao on March 23rd, 2012, 02:27 PM

Quote from Arantor on March 23rd, 2012, 02:20 PM

In non WYS that would be correct behaviour, I guess.

I'll be working on that.
Meanwhile, can someone go there(http://wedge.org/do/media/?sa=item;in=11) and rate the picture "0"? Thank you. I'm trying to look into a bug ;)

Title: Re: Bug with color & font selectboxes
Post by: Arantor on March 23rd, 2012, 02:35 PM

Rated.

Title: Re: Bug with color & font selectboxes
Post by: Nao on March 23rd, 2012, 02:47 PM

Quote from Arantor on March 23rd, 2012, 02:35 PM

Rated.

Thanks! Bug fixed.

Title: Re: Bug with color & font selectboxes
Post by: MultiformeIngegno on March 27th, 2012, 03:09 PM

Bump :)

Title: Re: Bug with color & font selectboxes
Post by: Nao on March 27th, 2012, 10:13 PM

It is in my to do list ;)
I'm too ill tonight to do any serious work though. And first I have to finish my 'show groups under user names' rewrite.

Title: Re: Bug with color & font selectboxes
Post by: Arantor on March 27th, 2012, 10:25 PM

You really should take a break for a day or so.

Title: Re: Bug with color & font selectboxes
Post by: Nao on March 27th, 2012, 10:53 PM

Quote from Arantor on March 27th, 2012, 10:25 PM

You really should take a break for a day or so.

I don't know... I'm sure I'll feel better in the morning. I'll just go to bed now.

@Lorenzo> Fixed locally and here! Will commit tomorrow. I only had to add two lines of code :)

Code: [Select]

if (!this.bRichTextEnabled)
sel.attr('selectedIndex', 0).sb();

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Nao on March 27th, 2012, 10:57 PM

Oh, bugger... Looks like the Fixed selectbox system is broken. From what I saw in the quick moderation sbox at least...
I don't get it. I did the fixing specifically for my membergroup select box earlier today. I tested it. It still works. It just seems to fail in that particular situation... And, I suspect, in others as well.

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Arantor on March 27th, 2012, 11:32 PM

Hmm, which specific situation is broken, exactly?

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Nao on March 27th, 2012, 11:39 PM

messageindex -> select a topic -> click the moderation select box. See, the dropdown is actually narrower than most of the options. Also, if you click 'move to', another sbox shows up, where this time the width is okay, but the mouse hover area is very small (try it).

Heck. Just realized that the quick access box also has the problem... :-/

I guess I'll have to revert. But this also means that my fix for detail boxes will have to be rethought. ARGH. I'm through with 'bug fixing that creates more new bugs'...

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Arantor on March 28th, 2012, 12:02 AM

I'm not sure what the best fix for that situation is (but at least now I know what the problem is, I wasn't entirely clear before)

I have to admit, I never considered that a problem, it looked fine to me being how it was.

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Nao on March 28th, 2012, 12:07 AM

You mean, before today?
The problem was with details. There's only ONE select box that used that feature before. Because I wrote the text content for the new select box myself, I added details for it as well -- and I noticed that they were broken, i.e. they were showing in a single line and deforming the entire select box. So I rewrote the code to hide details, then force the dropdown to the current width, and reenable them.

Hmm, maybe I should do that on $dd rather than $items...

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Arantor on March 28th, 2012, 12:12 AM

Sure, before today. All the times I'd seen the quick moderation selectbox, it had sufficient width to contain 'Moderate', but nothing more, and that's fine with me.

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Nao on March 28th, 2012, 12:15 AM

Yeah.
Okay, I fixed it so that the quick access box works okay.
Fixed items are still broken though. I'll have to consider this further tomorrow. I'm an hour past my bed time.

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: MultiformeIngegno on March 28th, 2012, 12:45 AM

Indeed seems fixed here!! :D

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Nao on March 28th, 2012, 12:17 PM

The select box in post pages you mean? ;)

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: MultiformeIngegno on March 28th, 2012, 02:52 PM

Quote from Nao on March 28th, 2012, 12:17 PM

The select box in post pages you mean? ;)

Yes! :)

Title: Re: [Fixed] Bug with color & font selectboxes
Post by: Nao on March 28th, 2012, 04:00 PM

Everything select-box should be fixed by now anyway.

Please, make sure to tell me if you find a select box that doesn't behave like it should!!