Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: TE on March 22nd, 2012, 12:27 PM

Title: IE8: menu broken (with fix)
Post by: TE on March 22nd, 2012, 12:27 PM
the menu icons are slightly overlapping in IE8 (see attachment):
proposed fix:
 .menu > li
 display: inline-block
should be changed to  display: inline
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 22nd, 2012, 12:31 PM
I can assure you that IE9 in IE8 mode (in Windows 7) doesn't have this problem...
The only odd/amusing thing is the extra gradient on the menu bar itself. It shouldn't be there... Probably due to a quick hack to provide the gradient in the first place (since IE6-9 all require some filter:gradient crap...)
Title: Re: IE8: menu broken (with fix)
Post by: TE on March 22nd, 2012, 12:36 PM
My screenshot is native IE8 on a W2k3 Server.. (IE 8 in IE7 mode is fine)
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 22nd, 2012, 12:46 PM
Native IE8 on WinXP (in a VM) does the same as TE's screenshot. Yay for IE9 supporting 'IE8 rendering'.
Title: Re: IE8: menu broken (with fix)
Post by: billy2 on March 22nd, 2012, 12:49 PM
Now I dont feel so stupid :yahoo:
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 22nd, 2012, 12:56 PM
Holy crap... Thank you, Microsoft........ -_-

What do I do now.
And yes, playing with display styles usually fixes this kind of stuff.
However, there's often a reason for deciding to use this or that style. Too many times, I've fixed something to break it somewhere else. (This is why I was so adamant to implement @remove from: because instead of replacing a rule with another, we can now simply ignore it... Simple example: try cancelling hasLayout on older IEs after it was triggered... Good luck!)
A few days ago I was wondering why I wasn't using the gradient filter on the main menu for IE... Oh, well: it works when you first open it... But if you switch to another menu entry, it'll display a transparent background instead. Fun... Maybe it's only in IE9 in compatibility mode... But I won't tempt the devil.

So, what can I say... Thorsten, can you confirm that not only your fix works, but that it doesn't break anything else...?
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 22nd, 2012, 12:57 PM
There's not really much reason to feel stupid... if it's not working, it's not working for a reason. Half the battle here is understanding what that reason is.

If it's because you have a totally alien configuration that's a monstrosity under the hood, we might not be able to do too much about it, but if it's reproducible and causing problems, the bigger the problem (or at least, the bigger the impact it has and the more reproduced it is) the more we can figure out WTF is the problem and fix it.
Quote
Holy crap... Thank you, Microsoft........ -_-
My sentiments exactly. This is why I've always been wary of IETester and ilk.
Quote
A few days ago I was wondering why I wasn't using the gradient filter on the main menu for IE...
Speaking of which, in my Weglas theme, it's actually broken in IE9 where the gradient just doesn't work. The CSS generated is correct (so it's not a WeCSS bug) but IE9 chooses to ignore it. I have no idea why, and I can't be arsed debugging IE9's stupid behaviour.
Title: Re: IE8: menu broken (with fix)
Post by: billy2 on March 22nd, 2012, 01:36 PM
Quote from Arantor on March 22nd, 2012, 12:57 PM
There's not really much reason to feel stupid... if it's not working, it's not working for a reason. Half the battle here is understanding what that reason is.
As far as I was aware - no-one else could see the icon overlap. See my thoughts - no responses.
 :angel:

:edit: Sorry TE, just re-read your 'confirm' response and interpreted correctly this time.
Title: Re: IE8: menu broken (with fix)
Post by: TE on March 22nd, 2012, 04:20 PM
Quote from Nao on March 22nd, 2012, 12:56 PM
So, what can I say... Thorsten, can you confirm that not only your fix works, but that it doesn't break anything else...?
Yep, didn't found anything suspicious after changing the code.

Using IE8 developer tools, I can see only one difference between native IE8 and IE8 in IE7 compabilty mode, that's  the "inline-block" style,
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 23rd, 2012, 11:03 AM
So, err... Does it work now, here?
I applied the menu>li change to index.ie8.css.
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 23rd, 2012, 11:06 AM
Yup, all good in real IE8.
Title: Re: IE8: menu broken (with fix)
Post by: billy2 on March 23rd, 2012, 11:15 AM
:cool:
Title: Re: IE8: menu broken (with fix)
Post by: Farjo on March 23rd, 2012, 06:38 PM
This PC has IE8 and all the dropdown options drop down below "Home". Does that make sense?
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 23rd, 2012, 06:41 PM
Quote from Farjo on March 23rd, 2012, 06:38 PM
This PC has IE8 and all the dropdown options drop down below "Home". Does that make sense?
I can't test.
Are you implying that before today (i.e. before the fix), it worked better than now..?
Title: Re: IE8: menu broken (with fix)
Post by: Farjo on March 23rd, 2012, 06:47 PM
Yes, but I would wait for someone else's confirmation as this PC seems a bit odd - this is the one that occasionally hangs when going into Forum Profile with no pattern. So in hindsight ignore me unless someone else has the same problem.
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 23rd, 2012, 06:54 PM
Are you on xp?
Title: Re: IE8: menu broken (with fix)
Post by: MultiformeIngegno on March 23rd, 2012, 07:10 PM
Farjo, post screenshots if you can. :)
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 23rd, 2012, 07:38 PM
Yes, would be a good idea :P
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 23rd, 2012, 07:51 PM
test
Title: Re: IE8: menu broken (with fix)
Post by: Farjo on March 24th, 2012, 07:49 AM
Hi, sorry not to reply again yesterday - can only sit at that computer while having a break and my time had run out!

Due to the way the shifts have fallen I'm not in until Thursday :eheh: :D :crazy: :yobrother: :bravo: :yahoo: so I'll have a look at the operating system then, however I'm fairly sure there isn't the software (e.g. Paint) to do a print-screen. I could do an 'artist's impression'?
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 24th, 2012, 06:27 PM
Paint comes with Windows itself :/ Failing that, print screen and paste into Word...
Title: Re: IE8: menu broken (with fix)
Post by: Farjo on March 24th, 2012, 06:35 PM
From memory they might have disabled it. They do have Word however the firewall / set-up may not allow me to upload a file - this sounds pessimistic, I'm just 'managing your expectations'.

Did I mention I'm not in until Thursday :eheh:
Title: Re: IE8: menu broken (with fix)
Post by: MultiformeIngegno on March 25th, 2012, 11:21 AM
WTF are you working in the CIA? XD
Title: Re: IE8: menu broken (with fix)
Post by: Farjo on March 25th, 2012, 11:43 AM
If I told you I'd have to kill you :ph34r:

No I work for the NHS, which is the UK's health provider and one of the biggest organisations in the world. They are ultra-cautious when it comes to IT, specifically networking stuff because of the risks of confidentiality and just plain hacking. We're not allowed to install any software or browse Facebook (and probably many other sites). Every time ?shock / flash? is upgraded it takes about 2 months for the PCs to be updated so iPlayer (British TV replay site) doesn't work, which is a pain when on nights.

So like I say the problems on that computer are likely just specific to that computer due to its unique circumstances.
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 25th, 2012, 12:43 PM
Is that why it took months to get Conflickr infected machines cleaned up? ;)
Title: Re: IE8: menu broken (with fix)
Post by: Farjo on March 25th, 2012, 02:22 PM
Ha maybe! "Ooh here's an urgent MS security patch, better take 2 years testing it..."
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 25th, 2012, 02:25 PM
Is that also why there was a modestly high profile piece at the time reporting that Windows 95 was still in use in certain places - even in 2009-10?
Title: Re: IE8: menu broken (with fix)
Post by: Farjo on March 25th, 2012, 02:30 PM
LOL no they're not that bad (although my uni were still using IE6 when I left in 2008).
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 25th, 2012, 04:25 PM
Still, I'm suspicious about all of this...
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 25th, 2012, 04:27 PM
Strangest thing just happened to me. I wrote the post above. Then click Submit. I got redirected to the page with a /new/#new anchor (just "/15/"), and half of the post was missing! I was saying, after this, something along the lines of:
"Maybe Microsoft issued a patch for IE8 that fixes the problem, and a stock XP/2003 doesn't have the fix?"

:edit: It worked, but JS seems to be broken. An issue with the 'subject' variable in the QuickModify object?!
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 25th, 2012, 05:03 PM
Well, there is a specific branch for redirectexit just for IE, which is primarily related to whether the URL has # in it or not...
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 25th, 2012, 05:10 PM
But I'm not in IE..? And my URL was free of anchors...
Title: Re: IE8: menu broken (with fix)
Post by: Arantor on March 25th, 2012, 05:44 PM
You got redirected to a /new/#new page, that's got an anchor in it...?
Title: Re: IE8: menu broken (with fix)
Post by: Nao on March 25th, 2012, 07:15 PM
I don't know. It didn't have an anchor. But I'm making sure that if this happens again, I'll go and check thoroughly.

About the quick edit bug -- it was because it attempted to access the subject area when it isn't shown in Mobile mode. Because we need to be able to edit the subject, I simply added an empty <h5> and it's working again.
Phew. (Well, the styling for that h5 sucks though..)