Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Dismal Shadow on March 21st, 2012, 09:53 PM

Title: [Fixed] Errors when Profile menu is in sidebar
Post by: Dismal Shadow on March 21st, 2012, 09:53 PM
I am getting this error in my profile.

Notice: Undefined index: title in /Themes/default/GenericMenu.template.php on line 37

PS: Cannot find where to edit signature.
Title: Re : Errors when Profile menu is in sidebar
Post by: Arantor on March 21st, 2012, 09:56 PM
Signature permission was not carried through, it should work as expected now.

As for that error, we have seen it, just not sure why it occurs.
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 10:02 PM
You disabled the menu I suppose?
Posted: March 21st, 2012, 10:00 PM

And please guys, again, edit your paths out :P
Title: Re : Errors when Profile menu is in sidebar
Post by: Arantor on March 21st, 2012, 10:03 PM
I did nothing to it in the profile area >_>
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 10:05 PM
Wasn't talking to you ;)

Oh that textarea focus bug is really starting to get on my nerves...
Title: Re : Errors when Profile menu is in sidebar
Post by: Dismal Shadow on March 21st, 2012, 10:13 PM
Quote from Nao on March 21st, 2012, 10:02 PM
You disabled the menu I suppose?
Posted: March 21st, 2012, 10:00 PM

And please guys, again, edit your paths out :P
My bad, I rushed with copy/paste. Too lazy to edit. :P
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 10:17 PM
So?
Title: Re : Errors when Profile menu is in sidebar
Post by: Dismal Shadow on March 21st, 2012, 10:19 PM
Quote from Nao on March 21st, 2012, 10:17 PM
So?
So? What!
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 10:21 PM
Menu?
Title: Re : Errors when Profile menu is in sidebar
Post by: Dismal Shadow on March 21st, 2012, 10:24 PM
Quote from Nao on March 21st, 2012, 10:21 PM
Menu?
Nope, haven't touched anything expect for signature changes.
Title: Re : Errors when Profile menu is in sidebar
Post by: Arantor on March 21st, 2012, 10:32 PM
That's the thing, I can get it as well when viewing profiles, and I have no idea why. It's as though the menu isn't set up properly for some reason, but I never get it locally.
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 10:40 PM
I could create a dummy account. Different Id but same settings. See if I can reproduce.

In the meantime I could also simply analyze the data as saved in the error log. Since I have Wedge log the entire menu array when it meets this problem...
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 11:02 PM
Seriously... select * from {db_prefix}themes where member = Nathan Sparrow

(...)
use_sidebar_menu = 1
(...)

I asked you if you'd disabled the menu, you said no, so I looked elsewhere... :^^;:
Anyway! It seems to always be related to that setting. I'll look into it a bit.
Title: Re : Errors when Profile menu is in sidebar
Post by: Arantor on March 21st, 2012, 11:03 PM
I haven't disabled the menu in profile :P I only disabled it in admin, and really we need to remove that entire code path anyway since we're not using that sidebar menu now.
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 11:22 PM
Yeah I know but apparently many people are using the sidebar menu, interestingly...
It doesn't take (too much) away from the experience, so I'm hesitant in removing it.

Here's a list of people who use the sidebar menu, apart from us (got this by doing a mysql query on the themes table, of course). And I think they all got reset to 'no sidebar menu' earlier today by the bug in Member Options...

Nao (for testing)
billy2
Nathan Sparrow
nhwd

And I believe they all triggered the error messages...
Posted: March 21st, 2012, 11:20 PM

(Sorry, had posted a wrong list where I took all values including 0 :^^;:)

:edit: Aaron, did you enable sidebar menus about 15 minutes ago, then disabled them...?
Title: Re : Errors when Profile menu is in sidebar
Post by: Arantor on March 21st, 2012, 11:32 PM
Quote
Yeah I know but apparently many people are using the sidebar menu, interestingly...
I have plans on redoing the profile area entirely (not entirely dissimilar to the admin panel, FWIW), so ultimately the sidebar menu is going to go and hopefully to be replaced with something better.

I have seen it on other accounts, and I'm hoping that's just a consequence of the buggy member options code rather than people setting them themselves...
Title: Re : Errors when Profile menu is in sidebar
Post by: Dismal Shadow on March 21st, 2012, 11:41 PM
Quote from Nao on March 21st, 2012, 11:02 PM
Seriously... select * from {db_prefix}themes where member = Nathan Sparrow

(...)
use_sidebar_menu = 1
(...)

I asked you if you'd disabled the menu, you said no, so I looked elsewhere... :^^;:
Anyway! It seems to always be related to that setting. I'll look into it a bit.
But I didn't...I left it as it was, the checkbox was checked as is. :huh:
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 11:42 PM
I think you missed my edit, only 3 persons were using it, really, and it's really what causes the bug, because only their names showed up. Unfortunately they haven't come back online so I can't analyze their latest $member_context dump. (Aaron's seem to be perfectly normal, so I'd really like to see these.)

Please don't redo the profile area too deeply... I like most of it ;)
The only need we need to do is give the homepage a proper clean-up, similar to Ultimate Profile.

@Nathan> Uhh...
Can you please try and visit the profile area in sidebar mode?
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 11:44 PM
I see you're on the profile. What is it saying? You should have a custom error message showing up in the menu... Please tell me where ;)
Title: Re : Errors when Profile menu is in sidebar
Post by: Arantor on March 21st, 2012, 11:45 PM
The homepage is the most agreeable part of it, but other than that, it's not actually that nice. The nicest thing I could say about it is that it's functional. It's not particularly aesthetically pleasing, it is just functional.

The goal isn't to keep it functional, it's to make it a place where users might actually want to go. Maybe some aspects of http://custom.simplemachines.org/mods/index.php?mod=698 a touch.

UP's summary is definitely an improvement on the current summary, but I'm also concerned not just with how the user sees the summary, but how they access everything.
Title: Re : Errors when Profile menu is in sidebar
Post by: Dismal Shadow on March 21st, 2012, 11:45 PM
Quote from Nao on March 21st, 2012, 11:44 PM
I see you're on the profile. What is it saying? You should have a custom error message showing up in the menu... Please tell me where ;)
This error?
Quote
PLEASE TELL NAO WHERE THIS ERROR MESSAGE IS SHOWING UP IN THE MENU!!
:lol: :lol:
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 11:48 PM
I'm asking you to tell me where it is showing relative to other items in the menu... :whistle:

@Pete> But I hate that mod... :^^;: You know I'm not pro-big-icons. All I want is a functional menu really... :-/ Anyway. I'm sure you'll find a way!
Title: Re : Errors when Profile menu is in sidebar
Post by: Arantor on March 21st, 2012, 11:49 PM
Quote
But I hate that mod... :^^;: You know I'm not pro-big-icons. All I want is a functional menu really... :-/ Anyway. I'm sure you'll find a way!
I'll keep it toned down compared to that mod :P That's why I haven't touched it yet, I don't know how I want it all to look, I just know it needs going over and overhauling.
Title: Re : Errors when Profile menu is in sidebar
Post by: Dismal Shadow on March 21st, 2012, 11:50 PM
Quote from Nao on March 21st, 2012, 11:48 PM
I'm asking you to tell me where it is showing relative to other items in the menu... :whistle:

@Pete> But I hate that mod... :^^;: You know I'm not pro-big-icons. All I want is a functional menu really... :-/ Anyway. I'm sure you'll find a way!
It seem to be showing in all profile actions.
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 21st, 2012, 11:51 PM
Okay, so I took two minutes, and did the unthinkable -- removed my admin access to Wedge.org!

The error shows up in place of where the Media section should have been!
Done. Just need to look into why it's leaving something there when the Media area is disabled...

Btw, it showed only ONCE for me. ?!
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 22nd, 2012, 12:07 AM
Grmpf... Still can't seem to find anything.

Please Nathan, or anyone with the problem -- post a screenshot of your sidebar area!!
I'm too tired, I'm crashing. If I listened to myself, I'd simply add a @ next to $section['title'] and not bother with this all... :^^;:
Title: Re : Errors when Profile menu is in sidebar
Post by: Aaron on March 22nd, 2012, 12:13 AM
Quote from Nao on March 21st, 2012, 11:22 PM
:edit: Aaron, did you enable sidebar menus about 15 minutes ago, then disabled them...?
Yes, actually, I did. Was curious as to what they looked like. Decided I prefer the dropdown menus, sorry!
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 22nd, 2012, 12:14 AM
Me too.
Still, I'd like a screenshot from someone :P
Just the sidebar area.

Anyway I'm going to bed...
Title: Re : Errors when Profile menu is in sidebar
Post by: live627 on March 22nd, 2012, 12:15 AM
Sorry...? Why sorry?
Title: Re : Errors when Profile menu is in sidebar
Post by: Aaron on March 22nd, 2012, 12:17 AM
Oh, since it was the default on the Noisen-ish Wedge.org, I assumed it was a design experiment of sorts. I appreciate the innovation, hence I felt a bit sorry for not liking it.
Title: Re : Errors when Profile menu is in sidebar
Post by: live627 on March 22nd, 2012, 12:22 AM
Oh... it looked like you were sorry for turning off the sidebar menus :^^;:

(And someone seemed to have turned off QR...)
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 22nd, 2012, 12:25 AM
Quote from Aaron on March 22nd, 2012, 12:17 AM
Oh, since it was the default on the Noisen-ish Wedge.org, I assumed it was a design experiment of sorts. I appreciate the innovation, hence I felt a bit sorry for not liking it.
It wasn't a deliberate design choice. I just couldn't be arsed to find out how to switch it back, ah ah.

Re: QR, I'm not touching the Member Options area again until Pete fixes it. Then we'll be able to reset everyone to proper defaults. Although I thought I'd done it... Anyway, you can change that in your profile.

So, no one's posting a screenshot hey... Okay this time it's bed time for good.
Title: Re : Errors when Profile menu is in sidebar
Post by: live627 on March 22nd, 2012, 12:30 AM
I shot the error!
Title: Re : Errors when Profile menu is in sidebar
Post by: b4pjoe on March 22nd, 2012, 05:42 AM
I get the error in the profile sidebar here.
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 22nd, 2012, 07:06 AM
Just as I thought. AeMe ;)
Title: Re : Errors when Profile menu is in sidebar
Post by: Nao on March 22nd, 2012, 07:46 AM
So, err.. Had a quick look at the dropdown code, and it has a test for $section['id'] at the beginning, that the sidebar code doesn't have.
Meaning it was perfectly logical that it failed... :whistle:

Anyway, code transferred, saved, uploaded, fixed.