Wedge
Public area => Bug reports => The Pub => Archived fixes => Topic started by: Farjo on March 20th, 2012, 09:03 PM
-
Even thought my preferred language is English I am suddenly a "Membre Junior", others are "Membre Senior", and I think Moderator is spelt a bit odd too. I've refreshed and cleared my cache to no avail - is this happening for anyone else?
-
Blame Nao :P
-
IIRC I installed the forum in English... :-/
Perhaps it imported the membergroups from the SMF based version and disabled the setting that prevented them from showing up.
Where is that setting, already...?!
I quickly translated them to English, but I'd rather disable them. We have post counts showing up anyway... I could delete the membergroups but meh...
-
Ah, a "Junior Member" again - cheers Nao :)
-
I still don't remember where to disable these. Maybe I'll have to look at the template code ehh.
-
Should be a theme setting, to hide the post count group if there's an assigned group.
-
Theme setting? Beh...
Why not rely on the theme to comply to the main setting?
-
Because SMF never made it a main setting, and neither have I thus far... ;)
-
Yet, it's your thing ;)
Consider it an official request, Eheh.
Also I suppose it means the search engine doesn't work on theme settings yet?
-
No, it doesn't. It's one of the things that's still not fixed, primarily because I'm still not sure how best to handle the whole situation of themes declaring admin type settings (and thus making it searchable and extensible for those who add separate actual *themes* rather than skins)
-
Ideally, all default theme options should be integrated into Wedge options... I think that theme options should be something that are created by themes themselves. Anything that's in the default theme should be a regular option. Up to themes to determine if they wanna use them.
-
Sounds like a plan to me.
-
I completely agree on that Nao :+1:
-
So, err... What's left?
Logo image URL: ----> default material. If theme doesn't want to use it, they can add a theme option to ask for another logo that fits their needs.
Site slogan: --> default material.
Select default smiley set for this theme: --> default??
Forum width: --> completely default stuff... (heck, I'd be tempted to remove this entirely, and leave it up to custom.css...)
Enable random news line in the forum header: --> default stuff (i.e. if theme doesn't support it, it doesn't have to do anything with it...)
Show statistics on board index: --> ... see below
Show latest member on board index:
Show group key on board index:
Show last modification date on modified posts:
Show view profile button under post:
Show user avatars in message view:
Show personal text in message view:
Show gender images in message view:
Hide post group titles for grouped members:
Okay, seriously... I see absolutely no 'logical' theme option in this. It's all stuff that could be made into either a Member Option or a regular option.
I can understand that one would want to keep at least one option in the Current Theme settings, if only to show themers how to add an option for their theme. Then again... Then again, they can always refer to SMF documentation for that.
(Plus, theme options aren't searchable. Which is why I didn't find the Post group option.)
-
These are all 'default' material with minor exceptions:
Select default smiley set for this theme - this is actually stating that you can set a default set of smileys for each theme should you want to. Though I never knew a site that did. It is the one of the only 'actual' theme options here where it makes a difference but that I wouldn't bother with it.
Forum width: - probably the only option I can justify being a theme option. Yes, you can do that in custom.css but there is a certain convenience to having it in there and be a theme option.
Failing that, can we figure out something that is a genuine theme-specific option so that I can build something for themers to use and that is also searchable?
-
Logo image URL: ----> default material. If theme doesn't want to use it, they can add a theme option to ask for another logo that fits their needs.
Forum width: --> completely default stuff... (heck, I'd be tempted to remove this entirely, and leave it up to custom.css...)
Okay, seriously... I see absolutely no 'logical' theme option in this.
-
Hmm, I disagree on this one... Most of the team, you're likely to switch images per theme anyway, because your logo is just not in the right dimensions or (background) colours.
A lot of themes don't even adhere to this one anyway, especially ones that come with their own logo, because people end up being told to replace the image rather than update this setting - because it's set in the theme's CSS more often than not. Certainly this is true of a bunch of Crip's themes, most of the DzinerStudio themes and some of Bloc's themes.I'm aboard the discard boat, myself.
Well, they're all theme-related options ... If they're not consistent throughout all themes, they have no place in $settings, if you ask me. But I gather you're planning to change all that.