Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Arantor on March 20th, 2012, 11:49 AM

Title: Misalignment with edited post
Post by: Arantor on March 20th, 2012, 11:49 AM
Screenshot says everything. Current Chrome beta branch for me.
Title: Re: Misalignment with edited post
Post by: Nao on March 20th, 2012, 01:22 PM
Ive had the problem on my iPod since day one.
I fixed it locally by setting the signature's clear to both instead of right.
Didn't commit because I wanted to make sure it didn't break layout in other situations or browsers.
I think it may be best to apply a clearfix on the various areas before The signatures.
Anyway!
Title: Re: Misalignment with edited post
Post by: Arantor on March 20th, 2012, 01:24 PM
Yup, I can see the logic of that - though it's the first time I'd seen it, and I had a sudden recollection of a very similar bug in SMF circa 2.0 RC2 :/
Title: Re: Misalignment with edited post
Post by: Pandos on March 20th, 2012, 01:30 PM
By the way...
IMHO it'll be nice if signatures would only showing up once per page / user.
Save bandwith and speed up things.

Title: Re: Misalignment with edited post
Post by: Arantor on March 20th, 2012, 01:34 PM
I'm not sure I want that in the core to be honest but I suspect it won't be too hard to make a plugin for it if that's what people want.

And, it probably won't speed things up, actually. The signature is still only processed once per user, you then have to have some logic to figure out whether to show it or not, which is an extra check per post, doubly so if you're doing it via a plugin because this is a little overhead there, followed up by the fact that it does actually limit what can be gzipped anyway. Needs testing but I doubt it would actually save bandwidth in the long run, and it may even end up costing more bandwidth in some cases.
Title: Re: Misalignment with edited post
Post by: Pandos on March 20th, 2012, 01:40 PM
Agree.
Plugin will be the better way. But appreciated :)
Title: Re: Misalignment with edited post
Post by: Arantor on March 30th, 2012, 04:51 PM
I think the original bug reported here has been done.

Meanwhile I'll do a quick plugin for showing signatures once per page, then admins can install that if they want it. But meanwhile, this thread can go to the archived board.