Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Cataphractus on March 19th, 2012, 10:54 AM

Title: [Bug?] Layout problem with long titles
Post by: Cataphractus on March 19th, 2012, 10:54 AM
Hi,

I don't know if someone already posted this, or if it's not considered a bug; but just in case, I include a screenshot of what happens on my machine in the following thread: (removed spam)

Here's more information:


By the way, nice work!! :cool:
Title: Re: [Bug?] Layout problem with long titles
Post by: Arantor on March 19th, 2012, 10:55 AM
Hmm, yeah, I see what you mean.

I'd noticed the (new) sometimes got cropped on very long titles but this is a bit different. Title definitely needs to learn to wrap :)
Title: Re: [Bug?] Layout problem with long titles
Post by: Arantor on March 19th, 2012, 11:23 AM
Out of interest, what browser are you using?

The title itself is defined as using text-overflow, so that on browsers which support it (like Chrome), it will be auto-truncated and have ... added at the end automatically.
Posted: March 19th, 2012, 11:14 AM

Hmm, I have a feeling that it will require .postheader h5 to also gain a max-width declaration as certain browsers don't apply text-overflow without it (IE, I'm looking at you)
Posted: March 19th, 2012, 11:15 AM

Eh, ignore me, you said it was Chromium.

And that does show it requires a max-width to be defined - because while it's performing the truncation, it's performing it based on a bigger width than it actually has to play with (as you can see, it's truncated - but still overflowing)
Title: Re: [Bug?] Layout problem with long titles
Post by: Nao on March 19th, 2012, 12:15 PM
This is a known issue, one that I haven't got around to fixing yet... Have you noticed the number of minor bugs I've had to fix recently? :P
Plus, every time I fix a bug, I risk introducing another, and this behavior is well known by all programmers. I tend to prefer going ahead and back again when I find a problem. If I do it a few times (back and forth, back and forth...), I'll end up realizing what the problem is and explore another solution.

In this particular case, the issue is due to the fact that Wedge.org originally showed no topic titles beside regular posts, instead only showing them when they had *changed* in the first place. Which makes the HTML shorter and makes it most likely that everyone will notice the title change in the middle of the topic.

Problem is, I never really discussed this, and just left it "the way it is in SMF" for Wedge, not really bothering about title lengths. I want the post header to be as short as possible, so it needs to be kept in a single line. You have no idea, really, no one has any idea how much time I spent on this in the past, before simply moving on to other things, hoping I'd find a better solution later. Technically, I'm using a table display on the buttons, but the behavior is often irregular depending on the browser. This was also one of the reasons I added the Action menu, so that the line would be as short as possible, but with Pete's last-minute addition of the Like feature, I decided to 'let it in', instead of hiding it in the action menu. As a result, well... You can see it, the line is longer than I used to have, and thus my Weaving layout is a bit broken by it.

I'll come around to fixing it... But I have other priorities right now.

Please give me about a week to fix *everything* as best as I can.
Title: Re: [Bug?] Layout problem with long titles
Post by: Arantor on March 19th, 2012, 12:19 PM
Quote
Please give me about a week to fix *everything* as best as I can.
There's no hurry :)

It's more a case of people reporting stuff that's broken, as they see it. You and I both know it'll all get sorted out in the end, it's just going to take a little bit of time to make that all happen - but it will get sorted out. The trick is to not let it get on top of us, which is why I'm looking to organise this board - so that we can assess what's done vs what hasn't been done yet, so that we can focus our time on what needs doing.

Yes, there's a lot to do - but we'll get there :)
Title: Re: [Bug?] Layout problem with long titles
Post by: Nao on March 19th, 2012, 12:40 PM
Quote from Arantor on March 19th, 2012, 12:19 PM
It's more a case of people reporting stuff that's broken, as they see it.
Yeah, but I tend to take it personally... Not consciously, but I know my stress level is akin to what I would feel if I felt bad after locking everyone out of the site for 20 minutes... (Oh, maybe that's because that just happened :P)
Quote
You and I both know it'll all get sorted out in the end, it's just going to take a little bit of time to make that all happen - but it will get sorted out.
I'm confident with that. I'm just a little upset that we had way more bugs out in the open than we originally expected. Heck, I thought Wedge was really bug-free at this point... :^^;:
Turns out that many of the bugs were introduced very recently, with some of the larger rewrites we did in a hurry to prepare for the public version. (I think.)
Quote
The trick is to not let it get on top of us, which is why I'm looking to organise this board - so that we can assess what's done vs what hasn't been done yet, so that we can focus our time on what needs doing.
Should I put this board out of the Pub...? Perhaps?
I know that the pub prefix is really for 'public', as opposed to our private area, but I don't think we're gonna keep everyone to the pub prefix forever..?
Title: Re: [Bug?] Layout problem with long titles
Post by: Arantor on March 19th, 2012, 12:46 PM
Quote
Yeah, but I tend to take it personally... Not consciously, but I know my stress level is akin to what I would feel if I felt bad after locking everyone out of the site for 20 minutes... (Oh, maybe that's because that just happened :P)
These things happen, and on a site that's known to be running alpha software, it's somewhere between allowed and expected. We know full well we've only just deployed Wedge and that we saw many, many things we weren't expecting. That's cool, because it gives us the opportunity to test things in a way we never would have locally, and we've seen bugs emerge out of it that we can fix, so that we get a better result at the end of the day.

To be brutally honest, I actually think it's gone better than I expected it to go, but that just goes to show how strong the work that everyone who's contributed has put in, be it in code, or the importer, or just with their thoughts and suggestions.
Quote
I'm confident with that. I'm just a little upset that we had way more bugs out in the open than we originally expected. Heck, I thought Wedge was really bug-free at this point... :^^;:
Part of me is disappointed, because I thought so too, but the practical part of me (which is larger) was well aware that things hadn't been battle hardened or testing under pressure and that things were going to go wrong. At least they're going wrong here where we can evaluate them properly.
Quote
Should I put this board out of the Pub...? Perhaps?
It's cool where it is for now. We can always reorganise it later.
Quote
I know that the pub prefix is really for 'public', as opposed to our private area, but I don't think we're gonna keep everyone to the pub prefix forever..?
I still sense we're going to have private areas in the future too, if only to discuss things like security matters that shouldn't be discussed publicly, and if I'm really honest, I like having a bit of space where we can open ideas quietly to close friends without broadcasting plans openly. It's not that I don't trust people, it's that I've noticed that stuff in the less public areas has a higher signal:noise ratio and tends to have more specific feedback about changes and suggestions.
Title: Re: [Bug?] Layout problem with long titles
Post by: MultiformeIngegno on March 19th, 2012, 01:27 PM
We could use text-overflow:ellipsis on capable browsers specific css.. what do you think?
Title: Re: [Bug?] Layout problem with long titles
Post by: Arantor on March 19th, 2012, 02:28 PM
I think it's already mentioned that this is exactly what is already done, and why that currently doesn't work perfectly...
Quote from Arantor on March 19th, 2012, 11:23 AM
Out of interest, what browser are you using?

The title itself is defined as using text-overflow, so that on browsers which support it (like Chrome), it will be auto-truncated and have ... added at the end automatically.
Posted: March 19th, 2012, 11:14 AM

Hmm, I have a feeling that it will require .postheader h5 to also gain a max-width declaration
The max-width will fix the other issues outlined, and make it work in some browsers that currently don't accept it.
Title: Re: [Bug?] Layout problem with long titles
Post by: Nao on March 22nd, 2012, 12:37 PM
I'd just like to point out that because the parent container is a display:table, max-width doesn't seem to work on it. And doing max-width on the h5 itself will restrain it to half of the container's width -- and said container isn't 100% of the width, so it's more like to make the final h5 take only 25% of the entire width...
Title: Re: [Bug?] Layout problem with long titles
Post by: Arantor on April 7th, 2012, 09:01 PM
Maybe we should move the Like button out of being next to Quote and Modify and put it at the foot of the post (next to where the 'x, y, and z others like this' message would be)
Title: Re: [Bug?] Layout problem with long titles
Post by: Nao on April 7th, 2012, 09:12 PM
That's a possibility.
I'm still unsure about the per-post layout actually. Especially the footers. The quick edit button feels a bit lonely for sure...
Posted: April 7th, 2012, 09:11 PM

I've also considered moving all action buttons there... But it wouldn't work well in Wireless.