Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: agent47 on March 19th, 2012, 10:44 AM

Title: [Fixed] Displaying incorrect topic views
Post by: agent47 on March 19th, 2012, 10:44 AM
So I was going through the "The Pub" board and I noticed the first two topics that were stickied had 1 view which seems to be impossible because the topic itself had 17 replies. Just thought I'd report this. :)

(http://dl.dropbox.com/u/915297/views-bug.jpg)


:edit: Arantor: Updated title.
:edit: Nao: Fixed img link.
Title: Re: [Bug] Displaying incorrect topic views
Post by: Arantor on March 19th, 2012, 10:46 AM
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
Title: Re: [Bug] Displaying incorrect topic views
Post by: Arantor on March 19th, 2012, 10:58 AM
OK, I've fixed this locally and will push it into the repository on my next commit (since I want to fix a few other things first)
Title: Re: [Bug] Displaying incorrect topic views
Post by: agent47 on March 19th, 2012, 11:00 AM
Quote from Arantor on March 19th, 2012, 10:46 AM
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
I'm glad I could be of some assistance.
Title: Re: [Bug] Displaying incorrect topic views
Post by: Arantor on March 19th, 2012, 11:20 AM
:)

This should be applied when the next rollout of patches occurs, as it's applied as rev 1484.
Title: Re: [Fixed] Displaying incorrect topic views
Post by: Nao on March 19th, 2012, 12:49 PM
How can comma_format() fix that, BTW...?
Title: Re: [Fixed] Displaying incorrect topic views
Post by: Arantor on March 19th, 2012, 12:52 PM
Or, more accurately, the removal of comma_format.

In the template it goes through number_context, to get the right string. What was happening is that it was seeing 1 500 or whatever, recasting it to int and getting 1 out of it. Though, curiously, it was getting the _n string. Anyhow, number_context does its own comma formatting anyway.
Title: Re: [Fixed] Displaying incorrect topic views
Post by: Nao on March 19th, 2012, 12:55 PM
Oh... Right!! I looked the other way around, lol. That makes more sense now.
Title: Re: [Fixed] Displaying incorrect topic views
Post by: Arantor on March 19th, 2012, 12:56 PM
Yeah, took me a minute of staring at it thinking "WTF is wrong with you?" but it does make sense in the end :)