Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: Arantor on March 1st, 2012, 02:01 PM

Title: SMF bug 4755 (registration disabled still shows links to register)
Post by: Arantor on March 1st, 2012, 02:01 PM
There's quite a few places that the link is shown but of course, it's not really an option at that point.
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: spoogs on March 1st, 2012, 02:07 PM
I definitely think the link should not be visible if registration is disabled, at best maybe admin can choose to display a message stating that registration is disabled at this time.
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: Arantor on March 1st, 2012, 02:15 PM
Well, it's not just the menu, there's all sorts of links that don't differentiate between enabled or not. But if there's nowhere to register, it should be fairly obvious (and if you go to action=register it does give you a message about it)

Thing is, I don't know where such a warning would really go otherwise...
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: spoogs on March 1st, 2012, 02:23 PM
Hmmm good point, I just too a  nice long stare with registration disabled and not seeing a good place for such a message either. I just remember being annoyed in the past by having clicked the register button only to find out registration is disabled. It's not really a big deal though I suppose.
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: Arantor on March 1st, 2012, 02:25 PM
But now at least there isn't a registration button, nor is there the 'Please login or register' message (it's now just 'Please login' for registration disabled)
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: spoogs on March 1st, 2012, 02:30 PM
That works, Would it make sense to put such a message on the login page in the event someone assumes clicking login would give them registration options?
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: Arantor on March 1st, 2012, 02:34 PM
The login page just asks them to login (I also took away the 'please register' link from there too) - but I suppose I could add a message telling them that registration is disabled.

What I'm inclined to do is leave it how it is right now (without the extra hint) and see how people feel about it in a practical environment.
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: spoogs on March 1st, 2012, 02:36 PM
 :hmm: makes sense  :cool:
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: Arantor on March 1st, 2012, 03:54 PM
Fixed in Wedge r1414.
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: Arantor on April 9th, 2012, 01:52 PM
I'm happy with this as it is and as such moving to fixed bugs. We can always revisit it later, of course.
Title: Re: SMF bug 4755 (registration disabled still shows links to register)
Post by: Nao on April 10th, 2012, 11:49 AM
Yup, all good!