Wedge

Public area => Features => The Pub => Features: Miscellaneous => Topic started by: Nao on May 7th, 2011, 12:57 PM

Title: SMF bugs
Post by: Nao on May 7th, 2011, 12:57 PM
Feature: SMF bugs
Developer: Nao (main), Arantor
Target: everyone
Status: 100%
Comment:

Fixed a few dozen noticeable bugs that were in SMF2 (and probably still are.) We would have reported them to the SMF team, of course, but apparently they don't care about bug reports, because they never fix them. Believe me, I reported hundreds of them... So these bug fixes will remain undocumented, and unsolved in SMF2. Except for the security issues. We're whimsical, not evil.
Title: Re: SMF bugs
Post by: Dismal Shadow on May 8th, 2011, 12:13 AM
 :lol:

Title: Re: SMF bugs
Post by: Nao on May 8th, 2011, 12:35 AM
A few of the many, many SMF things I fixed... (Just retrieving keyword 'smf' from last month's SVN commits.)

- In the profile area, when issuing a warning, SMF has code whose purpose is to allow moderators to drag and slide to set the target percentage. Needless to say, it doesn't work at all.
- SMF uses time() in a few areas to determine how many seconds were spent on a task. Very accurate!
- SMF does something like this at some point: in_array('m', array('m,cd,cp')). Sounds like a joke.
- SMF shows a floattop class by default in template_button_strip. It doesn't even exist. Most of their calls request floatleft, they should have used that by default...

SMF does this, SMF does that... These are all bugs I found while reading/assessing/auditing the source code. We're not supposed to do that. The SMF team is supposed to. SMF beta testers, at worst.
Title: Re: SMF bugs
Post by: DoctorMalboro on May 9th, 2011, 01:18 AM
Ouch...

I imagine Dragoon in this moment (just joking :P ).
Title: Re: SMF bugs
Post by: Nao on May 9th, 2011, 01:21 AM
They've always give beta badges to anyone, and not cared a bit about whether or not they did anything. When I was made a tester, I worked hard to 'deserve' it. Pff, I wasted my time. Most of my reports went unnoticed anyway... Wasted talent really. The best beta tester for Wedge is me :niark:
Title: Re: SMF bugs
Post by: DoctorMalboro on May 9th, 2011, 01:26 AM
You must love to screw things up enough to be a beta tester :P
Title: Re: SMF bugs
Post by: Nao on May 9th, 2011, 06:46 AM
Hmm yeah.
Title: Re: SMF bugs
Post by: Arantor on May 9th, 2011, 11:03 AM
They have an awful lot of beta testers and I don't see that many reports from most of them... whereas in ye olden times, you actually had to have proven skill to be able to be a beta tester, now it seems like you pretty much just have to ask to get one.

There are a few of the testers who seem capable enough, but even of those who are capable, I don't see much activity.
Title: Re: SMF bugs
Post by: Dismal Shadow on May 9th, 2011, 02:05 PM
Ummm...does putting tags in the site slogan stop some .js file from loading considered a bug?  ;)
Title: Re: SMF bugs
Post by: Nao on May 9th, 2011, 03:22 PM
Can you be more specific?
Title: Re: SMF bugs
Post by: Dragooon on May 9th, 2011, 04:32 PM
Quote from DoctorMalboro on May 9th, 2011, 01:18 AM
Ouch...

I imagine Dragoon in this moment (just joking :P ).
I still don't get it why am I a beta tester. I haven't filed a single report since more than a year, I think they forgot about me.
Title: Re: SMF bugs
Post by: Nao on May 9th, 2011, 05:00 PM
It's not that surprising. Officially, the beta tester group is an 'antechamber' to becoming a teamie. (Either a customizer or a dev -- anything that requires PHP skills.)
However, this is more like an "antechamber to people who're worthy of being in the team but they're not sure about". That's why I stayed there for over two years when some others were in there for a couple of months before becoming devs. (e.g. Nas, who just made half a dozen commits before resigning after months of inactivity.)

In reality, the beta tester group is the SMF team's purgatory. They let you get a taste of development hell, but without the benefits.
Posted: May 9th, 2011, 04:58 PM

Dismal, I don't see anything wrong happening in Wedge with your stuff... Maybe it's the mods' fault or something.
Title: Re: SMF bugs
Post by: Arantor on May 9th, 2011, 06:21 PM
@Dragooon, Nao: Way way back in the mists of time, when it was being discussed about my being a teamie, Karl actually recommended I go into the beta testers area rather than support because while even then (June 09) it was clear I had the skills, they'd noticed I had a bit of a temper because I care about what I do, and that it might not be ideal for me being on the support team...

@Dismal: First up, that's invalid HTML (center is not part of XHTML as far as I remember, and the br tag isn't like that)

Try:
Code: [Select]
<p style="color:white; text-align:center;">Welcome to iApple Cafe.<br />Your Resources on Apple Products, Jailbreaking & Unlocking.</p>
Title: Re: SMF bugs
Post by: Nao on May 9th, 2011, 06:28 PM
Quote from Arantor on May 9th, 2011, 06:21 PM
@Dragooon, Nao: Way way back in the mists of time, when it was being discussed about my being a teamie, Karl actually recommended I go into the beta testers area rather than support because while even then (June 09) it was clear I had the skills, they'd noticed I had a bit of a temper because I care about what I do, and that it might not be ideal for me being on the support team...
It's so sad... That they make sure that their support team is made up of people who don't care about the software... :P
Quote
@Dismal: First up, that's invalid HTML (center is not part of XHTML as far as I remember, and the br tag isn't like that)
Yeah, center and br are invalid in XHTML, but in HTML5 (and thus in Wedge), the non-self-closing br will be fine ;)