Wedge

Public area => The Pub => Features => Topic started by: Arantor on April 25th, 2012, 11:56 PM

Title: Moving topics, you can now send a PM
Post by: Arantor on April 25th, 2012, 11:56 PM
I know it's been a bugbear of mine for a while that users weren't notified when their topics were moved.

Now they are, potentially.
Posted: April 25th, 2012, 11:55 PM

And yes, as per my commit note in r1563, the message is a bit sucky but it makes the point well enough :)
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 25th, 2012, 11:57 PM
This does also make me think that other actions should receive similar notifications, e.g. when a message has been approved from moderation. Thoughts?
Title: Re: Moving topics, you can now send a PM
Post by: Norodo on April 26th, 2012, 12:00 AM
I like it a lot. And there's a ton of things that could and perhaps should receive notifications. I must admit to being a fan of how Facebook does this. I'd like to have notifications when people like my posts, and when they quote them. This should not be PMs though, I'd prefer some kind of "globe" like the one in Facebook. :)

Then again, I can easily do without it.
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 26th, 2012, 12:02 AM
Well, that's a separate subject anyway, and having such a notifications system like in Facebook or XenForo is certainly something we've talked about, but as an interim step, having it implemented as PMs does actually make it easier to migrate to a central notifications system later.

Either way, this is something that does notify the topic starter that their topic has had something done to it, something that I felt had been lacking for a while.
Title: Re: Moving topics, you can now send a PM
Post by: live627 on April 26th, 2012, 12:23 AM
"We would like to let you know that your topic {LINK} has been moved to {BOARD}." - how's that?
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 26th, 2012, 12:26 AM
Well, the problem is that {LINK} is actually a proper link, rather than a bare URL, so that it might look out of place even in a URL.

Perhaps if {LINK} were done in brackets or something so that it still delineates that it's separate? It's in SVN, try different styles to see what works. I did want to intentionally make it slightly less formal, seeing how it's actually sent as a PM from the person rather than from the site.
Title: Re: Moving topics, you can now send a PM
Post by: Farjo on April 26th, 2012, 07:31 AM
That looks very good. And "How long should redirection topic be in place for" is excellent too :)
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 26th, 2012, 09:07 AM
I added the length of time feature months ago heh, based partly on my old mod for SMF, though much more cleanly implemented now there is a subsystem for handling one off tasks in the future.
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 26th, 2012, 04:16 PM
You should post this kind of topic to the blog, Pete :)
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 26th, 2012, 07:07 PM
Eh, so I should, but for me it was such a small thing that I didn't want to blow the trumpet on it. That said, I've been thinking about implementing the notifications system as mentioned here (the Facebook/XenForo one) and that would certainly be a case for promoting it!
Title: Re: Moving topics, you can now send a PM
Post by: godboko71 on April 27th, 2012, 05:09 AM
PM notifications or notification system all good either way. Great job!!
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 27th, 2012, 04:39 PM
Quote from Arantor on April 26th, 2012, 07:07 PM
Eh, so I should, but for me it was such a small thing that I didn't want to blow the trumpet on it. That said, I've been thinking about implementing the notifications system as mentioned here (the Facebook/XenForo one) and that would certainly be a case for promoting it!
Yup, we're gonna do that anyway -- it's just that it's not something that's in my alpha to-do, but certainly in my beta to-do, if you don't do it before...

Right now I'm trying to finish all of my half-done commits, and consider turning albums into album boards, and then add support for profile comments by adding a 'profile' board type... (i.e. Wedge creates a meta-board that contains topics associated to a profile ID. We'd have to store these associations somewhere though, but at least it allows you to automatically be able to search profile comments as well as the rest....)
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 27th, 2012, 04:42 PM
Oh, I've been thinking about it today, even looking at how XenForo handles the user side (I'll do the backend quite differently at least, but the user-side does give me a few things to think about) The big problem is how to keep it manageable given some of the things that need to be handled, but I'm sure I'll figure it out.

*nods* I like where you're going with this, too :)
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 27th, 2012, 04:51 PM
Quote from Arantor on April 27th, 2012, 04:42 PM
*nods* I like where you're going with this, too :)
Well, profile comments were an immediate advantage that floating topics offered... I just figured out that it's still possible to have profile comments even with 'just' floating boards. Although it'll probably require some thinking about the UI... (Should the meta-board be apparent and link to the latest profiles that were commented...? And that's yet another module inside MessageIndex.template.php, obviously...)
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 27th, 2012, 05:05 PM
I don't think the meta board should be apparent, really. It is a meta board, not a physical one. Though you'll have to do some magic in the admin area for it, of course, and make sure that normal board operations exclude that board too, so that you can't readily move topics into it.[1]
 1. Though I could well imagine cases where you'd move topics out of that board and into a normal board, just not the other way around.
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 27th, 2012, 05:23 PM
That's the thing... The more custom code we add to 'ignore' a meta-board like this, the more complicated it gets.
Maybe we should have a flag for boards, like 'meta', which when set will add them automatically to ignored boards... Dunno.
Or just ensure boards in query_see_board are in ('blog', 'board', 'site') or something... Which I don't like.
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 27th, 2012, 05:26 PM
I'd go with the meta implementation, but I'd do it based on just hiding the board generally rather than using it for ignore boards.
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 27th, 2012, 05:30 PM
Well, it's in query_see_board that we'll have to set this up, so it's not going to be a straight 'ignore' which is handled by query_wanna_see_board IIRC...
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 27th, 2012, 05:31 PM
*nods* Something like that, yes, it's pretty complicated :/
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 27th, 2012, 05:35 PM
I guess I'll deal with that.

Hopefully it won't break performance to add another test. Then again, the boards table is never gonna be TOO big... Or could it? Well, with custom boards like blogs and so on... I dunno. Even Noisen has no more than a hundred boards IIRC.
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 27th, 2012, 05:37 PM
I know sites that have hundreds of boards, though it is certainly rare.

But if the test is integrated into the underlying list of boards to exclude before it's turned into SQL, it should be OK.
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 27th, 2012, 05:42 PM
Oh... I see what you mean. Instead of doing a test on the meta field, we'd simply cache the list of meta boards somewhere, and then simply add AND id_board NOT IN (..., ...) to query_see_board..?

Makes more sense, actually. :)
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 27th, 2012, 05:43 PM
Well, mostly. There's already a list of boards built for id_board IN (...) that makes query_see_board. That array of boards itself is actually cached too in Load.php, meaning that you only need to update that array so that it's never allowed in the first place in that list, if that makes sense.
Title: Re: Moving topics, you can now send a PM
Post by: Nao on April 27th, 2012, 05:48 PM
That is good news for floating boards :)
Title: Re: Moving topics, you can now send a PM
Post by: Arantor on April 27th, 2012, 05:59 PM
I actually didn't implement it with floating boards in mind, it was mostly to support the changes to how board access was evaluated.