Wedge

Public area => The Pub => Features => Topic started by: Arantor on March 23rd, 2012, 01:58 AM

Title: Users Online Today
Post by: Arantor on March 23rd, 2012, 01:58 AM
Some of you may have noticed that Users Online Today has sprouted here, on the main wedge.org index, and on the http://wedge.org/do/boards/ board index.

You may be disappointed, or relieved[1] to note that this is NOT a core feature of Wedge. It is in fact a plugin, so we're getting to test plugin functionality here as well.

For more details, please see the following post where I first mentioned it: http://wedge.org/pub/plugins/6929/personal-plugin-showcase-yes-i-m-an-attention-grabbing-git/msg268391/#msg268391

I currently have something like 15 plugins for Wedge in various stages of development, and more will follow in due course (and in that board, really, is where more information will be found)
 1. Depending on your view of such things, of course.
Title: Re: Users Online Today
Post by: Nao on March 23rd, 2012, 07:14 AM
I'll be installing more plugins in the future.
I'm overall very impressed with how clean the plugin system is.
I just need the language loader to be fixed now :P
Ps. Hmm. No draft autosave on this post. It does it sometimes though, on iOS.
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 02:33 PM
Note to Pete: would be nice if you could update this plugin to use <em> instead of <i> at some point... ;) (It's only in one place really!)

Are there any other plugins that we should/could install here btw...? :P
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 02:44 PM
You have access to the repo :P In various stages of working so they might need to be tested offline first.

The repo is in the same place as Wedge's repo except the URL ends in arantor_weplugins instead of arantor_wedge. All users who have access to the main repo have access to the plugins repo.
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 03:04 PM
arantor_weplugins just returns OK with an empty folder... (?)
arantor_plugins asks me for a password, which usually means it doesn't exist.
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 03:05 PM
arantor_weplugins is the right folder, and it has a bunch of folders under it.
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 03:08 PM
Hmm.... And now it's working.
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 03:11 PM
Okay...

rev 34
+ Added French version to OnlineToday plugin. (OnlineToday-Admin.french.php, OnlineToday.french.php)
! Fixed em tag. (OnlineToday.php)

Rollin'! :P
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 03:12 PM
I normally prefix the name of the plugin in the changelog and I'm not nearly as thorough as that (bad practice, I know!) but yay :)

I know the calendar's broken and quite possibly some of the others, haven't looked at them in a while.
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 03:18 PM
Well it's the plugin repo, I'm not going to be thorough all the time I think... :lol:

I'm trying to install the theme selector, but it's not working... I replaced the outdated loadBlock() call with a wetem::add, and still nothing... Uh, dunno if I have time to deal with this right now...
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 05:05 PM
Odds are it's out of date and needs more of an overhaul anyway - think about it, if it's old enough to use loadBlock(), odds are it's out of date elsewhere...
Title: Re: Users Online Today
Post by: live627 on June 15th, 2012, 06:41 PM
Shows for me just fine, error notwithstanding. Mind if I attempt to commit my change?
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 06:45 PM
Go nuts. I gave everyone write permission to the repo.
Title: Re: Users Online Today
Post by: live627 on June 15th, 2012, 06:47 PM
Cool beans :)
Title: Re: Users Online Today
Post by: live627 on June 15th, 2012, 06:59 PM
rev 35

! [Theme Selector] Use the new wetem object to load our block
! [Theme Selector] Variable refresh: $theme -> $th, $settings -> $theme

@ Header alignment is a bit off
@ Selecting a skin does not update the green checkmark in the profile's theme switcher
Title: Re: Users Online Today
Post by: live627 on June 15th, 2012, 07:10 PM
Oh, and it doesn't show in Wine (hey, where's the quick edit button and the action menu? Now I can only quote myself, odd...)
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 07:46 PM
Quote from live627 on June 15th, 2012, 06:41 PM
Shows for me just fine, error notwithstanding. Mind if I attempt to commit my change?
Hey... I *was* working on that!! :lol:

Now I'll have to compare the changes... :^^;:
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 07:49 PM
Oh crap something else I got wrong :lol:
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 08:00 PM
Well, up until today I'd never touched the plugin code anyway... ;)

I made a couple more fixes, but your JS code is complicated...
It's not like I can easily reuse weUrl() (which in addition doesn't support anchors...), and it doesn't support index.php-free URLs like here.

I also moved the code to the sidebar, isn't that what your description mentions...?
And added language files.
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 08:02 PM
I honestly don't remember. It was made a long time ago and even though I gave everyone access I half thought no-one would ever look, heh.
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 08:13 PM
Well... I'm in :P
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 08:16 PM
rev 36
(3 files +2, 3kb)

! Fixed language files to say "including X hidden" instead of "plus X hidden", which was misleading... (OnlineToday.language.php)

! Fixed theme selector. Added language files. Yeah, I named them after skins... We're not going to call it a theme selector, are we...? (ThemeSelector.php, SkinSelector.language.php)
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 08:23 PM
Quote
which was misleading...
Is it? I thought they were counted separately? They should have been...
Quote
We're not going to call it a theme selector, are we...?
Some of the code is derived from a theme selector I wrote for SMF, the name just sort of stuck really.
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 08:34 PM
Ah, yes, now we have a problem... It's "XX including X" for moderators, and "XX plus X" for visitors...
I think it'd be faster to just have a separate counter for all users, instead of a count().
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 08:40 PM
I seem to recall that's why I kept it separate (that's certainly why SMF keeps it separate)
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 09:41 PM
Except it's not separate ;)
Title: Re: Users Online Today
Post by: Arantor on June 15th, 2012, 09:50 PM
Is it not? It should be...

Oh, I don't remember, it was months ago :P
Title: Re: Users Online Today
Post by: Nao on June 15th, 2012, 10:11 PM
You can fix it yourself if you want. I'm not on my computer for now ;)