That's the thing, I actually need to do some right now, mostly because it's how I'm finding bugs in the plugin manager, as well as making sure there are hooks in meaningful places.
Posted: October 13th, 2011, 12:19 AM
Just that right now, after today's fandango, I'm a bit tired before carrying on with the split of the birthday plugin, especially because of the way the email templates are physically handled, and what looks like I'll have to re-engineer the sending process to get around it, which probably means reformatting all the email templates to be conventional language strings.
Speaking of which, the entire way email templates are done is a bit ridiculous, and they can't even be edited in the language editor :/
OK, so I tackled that, and have refined the structure into something usable (and cut the code down in various places)
Right now, it's just a case of taking a machete to the core code to strip it of birthdays stuff, so I can put it in to the plugin. (In other news, there's various ways that things need to be extensible in the calendar that currently aren't. There's no reason, for example, why any arbitrary events shouldn't be able to be added to the calendar. I could envisage it in WD for example for ticket deadlines to be embedded into the calendar.)
But if I don't do things as plugins, I can see them sitting there as red-headed stepchildren, and no-one wants that.
Posted: October 13th, 2011, 02:01 AM
Also, please note that the little thing of leaving a cake image in the user's profile if it's their birthday, that probably should stay core for the time being.
I really don't want to add a hook that can cope with that, that would be inappropriate IMO. (Or we can remove it entirely, not fussed, and have something add to the user's profile underneath or similar. Don't really mind.)
Mind you... when I spent a little while looking last night for a suitable cake image, I found the image used in SMF, and I don't think it's actually compliant with the licence for it... it actually says 'free for desktop use', nothing about distributing it. Though I would hope they asked about it.
Posted: October 13th, 2011, 02:05 AM
Hmm. Do I commit this or do I leave it just removed while I work on things? (Using the power of diff to see the code itself, at least what I haven't just copied over to the new plugin. It does have to do other things that the original code doesn't)
That's a sure sign I haven't had enough tea, if I have to ask such philosophical questions.
Posted: October 13th, 2011, 02:07 AM
Meh, committed. If I broke anything (which I don't think I did) it's a revert away. Meantime, I'll crack on with the plugin.