Wedge

Public area => The Pub => Bug reports => Topic started by: Arantor on March 29th, 2013, 07:36 PM

Title: Rewriting pretty URLs with respect to the moved topic notice
Post by: Arantor on March 29th, 2013, 07:36 PM
So, I was testing a patch with respect to moved topic notices being excluded from RSS feeds (there's no need to syndicate them)

Now, I don't have topic URLs or board URLs prettified, but I do have profile names prettified from other testing I was doing (and set to localhost/wedge/profile/UserName/)

Anyway, so I did the redirect notice, and the body of the post notice has this when you look at it:

Code: [Select]
This topic has been moved to New Board

?topic=34.0

The latter part is a link to the post, and that works correctly, but the body text is being manipulated when it shouldn't be.

The post's physical content is:
Code: [Select]
This topic has been moved to [url=http://localhost/wedge/index.php?board=4.0]New Board[/url]<br><br>[iurl]http://localhost/wedge/index.php?topic=34.0[/iurl]

And that iurl tag is being rewritten to:
Code: [Select]
<a href="/wedge/index.php?topic=34.0" class="bbc_link raw">?topic=34.0</a>

The rewriter is rewriting things not actually in the innards of a tag, but inside the tag's contents.
Title: Re: Rewriting pretty URLs with respect to the moved topic notice
Post by: Nao on March 29th, 2013, 08:25 PM
Uh... Okay... I can't reproduce, maybe I didn't understand how...
Have you tried removing the possible culprit, i.e. domain/protocol removal code from Subs-Template, around lines 535-540..? Try removing the first one, then the second, then both... See if it helps.
Title: Re: Rewriting pretty URLs with respect to the moved topic notice
Post by: Arantor on March 29th, 2013, 08:38 PM
I can't seem to get it to behave even with removing either or both of those.
Title: Re: Rewriting pretty URLs with respect to the moved topic notice
Post by: Nao on March 29th, 2013, 10:49 PM
So... Can you give me a step-by-step guide to reproducing this error here, or on my local install...?

It's the kind of bug that takes an hour to reproduce, and 10 seconds to fix...

:edit: Test.

http://wedge.org/index.php?topic=8023.0
Title: Re: Rewriting pretty URLs with respect to the moved topic notice
Post by: Arantor on March 29th, 2013, 10:59 PM
1. Only have pretty URLs enabled for profiles.

2. Move a topic, leaving a redirection notice.
Title: Re: Rewriting pretty URLs with respect to the moved topic notice
Post by: Nao on April 1st, 2013, 02:44 AM
I don't get why it works for me here and not for you on localhost... :-/
I'm sure it's only linked to iurl tags, but it's a pain to debug bbcode... :whistle:
Title: Re: Rewriting pretty URLs with respect to the moved topic notice
Post by: Arantor on April 1st, 2013, 03:00 AM
Because what you're doing here is not what I'm doing on localhost.

Also, no, it's not just iurl tags. And yes it is the rewriter process.

I turned off all pretty URLs, did a redirect, worked as expected. Change the post to have:
Code: [Select]
[url]http://localhost/wedge/index.php?topic=37.0[/url]

Still worked as expected.

Then I turned pretty URLs on again, but *only* for profiles, and got the same behaviour.

Enabling it for topics is even more fucked up, however. Since for some reason, my given board has a 'url' of 'dummy678704' (no forwardslash) so everything breaks entirely. But even if I have the slash, it's all fecked because I'm not running it on a given domain, but in a folder, i.e. localhost/wedge/

Which says to me that rewrite URLs are currently broken if they only work at a top level folder. I seem to recall mentioning this before too. More than once, if I'm not mistaken. This is why I don't use PURLs, because it's *never* worked for me.