Wedge

Public area => The Pub => Bug reports => Topic started by: Nao on February 11th, 2013, 11:13 PM

Title: Quick editing own posts marks topics unread..?
Post by: Nao on February 11th, 2013, 11:13 PM
What did we change recently with quick edits..?!

Tested this: posted two messages in a row after another message of mine. Topic marked read. Quick edited the older message, ie the one I posted before the last two. Topic marked unread. If I go to the topic, it shows me the last two messages as unread (ie those I posted after that one). If I attempt to quick edit the last post, it marks the topic as unread too (one unread message).

It doesn't make sense to me... This never happened before, AFAIK. And I don't remember seeing any changes to the act of marking topics as read. The only thing I 'fixed', was *unseen items*, i.e. in the gallery..... :-/
Title: Re: Quick editing own posts marks topics unread..?
Post by: Arantor on February 11th, 2013, 11:20 PM
Nothing, that's the point.

If you edit, it should mark that post only as unread :/

There are other side issues with unread stuff - I've seen cases where I've had to read things twice, e.g. the New Revs topic invariably needs reading twice.
Title: Re: Quick editing own posts marks topics unread..?
Post by: Nao on February 11th, 2013, 11:24 PM
Quote from Arantor on February 11th, 2013, 11:20 PM
Nothing, that's the point.

If you edit, it should mark that post only as unread :/
And because an older post is marked as unread, it considers all posts after it as unread. Fair enough. (Although in all logic, it should say "3 new posts", not 2, because it should include the one I edited...)

But I don't understand why I have no memories ever seeing the Edit icon -- and I mean, in the two years we've been using Wedge here! I should remember, shouldn't I..?
I must confess I'm not a big fan of seeing my own posts as new. If at the very least we could have a grace period, e.g. if the post is edited within the time period specified in the settings (the setting that prevents showing 'edited by...' under a certain threshold), then it shouldn't be considered as unread, either...
Wouldn't you agree?
Quote
There are other side issues with unread stuff - I've seen cases where I've had to read things twice, e.g. the New Revs topic invariably needs reading twice.
Really..?! Never got that issue myself...?

Okay... Bed time :(
Title: Re: Quick editing own posts marks topics unread..?
Post by: Arantor on February 11th, 2013, 11:29 PM
The whole this is curiously buggy and I'm not sure why since as you say we haven't changed it lately.

I'll take a look at it tonight, it's marginally more interesting than trying to figure out the warning system ;)
Title: Re: Quick editing own posts marks topics unread..?
Post by: Nao on February 13th, 2013, 12:33 PM
Here's the FUNNIEST thing.

Really.

I did a quick edit on my local install... And it didn't mark the topic as read.
Point made!
Posted: February 12th, 2013, 11:23 AM

So, what do you think Pete..? Did you look into it, or not..?
Title: Re: Quick editing own posts marks topics unread..?
Post by: Arantor on February 13th, 2013, 12:42 PM
I didn't look into it, I faced down my nemesis: the plugin insanity.

There's definitely undesirable behaviour going on. Best question: what do we want it to do, in detail?
Title: Re: Quick editing own posts marks topics unread..?
Post by: Nao on February 13th, 2013, 01:44 PM
Up early? :P
Quote from Arantor on February 13th, 2013, 12:42 PM
I didn't look into it, I faced down my nemesis: the plugin insanity.
Is it really finished...? :)
Hmm, just reminds me I forgot to update the French language files for that... Ah well.
Quote
There's definitely undesirable behaviour going on. Best question: what do we want it to do, in detail?
Personally? I want a quick edit to be visible all right, like it's doing right now... Seems perfectly fine, i.e. if you read a post then come back to the homepage, and the author modified said post, you should be made aware of it.

...........EXCEPT if I'm the one who did the quick edit!
Title: Re: Quick editing own posts marks topics unread..?
Post by: Arantor on February 13th, 2013, 08:13 PM
Quote
Is it really finished...? :)
Hmm, just reminds me I forgot to update the French language files for that... Ah well.
It's not finished finished. It is finished in as far as the user can upload a plugin via the web interface, then enter their FTP details and the plugin is properly unpacked, with all the proper permissions and ownership and not one chmod call was required. I was doing this on a regular shared host last night.

What's left: finishing up the plugin remove code to also use FTP to clean up removing files and plugin repositories stuff.
Quote
Personally? I want a quick edit to be visible all right, like it's doing right now... Seems perfectly fine, i.e. if you read a post then come back to the homepage, and the author modified said post, you should be made aware of it.

...........EXCEPT if I'm the one who did the quick edit!
That is supposed to be how it works. What happens if it isn't the last post in a topic, out of interest?
Title: Re: Quick editing own posts marks topics unread..?
Post by: Nao on February 13th, 2013, 11:21 PM
Looks like that plugin code is going to be updated for a long time... ;)

What happens if I edit a post not being the last one..? Hmm... Well, it works as I'd expect -- it doesn't tell me the topic was updated. I don't know if the same would happen for you though. Did the "Someone Nao might enjoy" topic say '3 new posts' or '1 new post' to you...?
Title: Re: Quick editing own posts marks topics unread..?
Post by: Arantor on February 13th, 2013, 11:43 PM
When I looked at it just now, it said 1 unread. But I had read it up until earlier anyway.

So that's really the big question... should it mark as unread if the topic has since been updated (to let us know there's been a change)?

Also, yes, the plugin code still has a lot to go but honestly, the worst of it is done.
Title: Re: Quick editing own posts marks topics unread..?
Post by: Nao on February 14th, 2013, 11:31 AM
Quote from Arantor on February 13th, 2013, 11:43 PM
When I looked at it just now, it said 1 unread. But I had read it up until earlier anyway.
I thought it'd say 3, i.e. my new quick edit, then your (earlier) answer to my post, then my (unedited) answer.
In a way, this should say 3, but only if the edit is EARLIER than the last post you saw. It probably takes a lot of computation to determine this... I don't know. I haven't looked at that code for a while.
Quote
So that's really the big question... should it mark as unread if the topic has since been updated (to let us know there's been a change)?
As I said above.
And, more importantly, it shouldn't mark the topic as unread if I edited my own post (whatever its position.)
Quote
Also, yes, the plugin code still has a lot to go but honestly, the worst of it is done.
Must feel good... Now... How about we consider releasing a new alpha, then..?
Title: Re: Quick editing own posts marks topics unread..?
Post by: Arantor on February 14th, 2013, 06:06 PM
Quote
I thought it'd say 3, i.e. my new quick edit, then your (earlier) answer to my post, then my (unedited) answer.
In a way, this should say 3, but only if the edit is EARLIER than the last post you saw. It probably takes a lot of computation to determine this... I don't know. I haven't looked at that code for a while.
Therein lies the thing. I'm fairly sure the edit was after I'd read it.

But what I want to know is not what the current behaviour is - that we can determine from the code. What I want to know is what it *should* do, not what it currently *does*. Whatever the current behaviour, it is not correct.
Quote
And, more importantly, it shouldn't mark the topic as unread if I edited my own post (whatever its position.)
Unread for you or unread for everyone?

It shouldn't touch its unread position for you, agreed. But others?
Quote
Must feel good... Now... How about we consider releasing a new alpha, then..?
Sounds like a plan to me.
Title: Re: Quick editing own posts marks topics unread..?
Post by: Nao on February 14th, 2013, 06:20 PM
Quote from Arantor on February 14th, 2013, 06:06 PM
Therein lies the thing. I'm fairly sure the edit was after I'd read it.
Hmm... So, it said '1' but you'd actually already read my last post?
I suppose you don't remember whether it had a 'New' icon next to it, in the topic page...? Or whether it directed you to my edited post or my last one?
Quote
But what I want to know is not what the current behaviour is - that we can determine from the code. What I want to know is what it *should* do, not what it currently *does*. Whatever the current behaviour, it is not correct.
Sure.
As for looking into the code -- not my 'area of expertise' today... I'm already suffering hell for trying to implement mini-menus as a generic template.

To answer the question you're thinking of -- yes, it's actually up and running, has been for about 5 minutes, seems to work, but I'm not extremely happy with the extra overhead... It adds like 1.1KB of code in the script footer area, and about 300 gzipped bytes to the script file. Really not happy with that...
Of course, it also 'removes' 300 bytes from the topic.js file (but what do I care.....), and it implements likes. (Not Ajaxively yet, obviously.) So that's about 110 bytes saved per thought, and as there are 10 thoughts on the homepage, it saves, ahem... 1.1KB of code. Whatever... But the repeated likes compress obviously much better than my mini-menu code.

Well, it's still a mini-menu... Mini-menus are cool.
Quote
Quote
And, more importantly, it shouldn't mark the topic as unread if I edited my own post (whatever its position.)
Unread for you or unread for everyone?
For me, of course.
Quote
It shouldn't touch its unread position for you, agreed. But others?
It should.
Quote
Sounds like a plan to me.
Good...
Hopefully for this weekend, then...