Well, I'm sure you already did 90% of the work through NetBeans, didn't you? ;)
I decided against using NetBeans for that generally, because of the many false positives, such as "undeclared variable" when doing preg_match_all($regex, $string, $my_new_variable)... Yeah, NetBeans, I'm not going to initialize a variable just because you can't fathom that PHP would actually initialize the variable this way, hmm...
Bloc, I don't have access to that topic, even as a friend.
So, I'm guessing they are indeed talking about me in more private sections? Nice. And Arantor was complaining that I had made a fair topic about him in a board that he would still be able to acccess if he hadn't removed himself from it.
Sorry for the OT.
I can't believe SMF's has always been so 'dirty', in comparison...
Its a bit of bashing in that topic yes, sad to say. I think its open for SMF helper group, which I am in..but not sure, maybe I am granted special access or something.
I'm in that group and cannot access that topic.Quote from Bloc on November 18th, 2013, 01:55 PM Its a bit of bashing in that topic yes, sad to say. I think its open for SMF helper group, which I am in..but not sure, maybe I am granted special access or something.
Well, at the time, the main rationale behind having all those unused globals was having them there for mod authors to use, so they wouldn't have to modify the global-line as well — which, in most cases, would cause conflicts.
Now that we're all moving towards hook-based mods, it's certainly time to clean it all up, indeed.
yep, I found most via Netbeans but Spuds, Eman and I spend hundreds of hours for cleaning, documenting and improving the code.. It's not only Netbeans' benefit ;)
Bloc, I don't have access to that topic, even as a friend.
| 1. | I suspect after someone discovered the terrible truth I was able to access it[1]
| ||
| 2. | I can just assume in order to avoid that a competitor would be able to read the development secrets...sorry guys, I may have spoiled you the fun... :( |
Well, it's too bad that Wedge and Elk aren't directly interoperable; I mean, I can't exactly cherry-pick a commit from Elk, etc. Or even from SMF. As such, I really very rarely check out either changelog, and will usually miss any bugfixes.
BTW, I don't know if you read my Wedge changelogs, I suppose you do, but in case you don't, sometimes I'll document bugs that are also in Elk and SMF; or just in SMF, in which case it doesn't concern you. Just search new rev pages for 'smf', and it should narrow them down.
Until a while ago that board was open to friends as well, apparently now
| 1. | One, actually... I committed an unneeded global today. Lulz. I'll fix that in the next commit. |
https://github.com/SimpleMachines/SMF2.1/pull/1151
https://github.com/SimpleMachines/SMF2.1/pull/1157
It took a bit of time. :P
But *finding* them manually? No way... Nobody's a psychic. So, the only tools at his disposals were: (1) any IDE that has that feature (e.g. Eclipse or NetBeans, one of these two, can't remember, provides small icons next to lines with unneeded globals), (2) fix-globals.php...
Technically you *can* find and fix anything manually, IDE and fix-globals are a way to automate the task.
For example, I'm currently scanning the whole code looking for input or selects without a label:
https://github.com/emanuele45/Dialogo/tree/labels
and I'm doing it manually... 1572 input tags.
There are two drawbacks with that method:
1) it takes a shitload of time,
2) every time you start something like that on an SMF-like codebase you end up rewriting small or large parts of the code you encounter (in that branch I already did it twice and I almost just started LOL).