Wedge
Public area => Bug reports => The Pub => Archived fixes => Topic started by: ziycon on April 26th, 2013, 12:08 AM
-
'Thoughts' allow blank entries to be submitted, could open up it up for spam users or users looking to piss off other forum users. Also it's not the norm for an input to take a blank entry unless explicitly told too.
Edit: Attached a screen shot.
-
Good catch ziycon.
-
Sorry! This is due to my recent rewrites, indeed... Something I forgot to document in the changelog: Wedge now allows you to delete a thought by editing it to an empty thought, which some might find more 'natural' than finding a Delete button, and I'm all for simplifying everyone's lives. However, I forgot to add a protection against empty thoughts, when actually sending a new thought... ;)
Fixed here, will be in my next commit too, obviously.
-
But isn't the delete button next to the edit button... which means you are actually making more work for yourself if you edit->remove the text->save vs just pressing the delete button (and any prompt it generates)
-
Let's just imagine you're editing a thought, and then you realize you're better off WITHOUT the thought at all, as it makes you silly... Sometimes, your first reaction will be to just erase the thought and submit. Earlier, it wouldn't work. ;)
-
Does that ever happen?
Consider: what happens in the same scenario with posts? It won't let you do the empty-content aspect, so you have to cancel the edit and delete the post, or edit it to a non-empty content and/or then delete it.
-
I would say try keep base functionality consistent across all site features unless specific features call for specifically for different logic/process.
-
It just sounded natural to me.
Does everyone, basically, want me to disable the ability to delete a thought by emptying it..?
-
I think that's where it's headed. I can't say it would ever feel natural for me to do that. I'm not even sure it'd feel natural to have the same behaviour elsewhere either.
That said... remember that we *do* have that behaviour elsewhere, in profile fields and so on where it *is* (currently) natural to delete something by emptying it out.
I don't know. It's a complex issue.
-
And one of the 'little problems', is that with the major rewrite I did, what Ajax.php excepts from a deletion request is... a thought ID, and an empty thought. If I'm to reject empty thoughts, then I have to do it differently... :-/
Or, maybe I could simply show a confirmation popup when emptying the thought, so that the user knows what it'll do, but the only thing it'll do is add more bytes to the file...