Wedge

Public area => Bug reports => The Pub => Archived fixes => Topic started by: ziycon on April 21st, 2013, 10:14 PM

Title: Moving 'new thought' out of the sidebar?
Post by: ziycon on April 21st, 2013, 10:14 PM
Just wondering if this is expected functionality, when a user has been deleted should the thought not still show the username from whoever posted the thought and just not link to the user's profile?

See attached file.

:edit: by Nao: original topic was called 'Thoughts Deleted Users!?', but since it quickly moved to another discussion... I've taken the liberty of renaming it, I hope you won't mind..!
Title: Re: Thoughts Deleted Users!?
Post by: Nao on April 21st, 2013, 10:50 PM
It's stored by user ID... So at that point, since the member ID can't be associated with a name... It just won't show up.

Hmm, wondering who that account was... Something about styles... Bloc, maybe?

Oh, speaking of thoughts... I've fixed the 'new thought' sidebar problem, but I'm actually considering going one step further, and removing that thought entry box, and moving it to above any thought list, such as the one in the homepage... I've been told, in the past, that it'd make more sense to have it there, but I didn't want to have two places where you could enter a new thought. If I remove the sidebar one, the problem is no longer there...

The sidebar was there mostly because until recently, entering a new public thought would automatically update your personal text. Well, since this is no longer the case (there's a mini-menu entry for that), it doesn't make sense to have it on the side...
Title: Re: Thoughts Deleted Users!?
Post by: agent47 on April 22nd, 2013, 06:20 AM
Quote from Nao
I've fixed the 'new thought' sidebar problem, but I'm actually considering going one step further, and removing that thought entry box, and moving it to above any thought list, such as the one in the homepage... I've been told, in the past, that it'd make more sense to have it there, but I didn't want to have two places where you could enter a new thought. If I remove the sidebar one, the problem is no longer there...
I say go for it. It really does make much more sense to have the thought entry box above/close to the thoughts itself.
Title: Re: Thoughts Deleted Users!?
Post by: Nao on April 23rd, 2013, 03:21 PM
I've renamed the topic... Hopefully, we can get a few opinions on this. (It's so quiet when Pete is absent... :whistle:)[1]

- Remove the 'Thought' box from the sidebar,
- Move it to the 'Thought' area in the homepage,
- No longer allow to directly edit your last thought. You can do it from within the thought area as well... This, per se, would free us from storing said latest thought in the members table.

Are you all okay with that..?
I could also keep the Thought box in the sidebar (remember, it's visible in all pages), and have it show your latest thought, OR your personal text (which AFAIK you can also set separately, from your profile page.)
 1. And I still don't know WHY he's not there... I'm assuming he was upset by one of my thoughts, but (1) I did apologize for telling the truth that I didn't read any of these latest huge topics, and (2) I didn't even have to apologize in the first place, as we've always worked that way, concurrently, on two separate areas of Wedge, and occasionally looked (and be amazed) at each other's work when commits were made...
Title: Re: Moving 'new thought' out of the sidebar?
Post by: agent47 on April 23rd, 2013, 06:04 PM
I highly doubt that's why he's not here, Nao. Arantor isn't that petty. Obviously you know him better than I do but I still think he's busy with something. Did he notify you that he'll be out for a while or did he suddenly just vanish?
Title: Re: Moving 'new thought' out of the sidebar?
Post by: Nao on April 25th, 2013, 02:35 PM
Moved subsequent replies to a new topic.
Also -- topic solved... ;)
Title: Re: Moving 'new thought' out of the sidebar?
Post by: agent47 on April 25th, 2013, 03:22 PM
So yeah, I noticed that you've moved it although might I suggest it needs some styling work now?
Title: Re: Moving 'new thought' out of the sidebar?
Post by: ziycon on April 25th, 2013, 03:31 PM
I much prefer it this way, good call! :)
Title: Re: Moving 'new thought' out of the sidebar?
Post by: Nao on April 25th, 2013, 05:35 PM
Quote from agent47 on April 25th, 2013, 03:22 PM
So yeah, I noticed that you've moved it although might I suggest it needs some styling work now?
What kind of styling..?
Although the 'Click here...' bit was hastily written (I realized a bug when going through the mobile skin, which I fixed on the site, will commit later), I think that the simplicity of its styling doesn't actually call for anything else..?
Or were you talking about something else, maybe...?

I spent a couple of days on getting this rewrite 'right', considering it's a feature I've always used a lot... I actually went through a couple of iterations which I reverted because they didn't feel right and/or too complex, until I went for the simplest possible solution, i.e. showing the bit on top of the other thoughts.
I'm 38. I'm only just learning how to be simple... :lol: