Wedge

Public area => The Pub => Bug reports => Topic started by: live627 on June 9th, 2013, 05:11 AM

Title: Post moderation always shows 10 posts
Post by: live627 on June 9th, 2013, 05:11 AM
Shouldn't it obey the settings?

https://github.com/SimpleMachines/SMF2.1/pull/385/files

(I checked the code and the hardcoded number is indeed still there.)
Title: Re: Post moderation always shows 10 posts
Post by: Arantor on June 9th, 2013, 05:26 AM
I'd argue that if you have a moderation queue of vastly more than 10 items you are doing something wrong in the first place, but that's just me :P

Should it obey the setting? That's a good question. But there are other places where the same is in force, for example reported posts are shown in blocks of 10. Should they also adhere to the limit too? Don't forget there are also performance implications at work here though these should - hopefully - be quite minor ones by comparison.

Right now, I actually don't know if it should be 'fixed' because while I can see the argument, I'm just not quite sure that it is a 'bug'. I'm not even sure it's an oversight. It actually smells like it's by design which naturally makes me wonder if the original devs knew something I don't about the logic behind that.


In other news, I shouldn't really look at such commits, they only make me cry and die a little on the inside. Seriously people, multi-row inserts can be done in all three supported engines. Albeit not in the same conventional fashion in SQLite but it can still be done. And for efficiency's sake, I can't really think of any reason why you wouldn't.[1]
 1. The principle overhead, even... no... especially in SQLite is not network traffic nor CPU, but I/O. Doing a UNION SELECT on a small number of rows with few columns is comparable to the network bandwidth of the INSERT. The CPU of amalgamating the query result first is negligible too, so we're talking about doing one longer pulse of I/O rather than several smaller ones, and since this is a single atomic write it should actually be less demanding!
Title: Re: Post moderation always shows 10 posts
Post by: live627 on June 9th, 2013, 05:53 AM
Quote
reported posts are shown in blocks of 10.
You mean the block in the moderation center main page that somehow vanished?
Title: Re: Post moderation always shows 10 posts
Post by: Arantor on June 9th, 2013, 05:57 AM
Nope, I mean the actual list of reported posts - index.php?action=moderate;area=reports - which has always shown only 10 posts. It's consistent with the rest of the moderation centre in that respect. But we all know the moderation centre is essentially unfinished.


(And the reported posts block is still there, assuming you have permission to view it, which is moderates at least one board or moderate forum. It's there for me. I may have inadvertently broken it when I gutted the moderation centre homepage but it works locally :/)

I dunno. I probably will change it but I don't feel like I have a solid reason other than 'it doesn't comply with another setting elsewhere in the system that isn't actually for that purpose'. In fact, the install-time default is actually 15 messages per page so it definitely doesn't comply there. But I'm not sure it was meant to.