Poll

Should Wedge remove theme support, if it provides an equivalent feature set through skins?

Yes! Focus on what you know best, and let us break it or make it.
17 (73.9%)
No! I'm too familiar with the theme system, I don't want to re-learn it all.
0 (0%)
I don't really care. I never played with themes, or skins for that matter.
1 (4.3%)
I don't know enough about it all to have anything interesting to say.
5 (21.7%)
Total Members Voted: 22

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: One theme to rule them all?
« Reply #30, on November 16th, 2013, 12:35 PM »
You never officially voted, though :P (Or maybe it's just because I don't like seeing the number '13'...)

One of the things that always bothered me is the difficulty to grasp differences between $theme and $options. (In SMF, I think that's $modSettings and $theme, respectively. Which is even sillier.)
I believe they should be merged together. I simply thought that it'd make more sense to get rid of $options (or rename $settings to $options because it's shorter, but it'd take time to get used to...), and merge them into settings at user load time.

I haven't started work on this yet though, mostly because I want to get it right. And if I ever miss the December 2013 window for first public alpha release, nobody will die for it. It'll just be released a month or two later, and with less predictable hassle for future users.
Re: One theme to rule them all?
« Reply #31, on January 2nd, 2014, 05:50 PM »
And that's it. I just updated wedge.org (took 45 minutes, because I had to convert everything, rather than just reinstall from scratch, as I would have done on a regular 'test' forum...), and it's looking good now. Well, it's the same as one hour ago, but you get what I mean.

The main difference is that the forum you're seeing now, no longer relies on themes.

I'm a bit disappointed with performance, as it's pretty much the same as before I removed themes. But Wedge is already as fast as it can be, so I'm not surprised a 5% increase (or anything like that) isn't noticeable. I did my tests on page 157 of the New Revs topic, and the page was consistently loading between 0.06s and 0.14s. If I disable the file cache and rely only on APC, I get between 0.06s and 1.02s, so... Well, that APC really is some fine piece of crap! I need to focus on committing my new version of the cache system.

Please post here if you notice any issue regarding the site update! Thanks.

Drunken Clam

  • Drool, drool, drool....!
  • Posts: 153
Re: One theme to rule them all?
« Reply #32, on January 2nd, 2014, 07:07 PM »Last edited on January 2nd, 2014, 08:01 PM by Nao
Ah, found a couple of problems...

Screenshot 1 is viewing 'unread'

Screenshot 2 is replying to this thread.

HTH :wow:

(Chrome 32.0.1700.68 beta-m)
Re: One theme to rule them all?
« Reply #33, on January 2nd, 2014, 07:16 PM »
Hmmm,

Screenshot 1 has gone away on clearing my cache, screenshot 2 remains however. :unsure:

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: One theme to rule them all?
« Reply #34, on January 2nd, 2014, 08:05 PM »
Thanks, I'll look into these. They show up in my error log anyway, but it's good to know it's still buggy.

Well, the second one isn't an error, it's actually some debug code I forgot to remove. I've reuploaded the slower, APC-based version so I don't have to revert my current cache tests. I'm trying to 'break' the $_SESSION-based caching system, but unfortunately it's not very encouraging, because the performance is pretty much the same as the file-based cache (even though it only stores one entry in the database), and I don't know if it's worth the huge hassle. I know that saving bits of processing power, little by little, is what brought Wedge to be so fast, but OTOH the fastest performance improvement I ever got with Wedge is by disabling the APC cache, so, whatever...

Drunken Clam

  • Drool, drool, drool....!
  • Posts: 153

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: One theme to rule them all?
« Reply #36, on January 3rd, 2014, 08:45 PM »
I actually fixed that an hour ago. How timely! But I haven't committed or uploaded it yet, because it needs some further testing (I replaced a variable across the codebase), and right now I'm busy watching TV. What, TV doesn't matter? Not when it's Community and Sherlock! :P

Wanchope

  • Posts: 232
Re: One theme to rule them all?
« Reply #37, on January 4th, 2014, 05:55 AM »
Reading the forum posts with mobile phone, user avatar not showing in the display. php (or whatever).

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: One theme to rule them all?
« Reply #38, on January 4th, 2014, 09:45 AM »
Didn't I already fix that one last night..? The avatars are showing up for me, at least. Cache issue? Try to reload the page.
Oh well, no worries, I've moved the folder around again; this should ensure that your cache is not read. Plus, it saves two bytes of bandwidth per avatar load. (I'm that sick.)

Wanchope

  • Posts: 232

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: One theme to rule them all?
« Reply #40, on January 4th, 2014, 08:13 PM »
Yes, although there's always going to be something broken around, I'll do my best to fix when that happens, of course.

:edit: Okay, post buttons are still broken, it's probably not in the codebase but rather a path I forgot to update, I'll look into it.
Re: One theme to rule them all?
« Reply #41, on January 5th, 2014, 11:46 AM »
Asking for opinions on the best between these two generic folder structures...

/wedge
  /assets
  /attachments
  /cache
  /css
  /js
  /languages
<-- .english.php files
  /media
  /Plugins
  /scripts
<-- .js files
  /skins
<-- .css files
  /Sources
<-- .php files
  /Templates
<-- .template.php files

Or...

/wedge
  /assets
  /attachments
  /cache
  /css
  /js
  /media
  /Plugins
  /src
<-- all source .php, .template.php, .js and .css files
    /languages
    /scripts
    /skins
    /templates


Basically, anything that powers Wedge, but can also get cached or modified, would be in src. It's just that, I thought there were already enough folders in the root as it were... I figured, if you're uploading by FTP, you can have a shortcut to /src, then you can easily update whatever files are the most likely to have been modified. But, of course, it can also be argued that 'languages', 'scripts' and 'skins' don't have any semantic reason to be in 'src', things like that.

FWIW, currently, the folder structure is:

/wedge
  /assets
  /attachments
  /cache
  /css
  /js
  /media
  /Plugins
  /Sources
  /Themes
<-- all .template.php files are in this folder
    /languages
    /scripts
    /skins


PS: if you want to discuss the capitalization, feel free to do it, too. Right now, it's still something that's in the air. It doesn't make sense to me, or to anyone else.

Aaron Smith

  • The mini menus on Thoughts... Damn Sexy!
  • Posts: 39
Re: One theme to rule them all?
« Reply #42, on January 5th, 2014, 12:18 PM »
I prefer the second setup. It makes sense to have those directories under the /src directory. As far as capitalization I prefer things to be consistent. So either everything lower case or everything proper case(first letter capitalized).

Wanchope

  • Posts: 232
Re: One theme to rule them all?
« Reply #43, on January 5th, 2014, 03:44 PM »
The first folder structure is more friendly. All lower case, please.
I think it will be better to split this thread (add a poll?)

MultiformeIngegno

  • Posts: 1,337