Poll

Recycle bin or inline moderation?

recycle
22 (50%)
inline
12 (27.3%)
Don't care
7 (15.9%)
Don't know
3 (6.8%)
Total Members Voted: 42

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« Reply #90, on February 17th, 2011, 10:28 PM »
Quote
So... Do we agree on getting rid of the recycle bin? Or do you want to keep it (just not with a recycle board added by default...)
I think we do, as a structure. The key thing for me is that we create the situation where, by default, a post being deleted is not permanent. It *can* be made to be default that a post being deleted is permanent, but that the default is a soft delete.
Quote
Permdel: do you mean alongside the regular Delete button, or as replacement for the Delete button when the post is in Deleted mode? Second one, right?
Replacement for the delete button when the post is deleted, or if the admin so desires, replacing it normally. But the default should be to replace it in deleted mode.
Quote
Did you have a look at my WarmWine BTW?
Not yet, I felt like hell and went back to bed, only just got back up, just in time to do chores.
Posted: February 17th, 2011, 05:18 PM

Also, how do we display a deleted topic?
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« Reply #91, on February 17th, 2011, 11:38 PM »
Quote from Arantor on February 17th, 2011, 10:28 PM
I think we do, as a structure. The key thing for me is that we create the situation where, by default, a post being deleted is not permanent. It *can* be made to be default that a post being deleted is permanent, but that the default is a soft delete.
Sure.
However, if soft deletes are default, then I think it should be associated with enabling post moderation -- so it should be enabled by default. IIRC if post moderation (core features) is disabled, SMF/Wedge don't check for the is_approved bit. We'd need to check it everytime because we'll probably use is_approved to store the state (unapproved/approved/deleted).
Okay I should probably check the actual code before I say things like that ahah...
Quote
Replacement for the delete button when the post is deleted, or if the admin so desires, replacing it normally. But the default should be to replace it in deleted mode.
We're in agreement here.
Quote
Not yet, I felt like hell and went back to bed, only just got back up, just in time to do chores.
Still not? ;)

In the meantime I've converted all of the stylings to the simple css syntax. Phew! It was a bit nightmarish... It's not perfect and it's untested, so I'll probably wait until tomorrow to commit, but at least it's done. Means I can really move Warm to be the default...
Quote
Also, how do we display a deleted topic?
Oh, that'll probably be an interesting thing to implement, ahah...
Either we don't show anything, and do it only in the admin area, or we show the deleted topic link only for admins but in the message index itself, or we show the 'deleted by...' mention for everyone. Red background probably ain't too good when you just say "deleted" without linking, btw (same for showing a "message deleted" mention inside topics for non-admins. Should be a bit grayish or something I guess...)
.approvebg, things like that... There are different background colors available for the message index. We just need to add a new one for deleted topics.
Topics also have a is_approved flag IIRC. (Or they use the one for the very first post. Either way, it shouldn't be a performance issue to have this.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« Reply #92, on February 17th, 2011, 11:51 PM »
Quote
We'd need to check it everytime because we'll probably use is_approved to store the state (unapproved/approved/deleted).
There are four states to be stored, not three: approved/not deleted, approved/deleted, not approved/not deleted, not approved/deleted.

I'd hate to restore something that was pending moderation and find it was auto approved in the process.

I'm seriously debating making post moderation permanently enabled rather than optional - I hear the concerns over performance but I have a feeling we can do something about that too. If it's handling deletion, it must be, basically.
Quote
Still not?
Had TV time, whereupon I was iPad-bound ;)
Quote
Topics also have a is_approved flag IIRC. (Or they use the one for the very first post. Either way, it shouldn't be a performance issue to have this.)
They do. And they display a (!) on the front page alongside the different colour. I don't really have a problem with doing something similar for deleted topics - just wanted to be clear that's what we were doing.


And then fix up the hellspawn that is the moderation center (or should we gut that and do something better?)

Adonis

  • Skyrim Arch-mage and errand runner
  • Posts: 80
Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« Reply #93, on February 18th, 2011, 12:17 AM »
I think all (and just) the deleted stuff should appear in it's own 'ghost topic' that opens in a new tab/window.

A small icon at the top of the thread to show how much is/isn't there.

<shrug>

I'm usually just a 'user' on a forum, so the less cluttered the better.

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« Reply #96, on March 12th, 2011, 07:23 PM »
Quote from Arantor on March 12th, 2011, 07:02 PM
Well, there is favour for the inline-deleted style.
I had that feeling, too... And I had the feeling that since it's 'my side', I'm going to have to do the implementation myself eheh... :P
Quote
My principle concern was the UI for it (though permissions are tricky, too) in which case if we mock up how the UI looks we can get a sense of whether that needs fixing or not.
I'd rather have as little extra UI as possible...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« Reply #97, on March 12th, 2011, 07:24 PM »
Keeping the UI lean is important, sure. And this particular one is something that bothered me quite significantly to do something about. I think it's worth mocking up in a test page before full on implementation and seeing if it feels 'right' or not.

Dismal Shadow

  • Madman in a Box
  • Me: Who is Arantor? Cleverbot: It stands for time and relative dimensions in space.
  • Posts: 1,185
“I will stand on my ground as an atheist until your god shows up...If my irreligious bothers you much, and if you think everything I do is heresy to your god I don't care. Heresy is for those who believe, I don't. So, it isn't heresy at all!


   Jack in, Wedge,
   EXECUTE!

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Recycling board by default
« Reply #99, on April 7th, 2011, 02:21 PM »
This topic died right in the middle of the discussion so I think it's a good candidate for moving it to the pub (if only for a wider audience for the poll.)
Plus, I re-read everything and there are no private discussions.

spoogs

  • Posts: 417
Re: Recycling board by default
« Reply #100, on April 7th, 2011, 03:31 PM »
I'm in favor of the recycle bin on by default. As a former Vb user I never liked seeing the deleted posts in topic, seems like waste of space to me. I mean hell they were deleted for a reason and it's up to the post author and the moderation staff to debate if it should be restored or not. If I'm set to see 20 posts per page I'd rather not have 5 of them being post deleted notices.

@Arantor - How about using a similar setup as you did with displaying SD as a board, whereas the recycle bin would be action=moderate;sa=recycled and just present it as a board, follow up with access/permission controls. Also I agree with a previous post about multiple recycle bins, per category or specify for each bin which boards' deleted posts end up there.
Stick a fork in it SMF

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #101, on April 7th, 2011, 03:34 PM »
Interesting idea, I hadn't actually thought of doing it like that. That works for me, on all the levels.

The way I did it in SD was hackish but it has given me food for thought in other directions, actually.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Recycling board by default
« Reply #102, on April 7th, 2011, 07:34 PM »
Go ahead and vote, guys!
Although at this point, it looks like the community is split, which generally means: no action, everything stays the same. And doesn't fix my existential problem with a recycle board set to id 1 or 2. :P

spoogs

  • Posts: 417
Re: Recycling board by default
« Reply #103, on April 7th, 2011, 07:38 PM »
Arantor can correct me on this but I dont think board id's come into play with the way its done in SD, it basically a faked up redirect board.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #104, on April 7th, 2011, 07:59 PM »
That's exactly what SD does, it injects a fake board (and category if needed) with fake id and links back to the help desk instead of to a "board". No board is consumed, no board=x in the URL.

As far as giving me ideas, it makes me think about being able to indicate a type of board to the template.