New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2745, on January 21st, 2015, 06:50 PM »
[Commit revision efa980e]
Author: Nao
Date: Wed, 21 Jan 2015 10:08:55 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • say() doesn't need to be a modal dialog, it's just a regular information box requiring no user choice... (script.js)
[Commit revision 35c89bc]
Author: Nao
Date: Wed, 21 Jan 2015 10:18:48 +0100
Stats: 1 file changed; +4 (insertions), -3 (deletions)
  • Fixed some rare situations where popups didn't have proper dimensions. (script.js)
  • Just for the record... This bit was written years ago (seriously), but I always postponed its commit because I wasn't sure it worked. Well, since I'm doing most of my tests on 'clean' copies, I'd never get to test it anyway, so I'm committing, and I can always revert it later.
[Commit revision 7b5a702]
Author: Nao
Date: Wed, 21 Jan 2015 15:14:43 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Strictness is cool. No, it isn't. (Aeva-Gallery2.php)
[Commit revision fe4d11c]
Author: Nao
Date: Wed, 21 Jan 2015 15:16:17 +0100
Stats: 1 file changed; +0 (insertion), -3 (deletions)
  • Got bored with a visual tweak... Suggestions welcome. (Wilde/extra.css)
[Commit revision d686f19]
Author: Nao
Date: Wed, 21 Jan 2015 15:28:59 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Apparently, Firefox 37 doesn't like buttons with reduced paddings and overrides the font color with white (?!) after animations. Seriously, what's with that? (index.css)
[Commit revision d555ceb]
Author: Nao
Date: Wed, 21 Jan 2015 18:50:06 +0100
Stats: 1 file changed; +54 (insertions), -45 (deletions)
  • And now for a severe rewrite of the reqWin() function. (script.js)
  •  > is_modal replaces modal_type, and is easier to understand.
  •  > existing button labels are kept, instead of replaced with we_cancel/we_ok values.
  •  > the function now accepts any type of contents, ultimately it will always show a draggable header, then a section containing the main data, then a footer with at least one button. If necessary, it will create them on the fly.
  • In need of more work: (1) testing form submissions from within a popup (does the location trick interfere with them?), (2) ensuring other events don't interfere with the popup's, such as Zoomedia's.
Re: New revs
« Reply #2746, on January 21st, 2015, 06:51 PM »
[Commit revision 915e2fa]
Author: Nao
Date: Wed, 21 Jan 2015 18:51:31 +0100
Stats: 1 file changed; +8 (insertions), -16 (deletions)
  • The help popup is now literally just ONE line! Could even generate it from Help.php, rather than the template... Hmm. (GenericPopup.template.php)
Re: New revs
« Reply #2747, on January 21st, 2015, 08:41 PM »
[Commit revision 2878033]
Author: Nao
Date: Wed, 21 Jan 2015 20:13:15 +0100
Stats: 2 files changed; +66 (insertions), -76 (deletions)
  • Modified media pages to use ask() popups instead of Zoomedia. Works much, much better (everything had been broken for years!), although some items still don't seem to work properly. (Aeva-Gallery.php, Media.template.php)
  • Note: the HTML type can't be removed from Zoomedia, because it's still used to show AeMe embeds as gallery items.
[Commit revision da84ae5]
Author: Nao
Date: Wed, 21 Jan 2015 20:41:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Woops! That's why alerts weren't working today... (script.js)
Re: New revs
« Reply #2748, on January 21st, 2015, 09:00 PM »
[Commit revision cadbe86]
Author: Nao
Date: Wed, 21 Jan 2015 20:59:55 +0100
Stats: 1 file changed; +4 (insertions), -2 (deletions)
  • AeMe doesn't seem to properly update its settings cache when changing them. Seriously, how has this been working for the last 5 years and I'm only noticing something now..?! (Subs-Media.php)
Re: New revs
« Reply #2749, on January 21st, 2015, 11:50 PM »
[Commit revision 4e7563c]
Author: Nao
Date: Wed, 21 Jan 2015 23:50:02 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Give priority to popup clicks as opposed to the Zoomedia click catcher, which has a z-index of 12. (index.css)
Re: New revs
« Reply #2750, on January 22nd, 2015, 06:46 PM »
[Commit revision 0f3cd29]
Author: Nao
Date: Thu, 22 Jan 2015 18:42:24 +0100
Stats: 1 file changed; +5 (insertions), -13 (deletions)
  • Fixed an annoying bug causing select boxes with optgroup tags to fail selecting items properly. (sbox.js)
  • If you want me to get technical, well, I spent an entire day on this annoying bug, as I was convinced it came from something else... Until I decided to try with the penultimate committed version. Uh. It's a VERY good thing that I had a comment in my source code indicating a list of slower alternative solutions for a specific test in the sbox code... Because the new version of the test was broken long ago when I added support for custom scrollbars. The bug wasn't very visible, because that line is only for some cosmetic improvement, but it was still there, just made obvious by my fix from last week or so. Don't ask. So I'm taking the fastest remaining solution, which shouldn't be too slow for regular use anyway. Unless you have a LOT of items in your select box... And the biggest one I can think of (timezone selector) is still lightning fast for me. If you're having any problems, please tell me, and I'll just remove the test altogether.
[Commit revision 7a94d2f]
Author: Nao
Date: Thu, 22 Jan 2015 18:46:25 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Minor tweak to Wine sidebar position. (Wine/extra.css)
Re: New revs
« Reply #2751, on January 26th, 2015, 01:48 PM »
[Commit revision 8681fee]
Author: Nao
Date: Fri, 23 Jan 2015 10:12:11 +0100
Stats: 1 file changed; +3 (insertions), -0 (deletion)
  • Minor tweak in Wine (for media gallery). (Wine/extra.css)
[Commit revision fb25a63]
Author: Nao
Date: Sat, 24 Jan 2015 12:21:01 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Saving a CPU cycle... Don't mind me. (Subs-Cache.php)
[Commit revision 7681f71]
Author: Nao
Date: Sun, 25 Jan 2015 17:14:24 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Commenazi. I'm not even sure it's better English... (install/install.php)
[Commit revision 543742a]
Author: Nao
Date: Sun, 25 Jan 2015 17:20:31 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • Attempting to fix the link to the installer deletion process. Dunno if it'll work, honestly... But I'm hoping so? (Install.english.php)
[Commit revision 4be39a9]
Author: Nao
Date: Mon, 26 Jan 2015 13:48:14 +0100
Stats: 1 file changed; +16 (insertions), -16 (deletions)
  • Topic merging didn't work... Thanks, Kian! (Merge.php)
Re: New revs
« Reply #2752, on February 3rd, 2015, 11:12 AM »
[Commit revision 80dd2d3]
Author: Nao
Date: Mon, 02 Feb 2015 22:52:44 +0100
Stats: 1 file changed; +2 (insertions), -1 (deletion)
  • Due to multiple errors on my local install, I'm attempting to make the PHP cache process more restrictive. Will update if errors keep coming. (Subs-CachePHP.php)
[Commit revision 207f7e8]
Author: Nao
Date: Mon, 02 Feb 2015 23:37:02 +0100
Stats: 1 file changed; +11 (insertions), -2 (deletions)
  • I thought I'd gotten rid of twin separators in menus long ago (i.e. a separator, then a disabled section, then another separator), maybe it was in my code for AeMe's menus, I don't know. Fixing this once and for all... Should be fast enough, too. (GenericMenu.template.php)
[Commit revision 0d03042]
Author: Nao
Date: Tue, 03 Feb 2015 11:12:18 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • Fixing some 404 errors on contact lists. (Profile.template.php)
  • Hopefully fixing situations where you couldn't edit signatures. (Profile.template.php)
Re: New revs
« Reply #2753, on February 3rd, 2015, 01:14 PM »
[Commit revision 88287e9]
Author: Nao
Date: Tue, 03 Feb 2015 13:14:06 +0100
Stats: 1 file changed; +11 (insertions), -19 (deletions)
  • Simplifying credits (we don't really need nicknames for everyone, do we..? It's just convenience, ask on the forum if you need to know who's who or blame the file), and preparing for the removal of JW Player code. I really, REALLY wanted to see that one copyright gone... It was Wedge's last 'incompatible' license. (contributors.txt)
  • Current local (uncommitted) code is 100% JW Player-free. Will commit once I've fixed the playlist system.
Re: New revs
« Reply #2754, on February 5th, 2015, 12:22 AM »
[Commit revision 83975d2]
Author: Nao
Date: Thu, 05 Feb 2015 00:22:20 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Broke playlist additions with latest media gallery overhaul... :( (Media.template.php)
Re: New revs
« Reply #2755, on February 6th, 2015, 06:27 PM »
[Commit revision 29fb45d]
Author: Nao
Date: Thu, 05 Feb 2015 10:33:06 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)
  • Playlist popup should probably have a 'close' button... I'm putting it right next to the submit button, trying to figure out if it's better than having them at opposite sides... Opinions? (Media.template.php)
[Commit revision bd994ca]
Author: Nao
Date: Thu, 05 Feb 2015 18:34:11 +0100
Stats: 1 file changed; +5 (insertions), -4 (deletions)
  • Fixed separators sometimes being aggressively removed from menus, plus one logic error. (GenericMenu.template.php)
[Commit revision 3e6a78b]
Author: Nao
Date: Fri, 06 Feb 2015 18:26:45 +0100
Stats: 1 file changed; +8 (insertions), -7 (deletions)
  • Fixed a situation where uploaded media files could fail being registered. For some reason, this doesn't happen on wedge.org but always happened on my local install, so it was probably a permission issue, but this hack will help either way. (Subs-Media.php)
  • Allowing server to log errors if it can't move an uploaded file to its temp folder. It's just for helping with debugging, I guess... You don't want to spend your life tracing through code here, believe me. (Subs-Media.php)
Re: New revs
« Reply #2756, on February 6th, 2015, 06:30 PM »
[Commit revision 42a9772]
Author: Nao
Date: Fri, 06 Feb 2015 18:30:37 +0100
Stats: 2 files changed; +4 (insertions), -4 (deletions)
  • For some reason, when I renamed the media/generic_images folder to media/icons, I forgot to rename it in a few places. That must explain all the 404 errors I got since then when it came to generic icons, I guess..? (ManageMedia2.php, Subs-Media.php)
Re: New revs
« Reply #2757, on February 12th, 2015, 04:53 PM »
[Commit revision 39b639b]
Author: Nao
Date: Tue, 10 Feb 2015 17:02:40 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • The error log now indicates the error type/level in some specific PHP errors. (Errors.php)
[Commit revision b6ffd20]
Author: Nao
Date: Thu, 12 Feb 2015 16:53:27 +0100
Stats: 8 files changed; +170 (insertions), -119 (deletions)
  • Adding preliminary support for video.js library, replacing JW Player. Using the CDN version, to save some space. Basically, you're getting no new features out of it; the main differences are (1) IE will no longer show a spectrum analyzer on audio files (not fixable, screw IE), (2) the spectrum analyzer is now done in JS so it can be customized, (3) Wedge is now free of licence issues regarding JW Player. I liked that player, but they never answered my questions regarding redistribution, so... goodbye? (Aeva-Foxy.php, Aeva-Subs-Vital.php, Class-Media.php, Subs-Media.php, player.js, media.css)
  • OGG files now have a proper 'audio/ogg' MIME type... This has actually been standard since 2008, so... WTH?! (Aeva-Subs-Vital.php, Class-Media.php)
  • Removed player color customization settings. Pretty easy to guess why: since it's rendered in HTML now, you can directly skin your player from a CSS file, and that's per-skin, not per-site. (Aeva-Subs-Vital.php, ManageMedia.php, ManageMedia.english.php)
  • Added a tentative fallback for generic icons not being copied into your media folder... Let me hazard a guess... The importer is probably broken when it comes to media galleries, hmm..? (Subs-Media.php)
  • OGG files won't be played on IE7 & IE8, but I'm not sure they ever have, anyway... Can always download them anyway.
  • Playlists are still terribly broken, so... Don't use them for now.
  • Spectrum analyzer is still in its infancy.
  • If you're having problems... Use the cache purge feature, as always.
Re: New revs
« Reply #2758, on February 12th, 2015, 05:11 PM »
[Commit revision 30d7978]
Author: Nao
Date: Thu, 12 Feb 2015 17:11:37 +0100
Stats: 2 files changed; +0 (insertion), -0 (deletion)
  • Bye bye, JW Player's Flash files!
Re: New revs
« Reply #2759, on February 12th, 2015, 11:32 PM »
[Commit revision 55e6fc6]
Author: Nao
Date: Thu, 12 Feb 2015 23:32:13 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Last-minute screw-ups are my thing. (Aeva-Subs-Vital.php)
Plugin revs »