New revs

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #120, on September 17th, 2010, 05:17 PM »
rev 116
- Removed a PGSQL fix that doesn't sound very logical with MySQL. (Profile-View.php)
! Finally fixed menu items. Wedge's template is finally entirely pixel-perfect and CSS3-driven if available! (Profile-View.php)
Re: New revs
« Reply #121, on September 18th, 2010, 01:46 PM »
rev 117
! Fixed IE6 emulation code for rounded corners. (theme.js)
- Deleted insertAfter() function and moved a replacement to theme.js because, well, I don't think it'll be used much... (script.js, theme.js)
* We don't really need to obfuscate copyright checking code anymore, do we...? (Subs.php)

FWIW, Wedge doesn't look great with IE6, but it's only details (like a repeating background on roundframes where it shouldn't repeat...), nothing that can't be fixed if we're really anal about them.
Re: New revs
« Reply #122, on September 18th, 2010, 05:19 PM »
rev 118
* Replaced SMF's menu system with own. Warning, work in progress! GenericMenu needs cleaning up, GIFs could be sprited, etc. (ie6.css, index.css, GenericMenu.template.php, script.js, submenu.gif, subsection.gif)
Re: New revs
« Reply #123, on September 18th, 2010, 11:58 PM »
rev 119
* Finished implementing a workaround for the iPhone's lack of onmouseover()/onmouseout() in the new system. New code is particularly cool, and I'm not saying that because I spent my entire day on it. Ah well. (script.js, ie6.css, index.css)
! Forgot to indent HTML code for menu. Originally needed to be in a block because of a IE6 bug. (GenericMenu.template.php)
! Spacing nazi. (Recent.template.php)
Re: New revs
« Reply #124, on September 19th, 2010, 05:01 PM »
rev 120
* Replaced default SMF logo with a Wedge logo... Might as well do it, uh? Need to replace all smglogo occurrences in the source code. (install.php, index.css, rtl.css, wedgelogo.png, index.template.php)
+ Added a menu file I forgot. (white-op85.png)
! Fixed menu system to be able to handle several menus at the same time. (script.js, index.css, GenericMenu.template.php, ie6.css)
! .cat_bar h4 used a dark text color. Should be a bright one, given the background context. (index.css)
* Implemented the new menu system for SMF's main menu. Yay! (index.css, index.template.php)
@ To do: finish Wedge logo replacements, delete template_old_menu, harmonize Subs-Menu.php and Load.php menu generators (why are there two to begin with?!), change menu CSS to harmonize it with Curve, fix non-breaking minor glitch in menu system in IE6. And get started with the on-the-fly sidebar-menu transformation...

(Sorry that I'm fixing several issues in a single shot, but I kinda can't commit index.css in several portions, that would be dull...)

(Also, I'm not used to committing commented out or useless code, but I'd rather keep template_old_menu under the hand just in case I need to refer to it when doing further work.)
Re: New revs
« Reply #125, on September 20th, 2010, 01:00 PM »
rev 121
* Improved menu styling. (index.css)
* Merged menu arrows into a single file. (submenu.gif, subsection.gif, menu.gif)
* Cleaning up. (script.js)
! Fixed padding in live_news box. (admin.css)

(Ain't done yet!)
Re: New revs
« Reply #126, on September 20th, 2010, 08:44 PM »
rev 122
* More menu styling changes. It's starting to look better, now... (index.css, script.js)
* Updated to SMF rev 10121. SendTopic lines were screwed up, BTW... (Class-Editor.php, SendTopic.template.php, PersonalMessage.template.php, MessageIndex.template.php, Display.template.php)
@ I decided not to go with bugfix 4446. Personal choice...

http://dev.simplemachines.org/mantis/view.php?id=4446

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #127, on September 20th, 2010, 10:37 PM »
Revision: 123
Author: arantor
Date: 21:31:00, 20 September 2010
Message:
+ Code documentation and a half (Post.php)
----
Modified : /trunk/Sources/Post.php


This added 130 new lines of documentation, and replaced the 60 or so incomplete lines there anyway...


@ Nao, I looked at bug 4446, I'm not sure what was actually applied - but is there a better fix than they've discussed? (CSS is not my forte) Or at least, one that is better for us?
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #128, on September 20th, 2010, 11:04 PM »
Well, the proposed fix was to apply overflow: hidden to .post_wrapper, which is EXACTLY what was already done on Wedge... (I don't know if I did it -- I probably did, although I don't remember.) I didn't know about this bug report until I looked into the fix.
What was done instead, was to apply float: left; width: 100% to the class.
However, I applied this to wedgeforum.com and noisen.com, and the windowbg/windowbg2 classes ended up getting a height of 0px, and the contents were overflowing from them obviously. I re-established my overflow, and it worked again. So I figured, to hell with this fix... I prefer mine. While Antechinus says it "doesn't work on every browser", in my experience it does. Even in IE6... Specifying an overflow setting has saved me from numerous issues with floating divs, really.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #129, on September 20th, 2010, 11:06 PM »
Then as far as I'm concerned your solution is better and works more in a way that works for us :) Yay for diverging routes!

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #130, on September 20th, 2010, 11:27 PM »
Given that I have to edit everything manually everytime they change a template (because of the header changes), I'm getting used to diverging routes... ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #131, on September 21st, 2010, 03:05 AM »
Revision: 124
Author: arantor
Date: 01:50:45, 21 September 2010
Message:
- Remove the help stuff:
 - Remove the action=help itself (index.php, Help.php)
 - Remove the menu item (Subs.php)
 - Remove the no-longer-used templates (Help.template.php)
 - Remove the no-longer-used text strings (Who.english.php, Manual.english.php removal entirely)
 - Remove semantic links to the page (index.template.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/index.template.php
Deleted : /trunk/Themes/default/languages/Manual.english.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php


Revision: 125
Author: arantor
Date: 01:53:19, 21 September 2010
Message:
! Revert commit of install.php, did not intend to commit local use changes.
----
Modified : /trunk/other/install.php



I didn't actually mean to commit install.php in r124, because that's my modified version to handle the UTF-8 changes... so I've reverted it. But really, it shouldn't be a problem (and you can see what I did in r124) - the sole idea was to bump the minimum MySQL version to 4.1.0 and just make it install without complaining such that if UTF-8 was ticked (and it was by default), that it would install it. (Right now, it really doesn't work properly, but it's a non issue for testing purposes)
Posted: September 21st, 2010, 02:55 AM

Revision: 126
Author: arantor
Date: 02:05:25, 21 September 2010
Message:
+ Added Yandex to the list of supported search engines (install_2-0.sql)
----
Modified : /trunk/other/install_2-0.sql

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #132, on September 21st, 2010, 12:26 PM »
Good job.

You forgot to mention this one you committed:
rev 127
+ Added the ability to override banned users' avatars and simply hide them. More options will follow, hence building it like this. (ManageAttachments.php, Load.php, Admin.english.php, Help.english.php)

Also, as discussed earlier:

rev 128
- Removed converters folder, because right now we're only planning on supporting conversion from SMF2. Once it's ready, anyone can go from their forum system to SMF2, and then to Wedge.
Posted: September 21st, 2010, 12:22 PM

rev 129
- Deleted help_convert folder, as it's obviously a very outdated system related to the help templates.

(If you look at the copyright, it says Lewis Media 2006... I doubt it was updated after that!)
Re: New revs
« Reply #133, on September 21st, 2010, 07:36 PM »
rev 130
* Renamed MSN bot to Bing. (install_2-0.sql)
* Some help-related cleaning up. (*.dtd, Help.php)
- Dropped hover addon function for IE, because the new menu is cool and doesn't need that. (theme.js)
- Dropped rounded corner compatibility code, because... Well, screw IE! (index.css, old.css, theme.js)
- Dropped compat.css, in the same vein, because... Well, it sucks as a converter.
- Removed .rrc class from all templates. (Admin, BoardIndex, Calendar, Display, Help, Login, Memberlist, Notify, PM, Poll, Post, Profile, Register, Reminder, Search)
* A couple of fixes to IE6 layout, and IE7 cleanup. (ie6.css, ie7.css)
* Redesigned Curve layout. Mostly for the menu system. (index.css, menu.png, white-op85.png, grad*.png)
* Restarted menu layout code from the original SMF code, in a cleaner way. (GenericMenu.template.php, index.template.php)
@ TODO: Delete main_block.png, deal with rtl.css, and more cleanup.

Pete, hopefully you won't have the design changes too much! Remember, it's a work in progress. The header is to be redone. I just wanted to get rid of the SMF frame ASAP and couldn't find a suitable replacement!
Re: New revs
« Reply #134, on September 22nd, 2010, 11:21 AM »
A cleanup commit entiely...

rev 131
- Deleted help area styling. (index.css, rtl.css)
- Deleted rounded corner compatibility code... For good!! (theme.js)
- Deleted tags when an ID is specified for them, as it's useless and hurts performance. (index.css, rtl.css, admin.css)
- Deleted topslice_quote and botslice_quote placeholders from quotes, because, well... If you're going to emulate rounded corners, you don't need them. And don't tempt me into deleting the quotefooter placeholder entirely! (Subs.php)
* Renamed left_adm* and main_adm* classes because they're generic, not admin-centered. (index.css, rtl.css, ie6.css, GenericMenu.template.php)
! Fixed a few issues with rounded corners. (SplitTopics.template.php)
* Moved style.css linking a few lines above in the head section, so that the browser will notice it sooner in case the HTML page isn't gzipped. (index.template.php)
* Spacinazi. (PersonalMessage.template.php)