New revs

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #105, on September 14th, 2010, 01:27 AM »
Don't bother about the unnamed template files in rev 98 -- they're really super boring. I checked them all, there's approx. 300-400 lines changed, always the same (<h3 class="catbg"> -> <h3>)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #106, on September 14th, 2010, 11:14 AM »
I just checked everything as a unified diff from where I was to current, seeing all the changes as the total sum of changes per file. Looks good to me.



Revision: 102
Author: arantor
Date: 10:13:32, 14 September 2010
Message:
+ Code documentation (Subs-Sound.php)
----
Modified : /trunk/Sources/Subs-Sound.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #107, on September 14th, 2010, 11:18 AM »
Good then.
Hey we commit a few minutes apart from each other, eheh.

rev 103
* Restored topslice/botslice/upperframe/lowerframe classes to index.css, to preserve compatibility with mods -- for now. (index.css, old.css)
* Moved border-radius emulation code to theme.js, where it'd probably better be. (script.js, theme.js)
* Speeded up the on-the-fly image resizer initialization on modern browsers, by calling only images with a 'resized' class. (theme.js)

Should I be checking your code documentation? I really suck at docs...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #108, on September 14th, 2010, 11:31 AM »
Quote
Should I be checking your code documentation? I really suck at docs...
Up to you. That one was particularly dull to document, just threw it together last night before going to bed.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #109, on September 14th, 2010, 11:57 AM »
Documenting is your thing :P
I, myself, will rather strive to simply comment my code because it's probably my weakest area... I realized that when I went through Aeva Lite the other day to add a feature for YouTube compatibility, only to realize an hour later that it was ALREADY implemented :lol:

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #110, on September 15th, 2010, 05:18 AM »
You'll likely find it easier to get into once more of the source is documented. I'm gonna do Errors.php next, did a bit of it earlier before going back to bed. More to follow if I manage to get enough of the house tidy that I don't get murderalised for going back to bed...
Posted: September 14th, 2010, 05:01 PM

Revision: 104
Author: arantor
Date: 02:56:44, 15 September 2010
Message:
+ More code documentation (Errors.php)
----
Modified : /trunk/Sources/Errors.php
Posted: September 15th, 2010, 03:57 AM

Revision: 105
Author: arantor
Date: 04:18:21, 15 September 2010
Message:
+ More code documentation (LockTopic.php)
----
Modified : /trunk/Sources/LockTopic.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #111, on September 15th, 2010, 08:59 PM »
(The usual boring series...)

rev 106
* Finished converting isset() && isset() occurrences to isset(..., ...) (convert.php, upgrade_1-1.sql, upgrade_2-0.sql, MessageIndex.template.php and 40 source files)
Re: New revs
« Reply #112, on September 16th, 2010, 01:48 AM »
rev 107
! Fixed button strips in both CSS3 and emulation. (index.css, old.css)

The main menu fixes will be for tomorrow. (They're using the same concept as button strips, so it's basically the same work.)
I also need to make sure cat_bar and window_bg work the same in both css3 and non-css3 modes.
* Nao/Gilles is tired.

:edit: Uh, apparently cat_bar is good!
Posted: September 16th, 2010, 12:05 AM

rev 108
* Replaced titlebg.png and catbg.png with a single file that is even smaller in size. (index.css, bars.png)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #113, on September 16th, 2010, 04:44 AM »
Revision: 109
Author: arantor
Date: 02:53:03, 16 September 2010
Message:
+ More code documentation (Karma.php, Printpage.php)
----
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/Printpage.php
Posted: September 16th, 2010, 03:53 AM

Revision: 110
Author: arantor
Date: 03:44:02, 16 September 2010
Message:
+ Further code documentation (DumpDatabase.php, Subs-MessageIndex.php)
----
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Subs-MessageIndex.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #114, on September 16th, 2010, 04:47 PM »
rev 111
* Some cosmetic fixes to a couple of icons. (stats_posters.gif, stats_replies.gif)
! On very short posts, the poster information area could overflow. (index.css)
! Icons inside bars were a bit too close to the top of the bar. (index.css)
! .title_bar h4 bars were a bit too tall. Why just them, I don't know. Don't ask. (index.css)
- Removed a couple of h3/h4 related styles that didn't seem to be of any use. (index.css)

(At this point, I feel like I'm a themer, rather than a coder...... Don't worry, it won't be forever :P)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #115, on September 16th, 2010, 09:42 PM »
Revision: 112
Author: arantor
Date: 20:41:41, 16 September 2010
Message:
! Stupid documentation fixes (DumpDatabase.php, Karma.php, LockTopic.php, Printpage.php, Subs-MessageIndex.php)
+ New code documentation (BoardIndex.php, Xml.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/LockTopic.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Xml.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #116, on September 16th, 2010, 10:15 PM »
rev 113
* Dozens and dozens of comma fixes... You gotta love the spacing nazi, eh? And I didn't even do them all. It's boring, even for me. (Don't you dare ask me for a file list.)

Seriously, that's plenty of files. The diff patch is relatively short though, so if you want to analyze the changes, please do it through a diff ;)
Re: New revs
« Reply #117, on September 17th, 2010, 01:20 AM »
rev 114
* Updated to SMF rev 10119. Got a lot of conflicts... We're getting away from the SMF2 code quick!
  + * Avatars and other packages removals missed session vars (Package template) [Bug 4463]
  + ! Small cleanup and tweaks [Bug 4461]
  + ! Fix attachments boxes cleanup for Safari [Bug 4470]
  + * Variant selection was disregarded when previewing a theme. (Themes template) [Bug 4433]
  + * Redirect back to the post instead of board, after reporting a post. (Display.php, MessageIndex.php, SendTopic.php, Display template, MessageIndex template) [Bug 4452]
  + ! Adjusted the URL for the arin whois service to reflect its new location. (Profile-View.php) [Bug 4464]
  + * Incorrect label assignment in Reattribute User Posts section. (ManageMaintenance template) [Bug 4467]
  + ! Restoring moderate_board permission for guests. (ManagePermissions.php)
  + * Ignored members' posts were not hidden in topic summary. (Post.php, Post template, Xml template) [Bug 4466]
  + * Variant selection was broken with reserved variant names. (Themes template) [Bug 4435]

And that annoying "Ignore User" feature is adding more bloat to SMF... (Check out the extra xml line in Xml.php, for instance.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #118, on September 17th, 2010, 01:36 AM »
Bug 4463 and 4464 were ones I already patched? Though 4464 had some extra bits in the notes about being cleaner than what I did?

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #119, on September 17th, 2010, 05:19 AM »
- 4464 provides a different URL compared to yours. If doesn't have "query.do" in it, and is cleaner. I haven't tested it, but I suppose it's the official URL.
- 4463, as I said elsewhere, adds an extra check somewhere.

Rest of the interleaved patches -- didn't apply, and didn't document. I left everything in the changelog.txt file, though (for what it's worth, since the file will be going away ASAP.)
Posted: September 17th, 2010, 01:39 AM

rev 115
! For an unknown reason, the Post template wasn't correctly updated, even though I did it manually in the first place... (Post.template.php)