Yes, parse_type is definitely buggy; it should be 'type', as per your parse_bbc code.
Tell you what... I'm seeing that most of the parse_bbc calls (about 90+ out of ~125) include a parse_type, which I think is good.
I'm thinking that, given how we'd both obviously like it to become a second nature when calling parse_bbc, we should have it outside of the array...
parse_bbc($message, $type, array(...)) or parse_bbc($message, null, array(...)) if no type is defined, which would be illogical...
There are about 30 calls with an owner ID in them, so it's about a quarter of all calls, which isn't enough to justify adding a specific parameter for user ID. I would, however, suggest looking into renaming it to 'user' or just 'u' (as in profiles), probably 'user' is better for readability; 'owner' is fine, too, but it's one extra character, and apart from thoughts and profiles, it's not a terminology that's used a lot, at least less than 'member' or 'user'.
Thoughts..? :^^;:
(I'm volunteering to change parse_type to the parameter style if you don't mind, and if you accept the change, of course.)
Tell you what... I'm seeing that most of the parse_bbc calls (about 90+ out of ~125) include a parse_type, which I think is good.
I'm thinking that, given how we'd both obviously like it to become a second nature when calling parse_bbc, we should have it outside of the array...
parse_bbc($message, $type, array(...)) or parse_bbc($message, null, array(...)) if no type is defined, which would be illogical...
There are about 30 calls with an owner ID in them, so it's about a quarter of all calls, which isn't enough to justify adding a specific parameter for user ID. I would, however, suggest looking into renaming it to 'user' or just 'u' (as in profiles), probably 'user' is better for readability; 'owner' is fine, too, but it's one extra character, and apart from thoughts and profiles, it's not a terminology that's used a lot, at least less than 'member' or 'user'.
Thoughts..? :^^;:
(I'm volunteering to change parse_type to the parameter style if you don't mind, and if you accept the change, of course.)