Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Topics - live627
16
Archived fixes / Template logic error for unapproved topics
« on June 29th, 2013, 11:27 PM »
Code: [Select]
Index: I:/Backups/Linux Drive/john/repos/arantor_wedge/trunk/Themes/default/MessageIndex.template.php
===================================================================
--- I:/Backups/Linux Drive/john/repos/arantor_wedge/trunk/Themes/default/MessageIndex.template.php (revision 2166)
+++ I:/Backups/Linux Drive/john/repos/arantor_wedge/trunk/Themes/default/MessageIndex.template.php (working copy)
@@ -111,7 +111,7 @@
  <td class="subject ', $alternate_class, '">
  <div', (!empty($topic['quick_mod']['modify']) ? ' id="topic_' . $topic['id'] . '" ondblclick="modify_topic(' . $topic['id'] . ', ' . $topic['first_post']['id'] . ');"' : ''), '>
  <span id="msg_' . $topic['first_post']['id'] . '">', $topic['new'] && we::$is_member ? $topic['new_link'] : $topic['first_post']['link'],
- !$context['can_approve_posts'] && !$topic['approved'] ? ' <em>(' . $txt['awaiting_approval'] . ')</em>' : '', '</span>';
+ $context['can_approve_posts'] && !$topic['approved'] ? ' <em>(' . $txt['awaiting_approval'] . ')</em>' : '', '</span>';
 
  // Is this topic new? (assuming they are logged in!)
  if ($topic['new'] && we::$is_member)
17
Archived fixes / Just emptied the boards table and got an error
« on June 29th, 2013, 09:43 AM »

Notice: Undefined offset: 0 in I:\www\wedge\trunk\Sources\Subs-BoardIndex.php on line 476


The mod category still shows up just fine.

Will this happen to some crazy person other than me?
18
Archived fixes / Incorrect list styling in the notifications window
« on June 21st, 2013, 03:42 AM »
See attached figures. List items are supposed to have bullets and no frame. Untitled.png shows how a BBC list looks in the notif window.
19
Plugins / Team List
« on June 21st, 2013, 02:59 AM »
Details

Adds an area that shows all members in specified groups.

Available options:
  • Specify team leaders who will appear first in the list
  • Specify "half" groups which will show names only
  • Show board moderators
  • Show board owners
20
The Pub / two-columns and Firefox on narrow windows
« on June 20th, 2013, 10:37 AM »
The two-columns elements are not expanding to fit the entire width if using Firefox or old IE (untested) and using a narrow window.

The following two selectors are being overriden

Code: [Select]

// Two columns become one if viewed on a small screen.
@media all and (max-width: 800px)
.two-columns
width: 100%
margin: 0

Making them !important fixes the problem.
21
Plugins / Popular topics
« on June 18th, 2013, 07:12 AM »
Details

Adds a block in the info center which will display the most replied to topics in a given period of time.
22
Bug reports / Periodic notifications don't seem to work
« on June 16th, 2013, 02:40 AM »
I've yet to find out why.
23
Bug reports / handleMultiple is only partially implemented
« on June 16th, 2013, 02:37 AM »
handleMultiple is only partially implemented. Its only occurrence is now working.

Now, it gets passed several parameters which led to the assumption that it modifies emails. But it does nothing.

I suggest the following:

  • Do away with all parameters
  • Make it so it only determines whether of not to issue multiple notifications.
  • Don't affect emails.
24
Archived fixes / Undefinded function: sendemail()
« on June 15th, 2013, 08:28 AM »
Class-Notification.php, line 231.
25
Off-topic / I'm hungry
« on June 15th, 2013, 08:06 AM »
26
Archived fixes / Moved to a board I cannot access?
« on June 12th, 2013, 05:53 AM »
See attached. The topic was moved... but I can obviously access the board (Archived Fixes).
27
Archived fixes / Language cache doesn't turn off
« on June 12th, 2013, 05:47 AM »
I have my cache disabled but every time I refresh, new lang cache files appear.
28
Archived fixes / Menu is cut off below the footer
« on June 11th, 2013, 06:34 PM »
Calling @Nao plox
29
Archived fixes / Plugin CSS isn't cached into its own subdir
« on June 11th, 2013, 08:01 AM »
Tagging @Nao


Code: [Select]
@@ -430,7 +430,7 @@
  <link rel="stylesheet" href="' . $final_script . '">';
 }
 
-function add_plugin_css_file($plugin_name, $original_files = array(), $add_link = false)
+function add_plugin_css_file($plugin_name, $original_files = array(), $add_link = false, $ignore_files = array())
 {
  global $context, $settings, $theme, $boardurl, $pluginsdir, $board_info;
 
@@ -483,8 +483,11 @@
  $can_gzip = !empty($settings['enableCompressedData']) && function_exists('gzencode') && isset($_SERVER['HTTP_ACCEPT_ENCODING']) && substr_count($_SERVER['HTTP_ACCEPT_ENCODING'], 'gzip');
  $ext = $can_gzip ? (we::is('safari') ? '.cgz' : '.css.gz') : '.css';
 
+ // Build the target folder from our skin's folder names and main file name. We don't need to show 'common-index-sections-extra-custom' in the main filename, though!
+ $target_folder = trim(implode('-', array_filter(array_diff($original_files, (array) 'common', $ignore_files))), '-');
+
  // Cache final file and retrieve its name.
- $final_script = $boardurl . '/css/' . wedge_cache_css_files('', $id, $latest_date, $files, $can_gzip, $ext, array('$plugindir' => $context['plugins_url'][$plugin_name]));
+ $final_script = $boardurl . '/css/' . wedge_cache_css_files($target_folder . ($target_folder ? '/' : ''), $id, $latest_date, $files, $can_gzip, $ext, array('$plugindir' => $context['plugins_url'][$plugin_name]));
 
  if ($final_script == $boardurl . '/css/')
  return false;
30
Archived fixes / Profile controllers cannot be classes
« on June 10th, 2013, 09:20 AM »
The profile area (and all other areas) are limited by the old method of procedural function calls, checked by function_exists(). I'd like to ask for this to be changed to is_callable and call_user_func_array throughout.

I already made this change to the profile area like so:

Code: [Select]
@@ -529,7 +529,7 @@
  }
 
  // Make sure that the area function does exist!
- if (!isset($profile_include_data['function']) || !function_exists($profile_include_data['function']))
+ if (!isset($profile_include_data['function']) || !is_callable($profile_include_data['function']))
  {
  destroyMenu();
  fatal_lang_error('no_access', false);
@@ -696,7 +696,7 @@
  redirectexit('action=profile' . (we::$user['is_owner'] ? '' : ';u=' . $memID) . ';area=' . $current_area);
 
  // Call the appropriate subaction function.
- $profile_include_data['function']($memID);
+ call_user_func_array($profile_include_data['function'], array($memID));
 
  // Set the page title if it's not already set...
  if (!isset($context['page_title']))

Sample code to make use of this:

Code: [Select]
'function' => array('Awards\Profile', 'showAwards'),