Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
16
Features / Re: New revs
« on September 8th, 2017, 03:16 PM »
[Commit revision 6d382ae]
Author: Nao
Date: Fri, 08 Sep 2017 15:16:34 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • The pattern for youtu.be thumbnail creation was broken. (Aeva-Embed.php)
17
Features / Re: New revs
« on September 8th, 2017, 11:56 AM »
[Commit revision 932fdf8]
Author: Nao
Date: Fri, 08 Sep 2017 11:56:41 +0200
Stats: 1 file changed; +6 (insertions), -6 (deletions)

  • Media embeds in gallery didn't generate thumbnails for https links which, in 2017, are thankfully the vast majority. (Aeva-Embed.php)
  • Note: untested, but should work™.
18
Archived fixes / Re: it keeps giving me this error in Error Log
« on August 28th, 2017, 07:51 AM »
Well, it's true that we don't have your URL...

(And, really? Bumping a 3yo topic? Lol.)
19
Features / Re: New revs
« on August 11th, 2017, 02:02 PM »
[Commit revision a446f57]
Author: Nao
Date: Fri, 11 Aug 2017 14:02:18 +0200
Stats: 2 files changed; +6 (insertions), -3 (deletions)

  • $context['current_privacy'] needs to be an array, not a number. This caused topics to show a 'regular' privacy when editing them, even if their privacy is restricted. (Post.php, Security.php)
20
Apologies for missing out on this topic for so long... I posted in it at the beginning, then forgot about it, and it came at a time when I was putting Wedge behind me and moving on to my next venture (which, at the time, didn't involve Wedge... But ended up involving it, because that's who I am.)
The worst thing here, is that it was a very straightforward fix (just testing if $id_file is empty before calling the query), but I wanted to know WHY it happened in the first place. Now I have my answer because it happened at Wedge.org (uploading a link to an embedded video.)
Still, I hope there aren't more game-breaking bugs like this one... (?)
21
Features / Re: New revs
« on July 25th, 2017, 06:35 PM »
[Commit revision 195825e]
Author: Nao
Date: Tue, 25 Jul 2017 18:33:45 +0200
Stats: 1 file changed; +3 (insertions), -1 (deletion)

  • Found another occurrence of a Yahoo bot being rejected for not being of the allowed IP ranges, even though it was obviously a Yahoo IP range (probably set up after Bad Behavior last updated its ranges). Because of that, and BB's last version being from a year ago, I've decided to disable all tests against bots (Yahoo!, MSN, Google, even Baidu for some reason). Wedge's security is good enough to reject all bot attempts, it doesn't need an extra layer that may actually reject legit bots and thus hurt your rankings. (Security.php)

[Commit revision ccc21c6]
Author: Nao
Date: Tue, 25 Jul 2017 18:35:22 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)

  • And a quick extra layer of future-proof fixing. (Subs-Media.php)
22
Bug reports / Re: Error id_file in Media Gallery
« on July 25th, 2017, 06:21 PM »
You're welcome...
To be specific, the problem was caused by Aeva Media's transparency lookup when someone was uploading an embedded video (e.g. YouTube, Dailymotion...) It hadn't happened in years here, so I had no way to know lol.

Also used the opportunity to fix the same bug in AeMe 2.x, and released 2.11 for AeMe users.
And yes, that includes the infamous installation bug fix... (Not that it'll help users who already had the bug. I told them how to fix it.)
23
Features / Re: New revs
« on July 25th, 2017, 05:40 PM »
[Commit revision 0992946]
Author: Nao
Date: Tue, 25 Jul 2017 17:39:50 +0200
Stats: 1 file changed; +3 (insertions), -3 (deletions)

  • More future-proof fix. (Subs-Media.php)
24
Features / Re: New revs
« on July 25th, 2017, 05:32 PM »
[Commit revision 6ec1c96]
Author: Nao
Date: Tue, 25 Jul 2017 17:32:01 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Getting "The database value you're trying to insert does not exist: id_file" on embedded files in the gallery. (Subs-Media.php)
25
Features / Re: New revs
« on July 22nd, 2017, 11:41 AM »
[Commit revision 389ed36]
Author: Nao
Date: Sat, 22 Jul 2017 10:28:59 +0200
Stats: 4 files changed; +0 (insertion), -0 (deletion)

  • Smaller size, dark-friendly rank icons. (assets/rank*.gif)

[Commit revision d060d06]
Author: Nao
Date: Sat, 22 Jul 2017 11:08:01 +0200
Stats: 3 files changed; +96 (insertions), -99 (deletions)

  • array() to [] conversions in the one file that screams "I'm there to optimize sizes, so optimize me!!" (Subs-Cache.php)
  • Same for Ajax.php because I can, also fixed a thought conversion call that was taking more space than needed in the database. (Ajax.php)
  • Also shaved a few bytes off serialized strings with integers in them. (Subs.php)

[Commit revision 0c3cd07]
Author: Nao
Date: Sat, 22 Jul 2017 11:10:20 +0200
Stats: 1 file changed; +14 (insertions), -7 (deletions)

  • Added proper hyphens support to Wess, now that, years later, support has grown a bit. (Class-CSS.php)
  • Dynamic functions shouldn't be cached across all CSS files... That can lead to some unexpected results. Not that it matters, really. (Class-CSS.php)

[Commit revision bcb61a6]
Author: Nao
Date: Sat, 22 Jul 2017 11:12:20 +0200
Stats: 2 files changed; +2 (insertions), -2 (deletions)

  • Simplified a query. (Memberlist.php)
  • PHP caching code was probably a bit too greedy. Wait time after uploading a file was reduced to 2 seconds max, with perfect results on my sometimes busy server. (Subs-CachePHP.php)

[Commit revision 8d4d155]
Author: Nao
Date: Sat, 22 Jul 2017 11:14:36 +0200
Stats: 2 files changed; +5 (insertions), -2 (deletions)

  • No need to log an error when someone logs off and has another tab around which still attempts to fetch notifications... It's okay, calm down. (Notifications.php)
  • Account for potential inputs inside select boxes. (sbox.js)

[Commit revision cee6d78]
Author: Nao
Date: Sat, 22 Jul 2017 11:17:20 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • While I no longer use a proxy, I've established that the most useful IP data to be recorded is the one discovered through the proxy's special headers. If nothing was found (e.g. no proxy), that data will be the same as usual anyway... Way, way more useful for most tasks. (Class-System.php)

[Commit revision ec916e4]
Author: Nao
Date: Sat, 22 Jul 2017 11:18:25 +0200
Stats: 2 files changed; +2 (insertions), -2 (deletions)

  • Why should guests want to collapse a category? Excuse me for a minute-- why would members want to, either? Anyway, guests, one less useless button for you... (Subs-Boards.php, Subs-BoardIndex.php)

[Commit revision 1937057]
Author: Nao
Date: Sat, 22 Jul 2017 11:20:23 +0200
Stats: 3 files changed; +6 (insertions), -13 (deletions)

  • Moved some of the app_error_count logic around. I haven't seen significant improvements, but it makes more sense to me. (index.php, Subs-Template.php)
  • Spacinazi. (index.template.php)

[Commit revision 3349b81]
Author: Nao
Date: Sat, 22 Jul 2017 11:25:34 +0200
Stats: 1 file changed; +1 (insertion), -96 (deletions)

  • Removed my very own sticky positioning polyfill. Why? Chrome recently added proper support for 'position: fixed', and I figured it would mean 90% of users would no longer need a polyfill. Older browsers will simply do without it, it's not a deal breaker anyway. Rest in peace polyfill, I was proud of you. (topic.js)

[Commit revision fa1b720]
Author: Nao
Date: Sat, 22 Jul 2017 11:28:22 +0200
Stats: 1 file changed; +30 (insertions), -30 (deletions)

  • Make sure search engines can't see context menus, even if some items remain for guests. This makes for uncomfortable pseudo-URLs that get parsed for no reason... Also, more array() to [] conversions. (Display.php)

[Commit revision 878793c]
Author: Nao
Date: Sat, 22 Jul 2017 11:28:43 +0200
Stats: 2 files changed; +5 (insertions), -5 (deletions)

  • Updated a few files with the https version of the Wedge URL. (ScheduledTasks.php, Credits.php)
  • I didn't need some hack in PM code... (pm.js)

[Commit revision c43f32d]
Author: Nao
Date: Sat, 22 Jul 2017 11:30:27 +0200
Stats: 4 files changed; +12 (insertions), -12 (deletions)

  • More protocol conversions. (install.php, Help.english.php, index.english.php, Admin.english.php)

[Commit revision aabdd5f]
Author: Nao
Date: Sat, 22 Jul 2017 11:33:32 +0200
Stats: 1 file changed; +8 (insertions), -8 (deletions)

  • Fixed error handling to use proper PHP logic for error constants, rather than the weird situation it was in in SMF... It was very old code, I reckon. Not finished with it though, I've got a better version live at Lestrades.com but I need to test it further. (Errors.php)

[Commit revision 7f9ec53]
Author: Nao
Date: Sat, 22 Jul 2017 11:36:23 +0200
Stats: 1 file changed; +18 (insertions), -16 (deletions)

  • Added support for MySQL strict mode -- more specifically, the ability to disable it through a global variable. I wrote that for a previous server, and never bothered to commit it because I didn't need it anymore by the time I was committing everything. But still, can be useful to some... I know I wasted a few hours on that one..! (Class-DB.php)
  • Fixed {literal:...} code not allowing for flexible strings. (Class-DB.php)

[Commit revision 14d6a15]
Author: Nao
Date: Sat, 22 Jul 2017 11:41:01 +0200
Stats: 1 file changed; +32 (insertions), -20 (deletions)

  • Wrote a better, more self-explained version of invertAll() (kept the silly name though, for compatibility reasons), where it's made more explicit what the function does, *and* it now also ensures that events linked to those checkboxes are called as needed. (script.js)
  • Tweaked notification popup code to accomodate for any custom changes to the notification button HTML. I know it helped me. Also various additions and fixes that I won't bother listing. (script.js)
  • Reduced length of some select box strings. The idea is, you only need to escape the "<" sign... Everything else is fair game. As a result, the new stuff is more readable, and shorter of course. I always go for shorter. (script.js)
26
The Pub / [Suggestion] Re: HTML & PHP Blocks
« on July 21st, 2017, 12:20 PM »
I'm sorry, this is the kind of thing that is really better done as tech support work. This isn't something I can do for free. (But the good news is, anyone with minimal knowledge can do it, so you don't have to pay me specifically for do it. Not that I'd complain, eh... I made $5 profit over 7 years of work on Wedge...)
27
Bug reports / Re: YouTube Videos not Fullscreen
« on July 21st, 2017, 12:18 PM »
(Note: don't forget to regenerate your site list from your admin area.)
28
Features / Re: New revs
« on July 19th, 2017, 04:33 PM »
[Commit revision fb42680]
Author: Nao
Date: Wed, 19 Jul 2017 16:33:32 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Fixed YouTube no longer allowing for fullscreen mode... I think? (Subs-Aeva-Sites.php)
29
Bug reports / Re: YouTube Videos not Fullscreen
« on July 19th, 2017, 12:32 PM »
I don't know what to say... My code only uses the default iframe embed system. Except it's the nocookie version, because I was asked by privacy activists to prefer that one over the regular one... Meh.

I tried embedding a video, and didn't get anything. Probably an issue with my computer refusing Flash content. I don't know. I don't really bother for now.

If you have any further questions and you're on Steam, you can add me (ID is naogilles) to chat. Maybe we can fix this quicker. Right now I'm busier on other things I'm afraid. It's note like Wedge's is a very busy community. :-/
30
Bug reports / Re: YouTube Videos not Fullscreen
« on July 16th, 2017, 12:12 PM »
I'll look into it.