Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
Features / Re: New revs
« on April 30th, 02:47 PM »
[Commit revision d45056f]
Author: Nao
Date: Sun, 30 Apr 2017 14:33:38 +0200
Stats: 2 files changed; +6 (insertions), -8 (deletions)

  • Cleaner privacy code. (Security.php)
  • Spacinazi. (Profile-Actions.php)

[Commit revision f52ad02]
Author: Nao
Date: Sun, 30 Apr 2017 14:37:26 +0200
Stats: 2 files changed; +5 (insertions), -4 (deletions)

  • The imperative scheduled task related to checking infraction expire dates doesn't have access to the system object, and thus should be careful with MID and timeformat(). I never noticed this error before because it was probably triggered before the error handler was rerouted, but it showed up (everytime the task was called) in my error.log file, so here we are, a fix. (ManageInfractions.php, Subs.php)
  • PHP 5.4 adds some nice JSON conversion constants, so I'm making use of them now, to remove an ugly str_replace and make integer output less verbose. (Subs.php)

[Commit revision 10494ab]
Author: Nao
Date: Sun, 30 Apr 2017 14:46:53 +0200
Stats: 1 file changed; +2 (insertions), -0 (deletion)

  • Similarly, old notification pruning was using an undefined function, and that wasn't logged normally. (Notifications.php)
Features / Re: New revs
« on April 22nd, 02:31 PM »
[Commit revision ef31bf6]
Author: Nao
Date: Sat, 22 Apr 2017 14:31:26 +0200
Stats: 2 files changed; +3 (insertions), -1 (deletion)

  • Search members by IP was broken (presumably due to Pete upgrading the IP system to support IPv6.) (ManageMembers.php)
  • Removing an error suppressor that I suspect should be unneeded now. (Subs-Cache.php)
Features / Re: New revs
« on April 21st, 07:37 PM »
[Commit revision 26be97f]
Author: Nao
Date: Tue, 18 Apr 2017 17:57:01 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Updated Gravatar URLs to cooperate with https mode. (Subs.php)

[Commit revision 132545d]
Author: Nao
Date: Fri, 21 Apr 2017 19:36:30 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Some stuff I don't know about. Don't ask me, I never touched that place. It's full of cobwebs. (ManageMail.template.php)

[Commit revision 7c269a1]
Author: Nao
Date: Fri, 21 Apr 2017 19:37:43 +0200
Stats: 1 file changed; +2 (insertions), -0 (deletion)

  • Dropdowns would fail to open in case they had the 'multiple' attribute and no pre-selected entry. (sbox.js)
Features / Re: Language revs
« on April 19th, 12:04 AM »
I also merged your topic-solved commits.
Quote from Freñiçh on April 18th, 07:40 PM
Well i am sorry it was not my intention to cause you so much trouble,but i can't upload files directly into language/Dutch because file uploads require push access to your repository.
Well, obviously that's the pull request system. (?)
So i compare base fork with the head fork,and drag the remaining files into my repository.(Github is what concerns to me a struggle but i am trying to understand the logic behind it )
Yeah, it's quite a bit painful, I had to go through that too, but multiply by 1000 because I also had to rebase stuff, rewrite tons of commits through the command line... It took me weeks of work, just to get it to what it is now. :^^;:
Features / Re: Language revs
« on April 18th, 11:59 PM »
[Commit revision db90bfd]
Author: Nao
Date: Tue, 18 Apr 2017 23:59:26 +0200
Stats: 2 files changed; +0 (insertion), -179 (deletions)

  • Nearly there! ;) (ManageScheduledtasks.dutch.php, dutch/license.txt)
Features / Re: Language revs
« on April 18th, 11:57 PM »
[Commit revision cf3ba32]
Author: French77
Date: Tue, 18 Apr 2017 23:57:28 +0200
Stats: 22 files changed; +3417 (insertions), -0 (deletion)

  • remaining dutch language files (#75)
  • ManageScheduledtasks.dutch.php
  • Upload remaining files
  • Dutch language
The Pub / Re: Question about SHA1/256 (github issue #60)
« on April 18th, 01:46 PM »
Hi Suki/Marceline! Hadn't seen you here in 3 years ;)

So, you guys think I should use something like that..?

I'd suggest using the bcrypt parameter explicitly so that if Wedge is ever abandoned, it doesn't break completely.

(Unless I really don't understand the problem...)
Features / Re: New revs
« on April 18th, 01:42 PM »
[Commit revision 5973dac]
Author: Nao
Date: Tue, 18 Apr 2017 13:42:43 +0200
Stats: 1 file changed; +12 (insertions), -9 (deletions)

  • Don't bother with backslashes inside comments, PHP ignores them anyway. (Subs-CachePHP.php)
  • PHP single-line comments can be 'stopped' by a ?> sign, this should fix it. However I haven't seen multi-line comments behave the same, so I'm leaving those aside for now. Would appreciate some feedback, but it's no big deal since ?> is barely used in Wedge. (Subs-CachePHP.php)
  • This actually fixes a bug (and only one) in Wedge-- that occurred when sending non-HTML posts in French. It was broken for the last 3 years, and I never understood why. Now I know. Someone at SMF used a backslash at the end of a comment. The fools.
Features / Re: Language revs
« on April 18th, 01:28 AM »
I'm not trying to frustrate anyone. Just trying to frustrate *me* as little as possible. :P
Features / Re: New revs
« on April 18th, 01:27 AM »
[Commit revision e80acb5]
Author: Nao
Date: Tue, 18 Apr 2017 01:27:11 +0200
Stats: 1 file changed; +12 (insertions), -20 (deletions)

  • Two new techniques for the key-value file cache, to combat possible race conditions. First of all, Wedge will no longer attempt to delete an expired file when it sees it expired. It's the script's responsibility to regenerate the cache (and thus the file) when it gets an invalid result (also, this saves more bytes, and I like saving bytes). Secondly, files are now created under a random name (like in Subs-CachePHP.php), and then renamed if everything works. This should help in a LOT of situations. And I'm serious. Just like I fixed race condition issues with the PHP minifier, I'm hoping this will also be the case here, although it happens much less often-- in fact the only reason I fought this is because Opera Chromium is bloody running two queries on my site at the exact same millisecond, even if I didn't ask for that. For once, it's Opera's fault. (Subs-Cache.php)
  • Seriously, someone should report that to them... Opera is actually loading Atom feeds even though I never added them to my feed list.
Features / Re: Language revs
« on April 17th, 05:21 PM »
I'm absolutely for any new translations.

What I'm against, however, is wasting time. So, if you want your translations to be in the main languages repo, you should learn how to handle Github and pull requests. That's all.
Yesterday you sent empty pull requests. Today you sent one pull request *per* file, meaning I got an e-mail notification for each of those. When I started accepting the pull requests, I then realized the files were all committed to the root folder (which is NOT for anything other than English files, this isn't SMF, this is Wedge, where files are carefully sorted in language folders!) So I had to do another commit to put them all into place. You also committed a junk file in the lot. It's a real mess. So I said, I'll stop merging your PRs, yet you kept sending them so at the end I just canceled them all.

All I want is a clean repo with just a single commit for all of your files. That's all... Just create a new repo locally from Github, move your new files to the dutch folder, right-click them all, "Add", then commit, and send a single pull request (you can do that one from the Github website as long as it knows your repo is forked from mine, IIRC). It's really easy... It just takes a couple of minutes. Not the couple of hours it took you to upload everything manually...
Features / Re: Language revs
« on April 17th, 02:22 PM »
[Commit revision 5a0dc43]
Author: French77
Date: Mon, 17 Apr 2017 14:06:39 +0200
Stats: 1 file changed; +658 (insertions), -0 (deletion)

  • Create index.dutch.php (#41)
Features / Re: Language revs
« on April 17th, 02:21 PM »
[Commit revision a00d78c]
Author: Nao
Date: Mon, 27 Mar 2017 20:12:03 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Grammar nazi. (ManageInfractions.french.php)
Features / Re: Language revs
« on April 17th, 02:19 PM »
@Freñch, please stop committing individual files and sending pull requests for those!
Also, move them to the proper folder!
The Pub / Re: Question about SHA1/256 (github issue #60)
« on April 16th, 04:13 PM »
If I do password_hash() with PASSWORD_DEFAULT, then it means I can't be sure what algorithm will be used to hash the password, right..?

So, how exactly can I hash the password on the client side if I don't know which kind of crypt system PHP will use to compare it with my own hash...?