Wedge

I'd day not, Facebook isn't even updated.

For updates come to wedge.org I guess

So I just recently got my first few notifications and I actually really like how it works,

I pretty much never check my email so I did not use the previous method of being notified by email of replies, PM's, etc. Needless to say that many things have gone missed by me because eventually I forget that i wanted to keep up with a particular topic, had I been notified via email it would have yielded the same result anyway.

Once the notification system was in use here I looked at the settings and chose to not be notified via email so that was great for me, no need to get emails I'll not see for months after they've stopped being relevant right. I have surprisingly been caught up on all the topics so no particular topic struck me as need to be notified so I sat jealously and patiently by reading how nice the system was and would ya know it @Arantor liked a post of mine and boom now I can see this thing in action from a true use case perspective without having being notified just for the hell of it. Then @Nao mentions me and I got that notification as well.

I gotta say great work here @Dragooon and guys. This is how I would love to have always received notifications on forums I visit.

I got that from the other times you explained this and I myself am not looking for it, now however would like to see it when avail, no rush for me, and You two Guys are doing Quite a task here and it seems to me it moving right along! I just wish I could be of help, but possibly I can spark a thought or two, hopefully anyway!

I like to see this going forward and not stuck like other things seem LOL ( not here) and this a good thing!

regards,
Maxx

OK, so I was ruminating on this today. One of the things I wanted in the mini-skeleton is the ability essentially to be able to juggle poster info around and inject new areas, and having it as one huge <msg_author> block kind of bugged me.

So I juggled it around and I came up with this:


I split it all out, and while it's ugly, it does work as expected. I haven't bothered prettying it up because I'm not sure about committing it yet, mostly because I haven't been able to meaningfully benchmark the performance aspects.

More importantly, it does mean a lot of extra tests are being done unnecessarily at this point because of course, $msg['member']['is_guest'] and $context['is_mobile'] need to be tested a lot more. Still there's ways around that - I see no reason why Display couldn't do the test then alter the relevant skeleton instance to just cut those functions from being called, entirely.

There's also stuff like $gts being redeclared every function call and stuff (rather than checked and force-set properly earlier on) but that's all fixable stuff.

What it does mean, though, is people can move things around easily - and plugins can easily add things wherever they want, rather than just tagging it on to the end of msg_author.

So, what do you reckon? Clean up and commit or rethink?

So far I've removed the main guts of the spell checker, it's only the integration into the search system left. I guess I could commit what I have and not worry about that bit for now - we can always remove it later easily enough.

Though, looking back, I'd prefer to strip it entirely, so that I could get rid of the dictionary info from inside the language files.

(36 modified, 2 deleted, 4KB)

Revision: 1979[1]
Author: arantor
Date: 06 March 2013 21:26:35
Message:
! No more of this 'save in outbox' nonsense. It's saved automatically, even forcing the default for sendpm to save (because plugins doing it should default unless they *know* they don't want to), except for the places it shouldn't, like warning notifications and announcements. (install.sql, ManageMemberOptions.php, ManageNews.php, PersonalMessage.php, Subs-Post.php, PersonalMessage.template.php, Profile.template.php, PersonalMessage and Profile language files)

- Spell checking support removed from the bulk of code. Support does remain but only in the search area and even that might go. (index.php, detailed-version.php, Class-Editor.php, Display.php, Load.php, ManagePosts.php, Profile-Modify.php, Search2.php, Spellcheck.php, Subs-Media.php, Display.template.php, index.css, editor.js[2], language files: Admin, Help, index, ManageSettings, Post, Who)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/editor.js
Deleted : /trunk/Themes/default/scripts/spellcheck.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/index.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/root/install.sql

1.	You got me runnin', goin out of my mind, You got me thinkin' that I'm wastin' my time. Don't bring me down, no, no, no, no, no! I'll tell you once more before I get off the floor: Don't bring me down!
2.	I forgot these in the actual SVN log

It has a very high failure rate because it has no awareness of what's in the database, and I'm not inclined to keep it because of that high failure rate.

Now, there is one way we can fix that, at major DB space cost: by logging what words are actually in the database. It's a similar sort of idea to the search index but instead of storing hashes (which you can't look up against) you also store the actual words in use, and can do comparisons against that reasonably well.

The problem is, it's a major space killer and performance is going to be fairly poor. I personally would rather just ditch the whole thing entirely.

I don't really use spell check...so screw it :P

I can't comment on that, I don't know the history, nor have I spent time reviewing vB 4 or 5 from a user aspect yet (you can find my thoughts on vB 3.8 around here though)

Probably off-topic here, but imho still worth to mention:

http://gracelaw.com/NewsXF.html

In short words, XenForo has apparently won the battle. The case has been dismissed after the parties reached a confidential settlement. The public will most likely never learn about the details of the settlement, but the statement by gracelaw implies that Xf will remain an independent entity and IB has no further way to harm their business.

The case was dismissed with prejudice, basically meaning it's over. Once and forever.

These are bad days for IB/vB. First, they lost the Wikitravel case, then came the disaster with vB going "gold" (imho, it's not even iron in its current state :) ) and now this.