New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #765, on May 1st, 2011, 02:23 AM »
Not a very exciting r750, but still...


Revision: 750
Author: arantor
Date: 01:23:17, 01 May 2011
Message:
! Centralised the setlocale calls instead of making them on every call to formatting some time, as well as centralising the locale definition in the language files (Load.php, Subs.php, Subs-Media.php, index.french.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/languages/index.french.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #766, on May 1st, 2011, 08:50 AM »
rev 751 (useless "it's not 750, dude!" commit)
(7 files +3, 29kb)

+ Added support for new CSS keywords (Class-CSS.php)
  + Cancel inheritance ('unextend' keyword, useful for inherited stylings)
  + Delete a property entirely ('@remove' command)
+ Added support for all possible unit types in math functions. Also removed the mismatched unit protection code, because I'm not sure whether it's best to keep it to not. I'd have to rewrite it anyway. (Class-CSS.php)
* Optimized grad700.png for size, moved original to the image backup folder, as well as the original iPhone and Tablet icons. (other/images/*, grad700.png)
* Updated credits. Project managers are Wedgeward (still us!), added tentative Consultant and Support teams to Wedge credits. Made page more readable. (Credits.php, sections.css)
+ Added support for browser-agnostic linear-gradient call. (Although older Safari versions and IE6/7/8/9 will choke on it.) Also simplified call to the CSS property fixer. (Subs-Cache.php)
* Replaced 'create_topic' hook with the more interesting 'create_post_before' and 'create_post_after'. (Subs-Post.php)
+ Added 'modify_post_before' and 'modify_post_after' hooks. Guess what they do. (Subs-Post.php)
+ Added dummy example for a CSS section in styling file. (Warm/settings.xml)
Re: New revs
« Reply #767, on May 1st, 2011, 05:51 PM »
rev 752
(4 files +1, 41kb)

+ Added support for CSS math functions max, min and rand. I should have done min and max from day one. (Class-CSS.php)
* Committing CSS preparser with 'reset' keyword in the WIP folder. Although I'm sure it'll never be used. (other/wip/Class-CSS (reset keyword).php)
! Non-main CSS files needed an extra dash in the URL. (Subs-Cache.php)
! Fixed JumpTo and optimized for speed and size. (script.js)
! Fixed Wuthering header. (Wuthering/index.css)
Re: New revs
« Reply #768, on May 2nd, 2011, 11:58 AM »
rev 753
(4 files, 7kb)

! In the case where multiple selectors were extended at the same time, Wedge didn't always apply inheritance to all of them. (Class-CSS.php)
! Fixed stray dash in CSS cache files when using the default styling (oops.) (Subs-Cache.php)
! Hopefully fixed post overflow issues by, ahem... Setting it to visible. Eh, what? (index.css, index.ie8.css)
+ Added $big_font and $post_font CSS variables. Trying to be more... Semantic, see? Something like that. (index.css)
Re: New revs
« Reply #769, on May 2nd, 2011, 03:27 PM »
rev 754
(7 files, 10kb)

! Fixed CSS/JS caching on Mobile Safari. (It appears the extension issue only occurs in the desktop version.) (Subs-Cache.php)
! Fixed Mobile Safari crash (why only this?) caused by incorrectly moved variable declaration. (topic.js)
! Webkit keyword wasn't removed from CSS URLs in the main file caching function. (Subs-Cache.php)
! Added missing device icons to stable_icons(). (Subs.php)
* IE always defined createTextRange, doesn't it? (Class-Editor.php)
* Added a meta tag for iPhone devices to increase image and text size. It doesn't look very good, but it's way more usable. (index.iphone.css, index.template.php)
* Overflow problems in polls. (sections.css)

@ Not too happy with the new iPhone look, but honestly... It can serve as a starting point, and usability is more important on a handheld device than looks.
Re: New revs
« Reply #770, on May 2nd, 2011, 07:51 PM »
rev 755
(1 file, 7kb)

+ Added ability to inherit CSS elements from multiple parents. Specify a comma-separated list of items in base: for this, or if you prefer the extends syntax like me, use double quotes around the list (.class extends ".class2, .class3"), otherwise Wedge will consider anything after the first comma to be outside the extend declaration (".class extends .class2", .class3). Not used in Wedge yet, but this can be very interesting in the long run for themers and us. (Class-CSS.php)
! If extending with the use of an ampersand alias, Wedge will now make sure there's only one parent. If there are more, it will only extend based on the first listed parent, to avoid any complications. (Class-CSS.php)

@ That last line -- I could have fixed it to apply to all elements in the list, but honestly at this point it's probably a logic error in the themer's file, and I don't want to waste CPU cycles applying verbatim a request that comes from someone who didn't get what "&" does exactly...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #771, on May 3rd, 2011, 01:12 PM »
Revision: 756
Author: arantor
Date: 12:12:01, 03 May 2011
Message:
! Sync to SMF 10503
 ! r10498 Fix the header bar in reports area to be category rather than title. (Reports.template.php) (SMF rev also changed Admin template, this was already done in Wedge)
 ! r10499 Fix to stop linktree anchors scrunching in IE6 and IE7. (index.css) [Bug 4651]

! Not including
 ! r10500 Making category titles not into links if they're not collapsible - in our case, the category header wasn't even a link to start with.
 ! r10501 CSS change for layout related bug on collapsed categories - bug doesn't affect us as far as I can tell or reproduce (see bug 4639)
 ! r10502 Renaming 'Packages' to 'Package Manager' just for consistency in the menu (this was a reported bug!)... well, they're not called packages here...
 ! r10503 Restructuring the size of dl items in the admin panel just because it throws scrollbars when using the existing sidebar on sub 1024 wide screens... no thanks. (The dl becomes 25% wide and the dt 71% wide...)

! Other
 ! Fix category links to point to #category_n instead of #cn because the category title anchor no longer exists. (Load.php, Recent.php, Search2.php, Unread.php, Unreadreplies.php, ModerationCenter.template.php) (Replaces SMF r10500 only done so much nicer)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/styles/index.css



You can guess who made these SMF revs, can't you?

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #772, on May 3rd, 2011, 03:36 PM »
I'd say Unknown committed these. It's so Unknown! :niark:

Soooo... One commit per minor bug fix, eh? Even with that trick, they still have barely done 430 commits since we started work on Wedge... And we certainly don't settle on a single change per commit :whistle:

rev 757
(12 files, 18kb)

* Reworked poll layout. Moved it below the topic title (to keep a sense of unity when switching between topics with the prev/next links), moved moderation buttons to the top, turned the box into a we:block, etc. (Display.template.php)
! Skip sidebar/top templating in Wireless. It's already done in a few areas to save CPU time, but should be systematic. (Load.php)
! Fixed wrong text string index. (Subs-Media.php)
! If a block specifies an empty parameter, it should be ignored entirely. (Subs.php)
+ Added an 'id' parameter to we:blocks. (index.template.php)
! Because of the sidebar, poll question inputs could overflow easily. (Poll.template.php)
* Reworked profile warning level system's layout. (Profile.template.php)
- ajax_indicator() is always defined. Don't bother testing for it. (topic.js)
! document.body isn't set up on all browsers, or so I've heard. (topic.js)
! User menus were closing unexpectedly in some situations. (topic.js, index.css, sections.css)
* Spacinazi. (Display.php, ManageSettings.php)
Re: New revs
« Reply #773, on May 4th, 2011, 12:21 PM »
rev 758
(19 files, 22kb)

+ Added 'e' parameter to all delayed events. You can now directly access the jQuery-normalized event object for any inline event using the 'e' variable. (Subs.php, example in Profile.template.php)
* Rewrote timing strings in footer to use sprintf, say '1 query' instead of '1 queries', and use a str_replace instead of a preg_replace. (Subs.php, index.template.php, index language)
+ Added language strings for Dynamic Replacements. (Subs.php, index language)
* Rewrote timing functions to use microtime(true) instead of the tricky microtime() for $time_start. You can now easily determine the amount of seconds spent in the page execution with "microtime(true) - $time_start". Also, SMF used time() in a few places to track time spent... Ah ah! No, it's not a joke actually. (index.php, SSI.php, ssi_examples.php, Class-DB.php, ManageAttachments.php, ManageMail.php, ManageMaintenance.php, Aeva-Gallery2.php, ManageMedia.php, Packages.php, RepairBoards.php, ScheduledTasks.php, Subs.php)
! Fixed user menu bug in FF4 and removed useless e.toElement calls, as e.relatedTarget is standardized in jQuery. (script.js, topic.js)
* Rewrote Issue Warning JS to actually work as the SMF code *wanted* it to work (drag'n'slide to change percentage), because yes, it didn't work. (Profile.template.php)
Re: New revs
« Reply #774, on May 4th, 2011, 12:30 PM »
rev 759
(11 files, 11kb)

* Fixed remaining microtime() calls. (tools/*, Feed.php, ManageScheduledTasks.php, Subs-BBC.php, Subs-Cache.php)
! $context['show_page_load'] was used in the index template - chose to restore it instead of removing it. (Subs.php, index.template.php)
Re: New revs
« Reply #775, on May 5th, 2011, 08:50 PM »
rev 760
(11 files, 12kb)

* Changed .attr() calls to be compatible with jQuery 1.6, as we'll probably move to it eventually. (ManageBoards.php, ManageNews.php, Subscriptions-PayPal.php, ManageMaintenance.template.php, ManagePermissions.template.php, ManageSmileys.template.php, Profile.template.php, Register.template.php, up.js)
! Oops, .titlebg was inheriting from the wrong selector. (index.css)
* Details. (post.js, script.js)

NB: Might want to consider optimizing .is() calls in a loop...?
Re: New revs
« Reply #776, on May 6th, 2011, 12:08 AM »
rev 761
(2 files, 7kb)

! It's show_load_time, not show_page_load... (Subs.php)
* Minor optimizations on the uploader JS. (up.js)
Re: New revs
« Reply #777, on May 6th, 2011, 07:39 PM »
rev 762
(1 file +1, 95kb)

* Now using jQuery 1.6 instead of 1.4.4. Keeping the old file in the SVN for now, we never know. (Load.php, jquery-1.6.js)

(What? I'll show the SMF guys I can do single-file commits, too! :niark:)
Re: New revs
« Reply #778, on May 7th, 2011, 07:31 PM »
rev 763
(8 files, 10kb)

! In some cases, the template footer wouldn't be called, and an error would be generated. (Subs.php)
! Why ask Wedge to do a simple addition on tag processing, when developers can do it once and for all? (Subs-BBC.php)
! Inline post edit could generate errors, and trigger yet another error when trying to announce it. (topic.js)
+ Added 'headline' class to the more tag, for themers to style post introductions. (Subs-BBC.php, index.css)
* Upgraded other jQuery 1.4.4 occurrences. (install.php, repair_settings.php, upgrade.php)
* ajax_in_progress box was too big. (index.css)
- Outdated documentation. (admin.js)
Re: New revs
« Reply #779, on May 9th, 2011, 09:56 PM »
rev 764
(4 files +1, 97kb)

* Updated credits with missing names. (Credits.php)
! Replaced main jQuery 1.6 calls with version 1.5.2 instead. Waiting for 1.6.1 with the fix to $.offset() (Load.php, jquery-1.5.2.js)
+ Added minor but nice animation to the menu system. It's just two lines... Can be reverted easily. (script.js)
* Post font spacing was one pixel too big for my taste. (index.css)
* Fixed menu border color and made them slightly less transparent. We got it, it's transparent, it's cool. It should be readable, too. (index.css)