Show Likes

This section allows you to view all posts where this member received or gave a like to.

1
Archived fixes / [CSS] Re: Login looking bad on small screens
Nao « on February 25th, 10:49 PM »
Should also modify the RSS feed list (in the sidebar) to use some normal stuff instead of these fucking dd/dt/dl tags. I'm really sick with them... display:table for the win? Heck you can even push columns to new rows through @media...
2
Bug reports / [Security] Re: BBCode in SQL Database
Nao « on February 11th, 11:04 PM »
Quote from CerealGuy on February 11th, 06:43 PM
So loading bbcodes from file works, language parsing works, additional loading bbcodes from sql works too.
The bbcodes as an array take 602 lines.
Did you simply turn it back into something similar to SMF's version?
Because it'd be best, I suppose, for plugin authors to 'understand' the thing...
Quote from CerealGuy on February 11th, 06:43 PM
Only problem i have is thinking of a good name for the sql fields and the array field.
Currently the functions are called 'validate' functions, which is in my opinion not describing it well, because you can also modify the content and do more advanced stuff as only validating. Any ideas for a better name? @Nao
Sure.
preprocess for pre-validation
postprocess for validation
Or just 'process' if you want to keep it simple.
3
Features / Re: New revs
Nao « on February 11th, 07:49 PM »
Quote from Nao on February 11th, 04:00 PM
A departure from SMF-based forums: redirectexit() will no longer add the session variable to the URL if it's already in a cookie. I'll be honest with you, I never noticed that variable before, but it's started showing up everywhere in my new server. If you know why, feel free to share! Other than that, this update is very logical, so for those like me who have the problem, there you go. (Subs.php)
Okay, I may have found out why this happened...
https://bugs.php.net/bug.php?id=72940
Apparently, there was a bug between PHP 7.0 and 7.0.10 where the SID constant was defined even when a session cookie was set.
I'm using PHP 7.0.8, so that could be the reason.
At least I wasn't mad... :^^;:
I'm likely to keep that code in place, it's not like it's gonna cause issues after PHP 7.0.10.
4
Bug reports / [Security] Re: BBCode in SQL Database
Nao « on February 9th, 11:26 AM »
Quote from CerealGuy on February 7th, 11:58 AM
Yup, totally aggree with your points. On the other hand, adding bbcodes via plugins is quite a handy thing. So i won't say the idea is bad, just the way it's done in the moment is not the best.
Maybe do... BOTH?!
- Have the main BBCode in a source file,
- Give plugins the ability to add or replace BBCode,
- Only, plugins can't add code in the database, rather a function name. IIRC plugin files are always loaded so it's easy enough to just put the code in a plugin file and it should get executed.

Or, if it's too much to handle, just do points 2 and 3, because it still means putting the code to be executed into a source file, goddammit.
Yeah, that's probably the most realistic solution..?!
Quote
What kind of a server are you using that the configuration issues give you nightmares :hmm:
Well, I've moved Wedge.org and Noisen.com at the same time. Wedge.org was flawless, but Noisen.com is running a heavily customized SMF 2.0 RC, with none of the code fixes to make it run on PHP 7. However, that server can ONLY run one version of PHP (because the admin doesn't want to bother, and it's okay), so I had to manually convert SMF code to PHP 7 *and* my custom code as well, of course... Took at least a day.
If I move my site again, I'll make sure it has PHP 5 as an option. I'd rather use PHP 5 for Noisen, even though it's now working correctly in PHP 7.
Sorry if it was confusing. Wedge was fine.
I'm having Wedge problems with my other new site though, ahah. But again-- server problem. Another server, other problems: this time it's file permissions. The difference is, the admin has been AWOL for 2 months now. Not great...
Quote
PS: It feels good to see wedge back under active developement :D
Yeah, me too. And thank you for being the only developer who still believes in it. :)

Although I never felt back about leaving it -- I just considered it finished. What I'm doing is maintenance work, plus extra minor features from time to time because, well, it's fun?
My game development plans were set aside due to the state of the market. Purely from a business point of view, there just isn't enough visibility for a new game, and for now I don't want to rely on my 'Kyodai' brand name to attain more recognition. So I just focus on selling that old game and building that game trading site. (Which for now is just a game trade matching site. Supposed to be unveiled today, except the site isn't working due to aforementioned permissions ahah.)
5
Archived fixes / [CSS] Re: Login looking bad on small screens
Nao « on February 8th, 08:21 PM »
So... Looked a bit into this commit, and I have a few remarks.
- overflow: auto isn't about adding scrollbars, it's about clearfixing the item. It's a well-known advantage of that overflow type. As long as you don't actually have a div big enough to get scrollbars, it's all fine.
- I tried to revert the commit locally, and only keep the @media override at the end. It worked perfectly that way (i.e. I'm getting what you showed in your last screenshot.). Are you sure you didn't commit too much...? I understand that precedence might be a problem, but you could simply add body #wedge before the declaration, and the .login dt will then get better precedence. However I didn't even get problems myself...
I tried to change the media width to 600px instead of 450, and same results to me.
Interestingly, I also removed the overflow entirely, and didn't get any issues.

Can you look into this..? (e.g. just try wedge.org on your mobile phone and browser...)
6
Features / Re: New revs
Nao « on January 24th, 11:58 PM »
[Commit revision f1bbb2a]
Author: Nao
Date: Sat, 21 Jan 2017 23:48:29 +0100
Stats: 2 files changed; +2 (insertions), -6 (deletions)

  • Fixed a couple of scandir calls to be more fault-tolerant. I think. (ManageAttachments.php, Post.php)

[Commit revision 7ae7331]
Author: Nao
Date: Tue, 24 Jan 2017 23:38:27 +0100
Stats: 1 file changed; +9 (insertions), -1 (deletion)

  • Closing a potential security hole when posting external links in a message. (Subs-BBC.php)

[Commit revision fa107a7]
Author: Nao
Date: Tue, 24 Jan 2017 23:42:23 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • The '%3b' fix for URLs followed from e-mail clients (or even some weird spam bots following these links) was only applied in case semicolons are accepted by the server setup. It is also very much a problem for other setups, believe me I've gone through it, so I'm fixing it as well for them. (QueryString.php)

[Commit revision 7bd17c2]
Author: Nao
Date: Tue, 24 Jan 2017 23:45:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Preventing bots from seeing the skin selector page. As I mentioned in my previous commit, I've seen weird things where Baidu and another bot seem to develop romantic feelings towards any page with action=skin in its name. Maybe because of the name..? I don't know. You tell me. (Subs.php)

[Commit revision 933a87e]
Author: Nao
Date: Tue, 24 Jan 2017 23:50:31 +0100
Stats: 1 file changed; +8 (insertions), -3 (deletions)

  • Unix-based servers see similar folder names like 'Hello' and 'heLLo' as different names. This causes a problem when moving a folder from one server to another. Again, I LIVED THROUGH THAT HORROR. Media gallery folders will now be case insensitive, and simply go through adding a number to the folder name if it already exists, regardless of whether Linux etc. accepts it. Plus, you know I'm a sucker for writing cool geeky one-liners like this one. (Subs-Media.php)

[Commit revision ed2e23e]
Author: Nao
Date: Tue, 24 Jan 2017 23:51:42 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • PHP 7 doesn't like break commands outside of their natural habitat. Let's just assume the author of that library just meant to say 'return'. (getid3/getid3.lib.php)

[Commit revision 174ad41]
Author: Nao
Date: Tue, 24 Jan 2017 23:57:48 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Attempting to fix database errors that come up in MySQL 5.7+ because of strict mode being enabled by default. This is only the beginning, as thought pages also have the problem. (Aeva-Foxy.php)
  • Also a very, very minor bug fix when counting files. I'm not sure it even deserves its own description. You know, the line you're reading right now. Which, if you could just stop for a second and think about it, really says something about your priorities in life. You could be teaching kids how to make pasta, learning a new local language, reading up about agricultural politics in Thailand, and yet you chose to read a changelog about a minor bug in a library that no one uses because, let's be honest here, I'd probably make the world a better place by doing one of the aforementioned things. (Aeva-Subs-Vital.php)
7
Features / Re: New revs
Nao « on January 24th, 11:58 PM »
[Commit revision f1bbb2a]
Author: Nao
Date: Sat, 21 Jan 2017 23:48:29 +0100
Stats: 2 files changed; +2 (insertions), -6 (deletions)

  • Fixed a couple of scandir calls to be more fault-tolerant. I think. (ManageAttachments.php, Post.php)

[Commit revision 7ae7331]
Author: Nao
Date: Tue, 24 Jan 2017 23:38:27 +0100
Stats: 1 file changed; +9 (insertions), -1 (deletion)

  • Closing a potential security hole when posting external links in a message. (Subs-BBC.php)

[Commit revision fa107a7]
Author: Nao
Date: Tue, 24 Jan 2017 23:42:23 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • The '%3b' fix for URLs followed from e-mail clients (or even some weird spam bots following these links) was only applied in case semicolons are accepted by the server setup. It is also very much a problem for other setups, believe me I've gone through it, so I'm fixing it as well for them. (QueryString.php)

[Commit revision 7bd17c2]
Author: Nao
Date: Tue, 24 Jan 2017 23:45:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Preventing bots from seeing the skin selector page. As I mentioned in my previous commit, I've seen weird things where Baidu and another bot seem to develop romantic feelings towards any page with action=skin in its name. Maybe because of the name..? I don't know. You tell me. (Subs.php)

[Commit revision 933a87e]
Author: Nao
Date: Tue, 24 Jan 2017 23:50:31 +0100
Stats: 1 file changed; +8 (insertions), -3 (deletions)

  • Unix-based servers see similar folder names like 'Hello' and 'heLLo' as different names. This causes a problem when moving a folder from one server to another. Again, I LIVED THROUGH THAT HORROR. Media gallery folders will now be case insensitive, and simply go through adding a number to the folder name if it already exists, regardless of whether Linux etc. accepts it. Plus, you know I'm a sucker for writing cool geeky one-liners like this one. (Subs-Media.php)

[Commit revision ed2e23e]
Author: Nao
Date: Tue, 24 Jan 2017 23:51:42 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • PHP 7 doesn't like break commands outside of their natural habitat. Let's just assume the author of that library just meant to say 'return'. (getid3/getid3.lib.php)

[Commit revision 174ad41]
Author: Nao
Date: Tue, 24 Jan 2017 23:57:48 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Attempting to fix database errors that come up in MySQL 5.7+ because of strict mode being enabled by default. This is only the beginning, as thought pages also have the problem. (Aeva-Foxy.php)
  • Also a very, very minor bug fix when counting files. I'm not sure it even deserves its own description. You know, the line you're reading right now. Which, if you could just stop for a second and think about it, really says something about your priorities in life. You could be teaching kids how to make pasta, learning a new local language, reading up about agricultural politics in Thailand, and yet you chose to read a changelog about a minor bug in a library that no one uses because, let's be honest here, I'd probably make the world a better place by doing one of the aforementioned things. (Aeva-Subs-Vital.php)
8
Features / Re: New revs
Nao « on January 20th, 06:55 PM »
[Commit revision d0fe5c4]
Author: Nao
Date: Fri, 20 Jan 2017 18:55:04 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • scandir() returns a filename, not a fully qualified path, making the captcha code sketchy at best. Hey Pete, I miss you fixing your own bugs! ;) (Subs-Captcha.php)
9
Features / Re: New revs
Nao « on January 20th, 06:55 PM »
[Commit revision d0fe5c4]
Author: Nao
Date: Fri, 20 Jan 2017 18:55:04 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • scandir() returns a filename, not a fully qualified path, making the captcha code sketchy at best. Hey Pete, I miss you fixing your own bugs! ;) (Subs-Captcha.php)
10
If you'll excuse me, the BEFORE picture looks like the RIGHT one to me... This CSS bit is intended to make the whole thing work on mobile contexts. Having the prev/next titles shown to the left and right makes no sense in that way. That's why I settled on moving them to the top & bottom. Actually, it's the ONLY reason I used this complicated setup at all... :^^;: